From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id ACE2E683D for ; Wed, 1 Apr 2015 09:45:44 +0200 (CEST) Received: by wibgn9 with SMTP id gn9so55308205wib.1 for ; Wed, 01 Apr 2015 00:45:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=RNhp3kCvfZWRVIZ/8P4appgfHbdPRbf/lE58sSBhY8Q=; b=lw5xq59HKIdQcXnsSbxUSf1fHXeF3vTMSTBmzbqHsXAFBrMztBORDB2OabeTLBx9BZ m7X18ylLfkuIldWbBERpvJOseHRMC4vrfvwDVbysQ7An0DecN+4YikXGRM79LPCFDjvh qfro4nrVDjrCCMfqa5RWC6kttJblOVRcUATVNMR4IfR+AGLRMnh0HS1dqUTOSiSc1x1Z 070pKzfSl3KDDfJ8YVO/XzLgFEEKMcqjGAbtotx1x3fcxG7rTth1gocvBb0vSw61/m5y bZEFTPUJN8UemeeREaqL0ylsvfhlytJMEbJ6qHS3dGYx+nmEwyj4+xxM7DFeyhU9DEW2 9PWQ== X-Gm-Message-State: ALoCoQkFWoTHnCOw6mTZeo/m5ElT8jJsUW/BkH3KUrFQvc5CAqO0WETLWG4U/2oFPPjJJ2WEL7Ag X-Received: by 10.180.107.5 with SMTP id gy5mr12736146wib.0.1427874344546; Wed, 01 Apr 2015 00:45:44 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id hl15sm24194992wib.3.2015.04.01.00.45.43 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Apr 2015 00:45:43 -0700 (PDT) From: Thomas Monjalon To: Stephen Hemminger Date: Wed, 01 Apr 2015 09:45:02 +0200 Message-ID: <1556408.e2XOMCRvgs@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <2601191342CEEE43887BDE71AB977258214074F6@irsmsx105.ger.corp.intel.com> References: <2601191342CEEE43887BDE71AB977258214074F6@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH] ixgbe: do not include CRC in Tx byte count X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2015 07:45:44 -0000 2015-03-24 23:54, Ananyev, Konstantin: > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > On Mon, 23 Mar 2015 16:45:44 +0000 > > "Ananyev, Konstantin" wrote: > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of stephen@networkplumber.org > > > > From: Stephen Hemminger > > > > > > > > The ixgbe driver was including CRC in the transmit packet byte > > > > count, but not for packets received. > > > > This was notice when forwarding and > > > > the number of bytes received was greater than the number of bytes transmitted > > > > for the same number of packets. Make the driver behave like other > > > > virtual devices and not include CRC in byte count. Use the same queue > > > > counters already computed and used for Rx. > > > > > > About RX side stats - as I remember it depends to what value hw_stip_crc is set at configure(). > > > If hw_stip_crc==1, then, yes CRC bytes are not included into QBRC value. > > > I If hw_stip_crc==0, then CRC bytes are included into QBRC. > > > > That is an additional bug! > > * CRC should never be included in the byte count. > > This is not how Linux or other drivers report byte count. > > I don't have any strong opinion here... > For me any method (with or without CRC) of counting bytes are ok, as long as this method is identical across all PMDs we support. > Which makes we wonder, what approach other PMDs use? > > > > > * the byte count must be symmetrical Rx == Tx > > > > The Brocade router always set strip_crc to 1. So did not see the additional bug > > of CRC being included in byte count. > > Are you going to submit v2, to make Rx==Tx for both cases? Any conclusion? Without update, this patch is going to be dropped.