From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 858771B4D1 for ; Wed, 9 Jan 2019 22:36:37 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0339A22AC9; Wed, 9 Jan 2019 16:36:37 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 09 Jan 2019 16:36:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=AM/SBPbM9tBjsJXpzNZiTQCHa+sjxbv/1efEvRUYMVI=; b=T+xxiq+1m9NM UafWy1VUsTx6R4vp47BtpjTn0NQp8Qj+T0Q7bsDg+h+8JWISwCGjVdyeYbdyilXb bjFKK39uYgJse77o9QGmeb1Wa2yEb3hZ8+Cglt14bBOwa+AQFoONtmTDNei1XUJH WgfCDG8z6pohRnlR0h5IQVmglLagy38= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=AM/SBPbM9tBjsJXpzNZiTQCHa+sjxbv/1efEvRUYM VI=; b=KlFtMi8I0lb759ww/hZNp7+TG1syHaQM6ePQOvJdrBQXTyQAo/CcfK63b 5PgFZmzCYwzZLyOXvzfkBSdDABT5LLekN071TzyazYllfESvgdMmAYTkqbROLUy/ tsmSUi5ObP8vRFj5iopcdKilaNOWE8XnGxtoFgDCHyWRBgldkaS0OGiGxMb3cQ73 dVzBnjuGk/0qiletIcyZbQ1RodkEiPQUS0FRJISfrS0bOgv/gxb15No+CxlxJ8j7 YyWajg9aoQvRDiXolBqVABVDAK8cQcw+L85k3tzOwzFjVI/w/+GMK1SvCndchhTx 6iI5tr9v9rl+mZv2aydnX34JhQuuw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrfedugdduheefucdltddurdegtdekrddttd dmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhht necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc fkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpeht hhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CFCA2100BA; Wed, 9 Jan 2019 16:36:35 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: David Marchand , Anatoly Burakov , dev@dpdk.org Date: Wed, 09 Jan 2019 22:36:34 +0100 Message-ID: <1557339.2CBSiR8abE@xps> In-Reply-To: <20190109205159.GA12480@bricha3-MOBL.ger.corp.intel.com> References: <98ec658513d481f8d22c8b438cc3fedc4a718d3f.1547054251.git.anatoly.burakov@intel.com> <20190109205159.GA12480@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: move compat includes to common meson file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 21:36:37 -0000 09/01/2019 21:51, Bruce Richardson: > On Wed, Jan 09, 2019 at 06:29:32PM +0100, David Marchand wrote: > > On Wed, Jan 9, 2019 at 6:18 PM Anatoly Burakov > > <[1]anatoly.burakov@intel.com> wrote: > > > > Currently, while EAL does depend on librte_compat as far as common > > meson build is concerned, for some reason the headers for that > > library are not added into the list of includes. This is fixed in > > Linuxapp-specific meson file, but is absent from FreeBSD meson file. > > This worked fine up until recently, when an rte_compat dependency > > was added to rte_log, which is a common header. Fix this issue by > > adding librte_compat includes to common EAL meson file. > > Fixes: 844514c73569 ("eal: build with meson") > > Fixes: a8499f65a1d1 ("log: add missing experimental tag") > > Cc: [2]bruce.richardson@intel.com > > Cc: [3]david.marchand@redhat.com > > Cc: [4]stable@dpdk.org > > Signed-off-by: Anatoly Burakov <[5]anatoly.burakov@intel.com> > > > > lgtm, thanks. > > Reviewed-by: David Marchand <[6]david.marchand@redhat.com> > > -- > > David Marchand > > > Agreed. > One other point I'd make is that having compat as a separate library seems > a little like overkill to me - it's just one header file! Is there a reason > why we don't just move it into the EAL where everyone can use it without > having to specify another dependency? +1 for moving compat into EAL.