* [dpdk-dev] [PATCH v2] app/testpmd: remove port stop check for macsec
2019-05-10 8:41 ` [dpdk-dev] [PATCH v2] " Wei Zhao
@ 2019-05-10 8:41 ` Wei Zhao
2019-05-13 3:30 ` Zhao1, Wei
2019-06-10 6:07 ` [dpdk-dev] [PATCH v3] " Wei Zhao
2 siblings, 0 replies; 12+ messages in thread
From: Wei Zhao @ 2019-05-10 8:41 UTC (permalink / raw)
To: dev; +Cc: stable, yuan.peng, ferruh.yigit, wenzhuo.lu, Wei Zhao
There is no need to do such a check when set macsec for ixgbe,
reconfig_device_queueand is also useless. If we do not delete this
unnessary code, users have to sotp port before enable or disable
macsec, then restart this port after make configuration. All these
process is useless. As this cmdline is a private API which is only
used by ixgbe NIC, so remove it.
Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
Cc: stable@dpdk.org
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
v2:
-update log info and delete code in disable function
---
app/test-pmd/cmdline.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index c1042dd..dd0f698 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -14044,10 +14044,6 @@ cmd_set_macsec_offload_on_parsed(
if (port_id_is_invalid(port_id, ENABLED_WARN))
return;
- if (!port_is_stopped(port_id)) {
- printf("Please stop port %d first\n", port_id);
- return;
- }
rte_eth_dev_info_get(port_id, &dev_info);
if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) {
@@ -14062,7 +14058,6 @@ cmd_set_macsec_offload_on_parsed(
case 0:
ports[port_id].dev_conf.txmode.offloads |=
DEV_TX_OFFLOAD_MACSEC_INSERT;
- cmd_reconfig_device_queue(port_id, 1, 1);
break;
case -ENODEV:
printf("invalid port_id %d\n", port_id);
@@ -14138,10 +14133,6 @@ cmd_set_macsec_offload_off_parsed(
if (port_id_is_invalid(port_id, ENABLED_WARN))
return;
- if (!port_is_stopped(port_id)) {
- printf("Please stop port %d first\n", port_id);
- return;
- }
rte_eth_dev_info_get(port_id, &dev_info);
if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) {
@@ -14153,7 +14144,6 @@ cmd_set_macsec_offload_off_parsed(
case 0:
ports[port_id].dev_conf.txmode.offloads &=
~DEV_TX_OFFLOAD_MACSEC_INSERT;
- cmd_reconfig_device_queue(port_id, 1, 1);
break;
case -ENODEV:
printf("invalid port_id %d\n", port_id);
--
2.7.5
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH v2] app/testpmd: remove port stop check for macsec
2019-05-10 8:41 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2019-05-10 8:41 ` Wei Zhao
@ 2019-05-13 3:30 ` Zhao1, Wei
2019-05-13 3:30 ` Zhao1, Wei
2019-06-07 13:59 ` Iremonger, Bernard
2019-06-10 6:07 ` [dpdk-dev] [PATCH v3] " Wei Zhao
2 siblings, 2 replies; 12+ messages in thread
From: Zhao1, Wei @ 2019-05-13 3:30 UTC (permalink / raw)
To: dev; +Cc: stable, Peng, Yuan, Yigit, Ferruh, Lu, Wenzhuo
Tested-by: Peng Yuan <yuan.peng@intel.com>
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Friday, May 10, 2019 4:41 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Peng, Yuan <yuan.peng@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>
> Subject: [PATCH v2] app/testpmd: remove port stop check for macsec
>
> There is no need to do such a check when set macsec for ixgbe,
> reconfig_device_queueand is also useless. If we do not delete this unnessary
> code, users have to sotp port before enable or disable macsec, then restart this
> port after make configuration. All these process is useless. As this cmdline is a
> private API which is only used by ixgbe NIC, so remove it.
>
> Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>
> ---
>
> v2:
> -update log info and delete code in disable function
> ---
> app/test-pmd/cmdline.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> c1042dd..dd0f698 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -14044,10 +14044,6 @@ cmd_set_macsec_offload_on_parsed(
>
> if (port_id_is_invalid(port_id, ENABLED_WARN))
> return;
> - if (!port_is_stopped(port_id)) {
> - printf("Please stop port %d first\n", port_id);
> - return;
> - }
>
> rte_eth_dev_info_get(port_id, &dev_info);
> if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT)
> { @@ -14062,7 +14058,6 @@ cmd_set_macsec_offload_on_parsed(
> case 0:
> ports[port_id].dev_conf.txmode.offloads |=
>
> DEV_TX_OFFLOAD_MACSEC_INSERT;
> - cmd_reconfig_device_queue(port_id, 1, 1);
> break;
> case -ENODEV:
> printf("invalid port_id %d\n", port_id); @@ -14138,10 +14133,6
> @@ cmd_set_macsec_offload_off_parsed(
>
> if (port_id_is_invalid(port_id, ENABLED_WARN))
> return;
> - if (!port_is_stopped(port_id)) {
> - printf("Please stop port %d first\n", port_id);
> - return;
> - }
>
> rte_eth_dev_info_get(port_id, &dev_info);
> if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT)
> { @@ -14153,7 +14144,6 @@ cmd_set_macsec_offload_off_parsed(
> case 0:
> ports[port_id].dev_conf.txmode.offloads &=
>
> ~DEV_TX_OFFLOAD_MACSEC_INSERT;
> - cmd_reconfig_device_queue(port_id, 1, 1);
> break;
> case -ENODEV:
> printf("invalid port_id %d\n", port_id);
> --
> 2.7.5
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH v2] app/testpmd: remove port stop check for macsec
2019-05-13 3:30 ` Zhao1, Wei
@ 2019-05-13 3:30 ` Zhao1, Wei
2019-06-07 13:59 ` Iremonger, Bernard
1 sibling, 0 replies; 12+ messages in thread
From: Zhao1, Wei @ 2019-05-13 3:30 UTC (permalink / raw)
To: dev; +Cc: stable, Peng, Yuan, Yigit, Ferruh, Lu, Wenzhuo
Tested-by: Peng Yuan <yuan.peng@intel.com>
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Friday, May 10, 2019 4:41 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Peng, Yuan <yuan.peng@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>
> Subject: [PATCH v2] app/testpmd: remove port stop check for macsec
>
> There is no need to do such a check when set macsec for ixgbe,
> reconfig_device_queueand is also useless. If we do not delete this unnessary
> code, users have to sotp port before enable or disable macsec, then restart this
> port after make configuration. All these process is useless. As this cmdline is a
> private API which is only used by ixgbe NIC, so remove it.
>
> Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>
> ---
>
> v2:
> -update log info and delete code in disable function
> ---
> app/test-pmd/cmdline.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> c1042dd..dd0f698 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -14044,10 +14044,6 @@ cmd_set_macsec_offload_on_parsed(
>
> if (port_id_is_invalid(port_id, ENABLED_WARN))
> return;
> - if (!port_is_stopped(port_id)) {
> - printf("Please stop port %d first\n", port_id);
> - return;
> - }
>
> rte_eth_dev_info_get(port_id, &dev_info);
> if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT)
> { @@ -14062,7 +14058,6 @@ cmd_set_macsec_offload_on_parsed(
> case 0:
> ports[port_id].dev_conf.txmode.offloads |=
>
> DEV_TX_OFFLOAD_MACSEC_INSERT;
> - cmd_reconfig_device_queue(port_id, 1, 1);
> break;
> case -ENODEV:
> printf("invalid port_id %d\n", port_id); @@ -14138,10 +14133,6
> @@ cmd_set_macsec_offload_off_parsed(
>
> if (port_id_is_invalid(port_id, ENABLED_WARN))
> return;
> - if (!port_is_stopped(port_id)) {
> - printf("Please stop port %d first\n", port_id);
> - return;
> - }
>
> rte_eth_dev_info_get(port_id, &dev_info);
> if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT)
> { @@ -14153,7 +14144,6 @@ cmd_set_macsec_offload_off_parsed(
> case 0:
> ports[port_id].dev_conf.txmode.offloads &=
>
> ~DEV_TX_OFFLOAD_MACSEC_INSERT;
> - cmd_reconfig_device_queue(port_id, 1, 1);
> break;
> case -ENODEV:
> printf("invalid port_id %d\n", port_id);
> --
> 2.7.5
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH v2] app/testpmd: remove port stop check for macsec
2019-05-13 3:30 ` Zhao1, Wei
2019-05-13 3:30 ` Zhao1, Wei
@ 2019-06-07 13:59 ` Iremonger, Bernard
2019-06-10 6:40 ` Zhao1, Wei
1 sibling, 1 reply; 12+ messages in thread
From: Iremonger, Bernard @ 2019-06-07 13:59 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: stable, Peng, Yuan, Yigit, Ferruh, Lu, Wenzhuo
Hi Wei,
<snip>
> > Subject: [PATCH v2] app/testpmd: remove port stop check for macsec
> >
> > There is no need to do such a check when set macsec for ixgbe,
> > reconfig_device_queueand is also useless. If we do not delete this
Typo: space missing before "and" in previous line.
> > unnessary code, users have to sotp port before enable or disable
Typo: "sotp" should be "stop"
> > macsec, then restart this port after make configuration. All these
Typo: "these" should be "this"
> > process is useless. As this cmdline is a private API which is only used by ixgbe
> NIC, so remove it.
> >
> > Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Otherwise
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH v2] app/testpmd: remove port stop check for macsec
2019-06-07 13:59 ` Iremonger, Bernard
@ 2019-06-10 6:40 ` Zhao1, Wei
0 siblings, 0 replies; 12+ messages in thread
From: Zhao1, Wei @ 2019-06-10 6:40 UTC (permalink / raw)
To: Iremonger, Bernard, dev; +Cc: stable, Peng, Yuan, Yigit, Ferruh, Lu, Wenzhuo
Thank you, update in v3.
> -----Original Message-----
> From: Iremonger, Bernard
> Sent: Friday, June 7, 2019 9:59 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Peng, Yuan <yuan.peng@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: remove port stop check for
> macsec
>
> Hi Wei,
>
> <snip>
>
> > > Subject: [PATCH v2] app/testpmd: remove port stop check for macsec
> > >
> > > There is no need to do such a check when set macsec for ixgbe,
> > > reconfig_device_queueand is also useless. If we do not delete this
>
> Typo: space missing before "and" in previous line.
>
> > > unnessary code, users have to sotp port before enable or disable
>
> Typo: "sotp" should be "stop"
>
> > > macsec, then restart this port after make configuration. All these
>
> Typo: "these" should be "this"
>
> > > process is useless. As this cmdline is a private API which is only
> > > used by ixgbe
> > NIC, so remove it.
> > >
> > > Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>
> Otherwise
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [dpdk-dev] [PATCH v3] app/testpmd: remove port stop check for macsec
2019-05-10 8:41 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2019-05-10 8:41 ` Wei Zhao
2019-05-13 3:30 ` Zhao1, Wei
@ 2019-06-10 6:07 ` Wei Zhao
2019-06-27 17:23 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2 siblings, 1 reply; 12+ messages in thread
From: Wei Zhao @ 2019-06-10 6:07 UTC (permalink / raw)
To: dev; +Cc: stable, ferruh.yigit, bernard.iremonger, Wei Zhao
There is no need to do such a check when set macsec for ixgbe, and
reconfig_device_queueand is also useless. If we do not delete this
unnessary code, users have to stop port before enable or disable
macsec, then restart this port after make configuration. All these
process are useless. As this cmdline is a private API which is only
used by ixgbe NIC, so remove it.
Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
Cc: stable@dpdk.org
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Tested-by: Peng Yuan <yuan.peng@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
v2:
-update log info and delete code in disable function
v3:
-update typo in log
---
app/test-pmd/cmdline.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index d1e0d44..e7c4bee 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -14044,10 +14044,6 @@ cmd_set_macsec_offload_on_parsed(
if (port_id_is_invalid(port_id, ENABLED_WARN))
return;
- if (!port_is_stopped(port_id)) {
- printf("Please stop port %d first\n", port_id);
- return;
- }
rte_eth_dev_info_get(port_id, &dev_info);
if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) {
@@ -14062,7 +14058,6 @@ cmd_set_macsec_offload_on_parsed(
case 0:
ports[port_id].dev_conf.txmode.offloads |=
DEV_TX_OFFLOAD_MACSEC_INSERT;
- cmd_reconfig_device_queue(port_id, 1, 1);
break;
case -ENODEV:
printf("invalid port_id %d\n", port_id);
@@ -14138,10 +14133,6 @@ cmd_set_macsec_offload_off_parsed(
if (port_id_is_invalid(port_id, ENABLED_WARN))
return;
- if (!port_is_stopped(port_id)) {
- printf("Please stop port %d first\n", port_id);
- return;
- }
rte_eth_dev_info_get(port_id, &dev_info);
if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) {
@@ -14153,7 +14144,6 @@ cmd_set_macsec_offload_off_parsed(
case 0:
ports[port_id].dev_conf.txmode.offloads &=
~DEV_TX_OFFLOAD_MACSEC_INSERT;
- cmd_reconfig_device_queue(port_id, 1, 1);
break;
case -ENODEV:
printf("invalid port_id %d\n", port_id);
--
2.7.5
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/testpmd: remove port stop check for macsec
2019-06-10 6:07 ` [dpdk-dev] [PATCH v3] " Wei Zhao
@ 2019-06-27 17:23 ` Ferruh Yigit
2019-06-30 21:50 ` Thomas Monjalon
0 siblings, 1 reply; 12+ messages in thread
From: Ferruh Yigit @ 2019-06-27 17:23 UTC (permalink / raw)
To: Wei Zhao, dev; +Cc: stable, bernard.iremonger
On 6/10/2019 7:07 AM, Wei Zhao wrote:
> There is no need to do such a check when set macsec for ixgbe, and
> reconfig_device_queueand is also useless. If we do not delete this
> unnessary code, users have to stop port before enable or disable
> macsec, then restart this port after make configuration. All these
> process are useless. As this cmdline is a private API which is only
> used by ixgbe NIC, so remove it.
>
> Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Tested-by: Peng Yuan <yuan.peng@intel.com>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/testpmd: remove port stop check for macsec
2019-06-27 17:23 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
@ 2019-06-30 21:50 ` Thomas Monjalon
2019-07-01 16:39 ` Ferruh Yigit
0 siblings, 1 reply; 12+ messages in thread
From: Thomas Monjalon @ 2019-06-30 21:50 UTC (permalink / raw)
To: Ferruh Yigit, Wei Zhao; +Cc: stable, dev, bernard.iremonger
27/06/2019 19:23, Ferruh Yigit:
> On 6/10/2019 7:07 AM, Wei Zhao wrote:
> > There is no need to do such a check when set macsec for ixgbe, and
> > reconfig_device_queueand is also useless. If we do not delete this
> > unnessary code, users have to stop port before enable or disable
> > macsec, then restart this port after make configuration. All these
> > process are useless. As this cmdline is a private API which is only
> > used by ixgbe NIC, so remove it.
> >
> > Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > Tested-by: Peng Yuan <yuan.peng@intel.com>
> > Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
>
> Applied to dpdk-next-net/master, thanks.
I disagree with the purpose of this patch.
It is removing some "generic" code with the argument that it is
not needed in the case of ixgbe, and ixgbe is the only user.
We may (and probably will) have other PMDs using this command,
so the argument is not OK.
I do not merge this patch in master for now.
Sorry for the inconvenience.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/testpmd: remove port stop check for macsec
2019-06-30 21:50 ` Thomas Monjalon
@ 2019-07-01 16:39 ` Ferruh Yigit
0 siblings, 0 replies; 12+ messages in thread
From: Ferruh Yigit @ 2019-07-01 16:39 UTC (permalink / raw)
To: Thomas Monjalon, Wei Zhao; +Cc: stable, dev, bernard.iremonger
On 6/30/2019 10:50 PM, Thomas Monjalon wrote:
> 27/06/2019 19:23, Ferruh Yigit:
>> On 6/10/2019 7:07 AM, Wei Zhao wrote:
>>> There is no need to do such a check when set macsec for ixgbe, and
>>> reconfig_device_queueand is also useless. If we do not delete this
>>> unnessary code, users have to stop port before enable or disable
>>> macsec, then restart this port after make configuration. All these
>>> process are useless. As this cmdline is a private API which is only
>>> used by ixgbe NIC, so remove it.
>>>
>>> Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>>> Tested-by: Peng Yuan <yuan.peng@intel.com>
>>> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
>>
>> Applied to dpdk-next-net/master, thanks.
>
> I disagree with the purpose of this patch.
> It is removing some "generic" code with the argument that it is
> not needed in the case of ixgbe, and ixgbe is the only user.
> We may (and probably will) have other PMDs using this command,
> so the argument is not OK.
>
> I do not merge this patch in master for now.
> Sorry for the inconvenience.
Dropped from the next-net based on nack
^ permalink raw reply [flat|nested] 12+ messages in thread