From: Sunil Kumar Kori <skori@marvell.com>
To: <dev@dpdk.org>
Cc: <skori@marvell.com>
Subject: [dpdk-dev] [PATCH 0/3] Removing PKT_TX_IP_CKSUM from fragmentation/reassembly lib
Date: Thu, 16 May 2019 16:51:53 +0530 [thread overview]
Message-ID: <1558005716-30083-1-git-send-email-skori@marvell.com> (raw)
Patchset contains below changes:
------------------------------------------------------------
1. Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags
during fragmentation and reassemble operation implicitly.
Because of this, application is forced to use checksum offload
whether it is supported by platform or not.
Also documentation does not provide any expected value of ol_flags
in returned mbuf (reassembled or fragmented) so application will
never come to know that which offloads are enabled. So transmission may
gets failed for the platforms which does not support checksum offload.
Also, IPv6 does not contain any checksum field in header so setting
mbuf->ol_flags with PKT_TX_IP_CKSUM is itself invalid.
So removing mentioned flag from the library.
2. Enabling PKT_TX_IP_CKSUM into mbuf->ol_flags in fragmentation
and reassembly application itself.
Sunil Kumar Kori (3):
lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags
examples/ip_fragmentation: Enabling IP checksum offload in mbuf
examples/ip_reassembly: Enabling IP checksum offload in mbuf
examples/ip_fragmentation/main.c | 7 +++++--
examples/ip_reassembly/main.c | 6 ++++++
lib/librte_ip_frag/rte_ipv4_fragmentation.c | 1 -
lib/librte_ip_frag/rte_ipv4_reassembly.c | 3 ---
lib/librte_ip_frag/rte_ipv6_reassembly.c | 3 ---
5 files changed, 11 insertions(+), 9 deletions(-)
--
1.8.3.1
next reply other threads:[~2019-05-16 11:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 11:21 Sunil Kumar Kori [this message]
2019-05-16 11:21 ` [dpdk-dev] [PATCH 1/3] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags Sunil Kumar Kori
2019-05-16 11:21 ` [dpdk-dev] [PATCH 2/3] examples/ip_fragmentation: Enabling IP checksum offload in mbuf Sunil Kumar Kori
2019-05-16 11:21 ` [dpdk-dev] [PATCH 3/3] examples/ip_reassembly: " Sunil Kumar Kori
2019-05-16 11:24 [dpdk-dev] [PATCH 0/3] Removing PKT_TX_IP_CKSUM from fragmentation/reassembly lib Sunil Kumar Kori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1558005716-30083-1-git-send-email-skori@marvell.com \
--to=skori@marvell.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).