DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 0/2] Introduces armada target
@ 2019-05-17 21:27 lironh
  2019-05-17 21:27 ` [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on armv8-a lironh
  2019-05-17 21:27 ` [dpdk-dev] [PATCH 2/2] meson: " lironh
  0 siblings, 2 replies; 11+ messages in thread
From: lironh @ 2019-05-17 21:27 UTC (permalink / raw)
  To: thomas; +Cc: dev, Liron Himi

From: Liron Himi <lironh@marvell.com>

Introduces armada target to address difference
in number of cores, no numa support

Liron Himi (2):
  mk: add Marvell ARMADA architecture based on armv8-a
  meson: add Marvell ARMADA architecture based on armv8-a

 config/arm/arm64_armada_linux_gcc          | 16 ++++++++++++++++
 config/arm/meson.build                     |  8 +++++++-
 config/defconfig_arm64-armada-linux-gcc    | 24 ++++++++++++++++++++++++
 config/defconfig_arm64-armada-linuxapp-gcc | 24 ++++++++++++++++++++++++
 4 files changed, 71 insertions(+), 1 deletion(-)
 create mode 100644 config/arm/arm64_armada_linux_gcc
 create mode 100644 config/defconfig_arm64-armada-linux-gcc
 create mode 100644 config/defconfig_arm64-armada-linuxapp-gcc

-- 
2.7.4


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on armv8-a
  2019-05-17 21:27 [dpdk-dev] [PATCH 0/2] Introduces armada target lironh
@ 2019-05-17 21:27 ` lironh
  2019-05-22  9:11   ` Ruifeng Wang (Arm Technology China)
  2019-05-23 10:11   ` Ruifeng Wang (Arm Technology China)
  2019-05-17 21:27 ` [dpdk-dev] [PATCH 2/2] meson: " lironh
  1 sibling, 2 replies; 11+ messages in thread
From: lironh @ 2019-05-17 21:27 UTC (permalink / raw)
  To: thomas; +Cc: dev, Liron Himi

From: Liron Himi <lironh@marvell.com>

This patch introduces armada target to address difference
in number of cores, no numa support

Change-Id: Ieaabe77b165000fe1280f98105329a0e63833b92
Signed-off-by: Liron Himi <lironh@marvell.com>
Reviewed-by: Alan Winkowski
Tested-by: Liron Himi
---
 config/defconfig_arm64-armada-linux-gcc    | 24 ++++++++++++++++++++++++
 config/defconfig_arm64-armada-linuxapp-gcc | 24 ++++++++++++++++++++++++
 2 files changed, 48 insertions(+)
 create mode 100644 config/defconfig_arm64-armada-linux-gcc
 create mode 100644 config/defconfig_arm64-armada-linuxapp-gcc

diff --git a/config/defconfig_arm64-armada-linux-gcc b/config/defconfig_arm64-armada-linux-gcc
new file mode 100644
index 0000000..573b278
--- /dev/null
+++ b/config/defconfig_arm64-armada-linux-gcc
@@ -0,0 +1,24 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Marvell International Ltd
+#
+
+#include "defconfig_arm64-armv8a-linux-gcc"
+
+CONFIG_RTE_LIBRTE_MVEP_COMMON=y
+CONFIG_RTE_LIBRTE_MVPP2_PMD=y
+CONFIG_RTE_LIBRTE_MVNETA_PMD=y
+CONFIG_RTE_LIBRTE_PMD_MVSAM_CRYPTO=y
+
+#
+# Compile Environment Abstraction Layer
+#
+CONFIG_RTE_MAX_LCORE=16
+CONFIG_RTE_MAX_NUMA_NODES=1
+CONFIG_RTE_CACHE_LINE_SIZE=64
+
+# Disable NXP as it is conflict with MUSDK
+CONFIG_RTE_LIBRTE_DPAA_BUS=n
+
+# Doesn't support NUMA
+CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n
+CONFIG_RTE_LIBRTE_VHOST_NUMA=n
diff --git a/config/defconfig_arm64-armada-linuxapp-gcc b/config/defconfig_arm64-armada-linuxapp-gcc
new file mode 100644
index 0000000..573b278
--- /dev/null
+++ b/config/defconfig_arm64-armada-linuxapp-gcc
@@ -0,0 +1,24 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Marvell International Ltd
+#
+
+#include "defconfig_arm64-armv8a-linux-gcc"
+
+CONFIG_RTE_LIBRTE_MVEP_COMMON=y
+CONFIG_RTE_LIBRTE_MVPP2_PMD=y
+CONFIG_RTE_LIBRTE_MVNETA_PMD=y
+CONFIG_RTE_LIBRTE_PMD_MVSAM_CRYPTO=y
+
+#
+# Compile Environment Abstraction Layer
+#
+CONFIG_RTE_MAX_LCORE=16
+CONFIG_RTE_MAX_NUMA_NODES=1
+CONFIG_RTE_CACHE_LINE_SIZE=64
+
+# Disable NXP as it is conflict with MUSDK
+CONFIG_RTE_LIBRTE_DPAA_BUS=n
+
+# Doesn't support NUMA
+CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n
+CONFIG_RTE_LIBRTE_VHOST_NUMA=n
-- 
2.7.4


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [dpdk-dev] [PATCH 2/2] meson: add Marvell ARMADA architecture based on armv8-a
  2019-05-17 21:27 [dpdk-dev] [PATCH 0/2] Introduces armada target lironh
  2019-05-17 21:27 ` [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on armv8-a lironh
@ 2019-05-17 21:27 ` lironh
  1 sibling, 0 replies; 11+ messages in thread
From: lironh @ 2019-05-17 21:27 UTC (permalink / raw)
  To: thomas; +Cc: dev, Liron Himi

From: Liron Himi <lironh@marvell.com>

Change-Id: If210dbfeed447df3beffd53339a40e4a9069b6dc
Signed-off-by: Liron Himi <lironh@marvell.com>
Reviewed-by: Jerin Jacob Kollanukkaran <Jerin.Jacob@cavium.com>
---
 config/arm/arm64_armada_linux_gcc | 16 ++++++++++++++++
 config/arm/meson.build            |  8 +++++++-
 2 files changed, 23 insertions(+), 1 deletion(-)
 create mode 100644 config/arm/arm64_armada_linux_gcc

diff --git a/config/arm/arm64_armada_linux_gcc b/config/arm/arm64_armada_linux_gcc
new file mode 100644
index 0000000..6e6d56f
--- /dev/null
+++ b/config/arm/arm64_armada_linux_gcc
@@ -0,0 +1,16 @@
+[binaries]
+c = 'aarch64-linux-gnu-gcc'
+cpp = 'aarch64-linux-gnu-cpp'
+ar = 'aarch64-linux-gnu-ar'
+as = 'aarch64-linux-gnu-as'
+strip = 'aarch64-linux-gnu-strip'
+pcap-config = ''
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv8-a'
+endian = 'little'
+
+[properties]
+implementor_id = '0x56'
diff --git a/config/arm/meson.build b/config/arm/meson.build
index 7fa6ed3..32decba 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -56,6 +56,12 @@ flags_dpaa2 = [
 	['RTE_MAX_NUMA_NODES', 1],
 	['RTE_MAX_LCORE', 16],
 	['RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', false]]
+flags_armada = [
+	['RTE_MACHINE', '"armv8a"'],
+	['RTE_CACHE_LINE_SIZE', 64],
+	['RTE_MAX_NUMA_NODES', 1],
+	['RTE_MAX_LCORE', 16]]
+
 flags_default_extra = []
 flags_thunderx_extra = [
 	['RTE_MACHINE', '"thunderx"'],
@@ -104,7 +110,7 @@ impl_0x4e = ['NVIDIA', flags_generic, machine_args_generic]
 impl_0x50 = ['AppliedMicro', flags_generic, machine_args_generic]
 impl_0x51 = ['Qualcomm', flags_generic, machine_args_generic]
 impl_0x53 = ['Samsung', flags_generic, machine_args_generic]
-impl_0x56 = ['Marvell', flags_generic, machine_args_generic]
+impl_0x56 = ['Marvell ARMADA', flags_armada, machine_args_generic]
 impl_0x69 = ['Intel', flags_generic, machine_args_generic]
 impl_dpaa = ['NXP DPAA', flags_dpaa, machine_args_generic]
 impl_dpaa2 = ['NXP DPAA2', flags_dpaa2, machine_args_generic]
-- 
2.7.4


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on armv8-a
  2019-05-17 21:27 ` [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on armv8-a lironh
@ 2019-05-22  9:11   ` Ruifeng Wang (Arm Technology China)
  2019-05-22  9:12     ` Liron Himi
  2019-05-23 10:11   ` Ruifeng Wang (Arm Technology China)
  1 sibling, 1 reply; 11+ messages in thread
From: Ruifeng Wang (Arm Technology China) @ 2019-05-22  9:11 UTC (permalink / raw)
  To: lironh, thomas; +Cc: dev, nd, nd

Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of lironh@marvell.com
> Sent: Saturday, May 18, 2019 05:27
> To: thomas@monjalon.net
> Cc: dev@dpdk.org; Liron Himi <lironh@marvell.com>
> Subject: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture
> based on armv8-a
> 
> From: Liron Himi <lironh@marvell.com>
> 
> This patch introduces armada target to address difference in number of cores,
> no numa support
> 
> Change-Id: Ieaabe77b165000fe1280f98105329a0e63833b92
> Signed-off-by: Liron Himi <lironh@marvell.com>
> Reviewed-by: Alan Winkowski
> Tested-by: Liron Himi
> ---
>  config/defconfig_arm64-armada-linux-gcc    | 24
> ++++++++++++++++++++++++
>  config/defconfig_arm64-armada-linuxapp-gcc | 24
> ++++++++++++++++++++++++
>  2 files changed, 48 insertions(+)
>  create mode 100644 config/defconfig_arm64-armada-linux-gcc
>  create mode 100644 config/defconfig_arm64-armada-linuxapp-gcc
> 
> diff --git a/config/defconfig_arm64-armada-linux-gcc
> b/config/defconfig_arm64-armada-linux-gcc
> new file mode 100644
> index 0000000..573b278
> --- /dev/null
> +++ b/config/defconfig_arm64-armada-linux-gcc
> @@ -0,0 +1,24 @@
> +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Marvell
> +International Ltd #
> +
> +#include "defconfig_arm64-armv8a-linux-gcc"
> +
> +CONFIG_RTE_LIBRTE_MVEP_COMMON=y
> +CONFIG_RTE_LIBRTE_MVPP2_PMD=y
> +CONFIG_RTE_LIBRTE_MVNETA_PMD=y
> +CONFIG_RTE_LIBRTE_PMD_MVSAM_CRYPTO=y
> +
> +#
> +# Compile Environment Abstraction Layer #
> +CONFIG_RTE_MAX_LCORE=16
> +CONFIG_RTE_MAX_NUMA_NODES=1
> +CONFIG_RTE_CACHE_LINE_SIZE=64
> +
> +# Disable NXP as it is conflict with MUSDK
> CONFIG_RTE_LIBRTE_DPAA_BUS=n
> +
> +# Doesn't support NUMA
> +CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n
> +CONFIG_RTE_LIBRTE_VHOST_NUMA=n
> diff --git a/config/defconfig_arm64-armada-linuxapp-gcc
> b/config/defconfig_arm64-armada-linuxapp-gcc
> new file mode 100644
> index 0000000..573b278
> --- /dev/null
> +++ b/config/defconfig_arm64-armada-linuxapp-gcc
> @@ -0,0 +1,24 @@
> +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Marvell
> +International Ltd #
> +
> +#include "defconfig_arm64-armv8a-linux-gcc"
> +
> +CONFIG_RTE_LIBRTE_MVEP_COMMON=y
> +CONFIG_RTE_LIBRTE_MVPP2_PMD=y
> +CONFIG_RTE_LIBRTE_MVNETA_PMD=y

There is a note in MVPP2 PMD guide, " When MVPP2 PMD is enabled CONFIG_RTE_LIBRTE_MVNETA_PMD must be disabled ".
I think this configuration conflicts with the guide. Does the guide need to be updated?

> +CONFIG_RTE_LIBRTE_PMD_MVSAM_CRYPTO=y
> +
> +#
> +# Compile Environment Abstraction Layer #
> +CONFIG_RTE_MAX_LCORE=16
> +CONFIG_RTE_MAX_NUMA_NODES=1
> +CONFIG_RTE_CACHE_LINE_SIZE=64
> +
> +# Disable NXP as it is conflict with MUSDK
> CONFIG_RTE_LIBRTE_DPAA_BUS=n
> +
> +# Doesn't support NUMA
> +CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n
> +CONFIG_RTE_LIBRTE_VHOST_NUMA=n
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on armv8-a
  2019-05-22  9:11   ` Ruifeng Wang (Arm Technology China)
@ 2019-05-22  9:12     ` Liron Himi
  0 siblings, 0 replies; 11+ messages in thread
From: Liron Himi @ 2019-05-22  9:12 UTC (permalink / raw)
  To: Ruifeng Wang (Arm Technology China), thomas; +Cc: dev, nd, nd, Liron Himi

Hi,



Regards,
Liron

-----Original Message-----
From: Ruifeng Wang (Arm Technology China) <Ruifeng.Wang@arm.com> 
Sent: Wednesday, May 22, 2019 12:11
To: Liron Himi <lironh@marvell.com>; thomas@monjalon.net
Cc: dev@dpdk.org; nd <nd@arm.com>; nd <nd@arm.com>
Subject: [EXT] RE: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on armv8-a

External Email

----------------------------------------------------------------------
Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of lironh@marvell.com
> Sent: Saturday, May 18, 2019 05:27
> To: thomas@monjalon.net
> Cc: dev@dpdk.org; Liron Himi <lironh@marvell.com>
> Subject: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture 
> based on armv8-a
> 
> From: Liron Himi <lironh@marvell.com>
> 
> This patch introduces armada target to address difference in number of 
> cores, no numa support
> 
> Change-Id: Ieaabe77b165000fe1280f98105329a0e63833b92
> Signed-off-by: Liron Himi <lironh@marvell.com>
> Reviewed-by: Alan Winkowski
> Tested-by: Liron Himi
> ---
>  config/defconfig_arm64-armada-linux-gcc    | 24
> ++++++++++++++++++++++++
>  config/defconfig_arm64-armada-linuxapp-gcc | 24
> ++++++++++++++++++++++++
>  2 files changed, 48 insertions(+)
>  create mode 100644 config/defconfig_arm64-armada-linux-gcc
>  create mode 100644 config/defconfig_arm64-armada-linuxapp-gcc
> 
> diff --git a/config/defconfig_arm64-armada-linux-gcc
> b/config/defconfig_arm64-armada-linux-gcc
> new file mode 100644
> index 0000000..573b278
> --- /dev/null
> +++ b/config/defconfig_arm64-armada-linux-gcc
> @@ -0,0 +1,24 @@
> +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Marvell 
> +International Ltd #
> +
> +#include "defconfig_arm64-armv8a-linux-gcc"
> +
> +CONFIG_RTE_LIBRTE_MVEP_COMMON=y
> +CONFIG_RTE_LIBRTE_MVPP2_PMD=y
> +CONFIG_RTE_LIBRTE_MVNETA_PMD=y
> +CONFIG_RTE_LIBRTE_PMD_MVSAM_CRYPTO=y
> +
> +#
> +# Compile Environment Abstraction Layer #
> +CONFIG_RTE_MAX_LCORE=16
> +CONFIG_RTE_MAX_NUMA_NODES=1
> +CONFIG_RTE_CACHE_LINE_SIZE=64
> +
> +# Disable NXP as it is conflict with MUSDK
> CONFIG_RTE_LIBRTE_DPAA_BUS=n
> +
> +# Doesn't support NUMA
> +CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n
> +CONFIG_RTE_LIBRTE_VHOST_NUMA=n
> diff --git a/config/defconfig_arm64-armada-linuxapp-gcc
> b/config/defconfig_arm64-armada-linuxapp-gcc
> new file mode 100644
> index 0000000..573b278
> --- /dev/null
> +++ b/config/defconfig_arm64-armada-linuxapp-gcc
> @@ -0,0 +1,24 @@
> +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Marvell 
> +International Ltd #
> +
> +#include "defconfig_arm64-armv8a-linux-gcc"
> +
> +CONFIG_RTE_LIBRTE_MVEP_COMMON=y
> +CONFIG_RTE_LIBRTE_MVPP2_PMD=y
> +CONFIG_RTE_LIBRTE_MVNETA_PMD=y

There is a note in MVPP2 PMD guide, " When MVPP2 PMD is enabled CONFIG_RTE_LIBRTE_MVNETA_PMD must be disabled ".
I think this configuration conflicts with the guide. Does the guide need to be updated?
[L.H.] yes, I will submit another patch with documentation updates.

> +CONFIG_RTE_LIBRTE_PMD_MVSAM_CRYPTO=y
> +
> +#
> +# Compile Environment Abstraction Layer #
> +CONFIG_RTE_MAX_LCORE=16
> +CONFIG_RTE_MAX_NUMA_NODES=1
> +CONFIG_RTE_CACHE_LINE_SIZE=64
> +
> +# Disable NXP as it is conflict with MUSDK
> CONFIG_RTE_LIBRTE_DPAA_BUS=n
> +
> +# Doesn't support NUMA
> +CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n
> +CONFIG_RTE_LIBRTE_VHOST_NUMA=n
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on armv8-a
  2019-05-17 21:27 ` [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on armv8-a lironh
  2019-05-22  9:11   ` Ruifeng Wang (Arm Technology China)
@ 2019-05-23 10:11   ` Ruifeng Wang (Arm Technology China)
  2019-05-23 10:51     ` Liron Himi
  1 sibling, 1 reply; 11+ messages in thread
From: Ruifeng Wang (Arm Technology China) @ 2019-05-23 10:11 UTC (permalink / raw)
  To: lironh, thomas; +Cc: dev, nd

Hi Liron,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of lironh@marvell.com
> Sent: Saturday, May 18, 2019 05:27
> To: thomas@monjalon.net
> Cc: dev@dpdk.org; Liron Himi <lironh@marvell.com>
> Subject: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture
> based on armv8-a
> 
> From: Liron Himi <lironh@marvell.com>
> 
> This patch introduces armada target to address difference in number of cores,
> no numa support
> 
> Change-Id: Ieaabe77b165000fe1280f98105329a0e63833b92
> Signed-off-by: Liron Himi <lironh@marvell.com>
> Reviewed-by: Alan Winkowski
> Tested-by: Liron Himi
> ---

My local compilation on MacchiatoBin failed with the target.
I have musdk-armada-18.09 checked out from https://github.com/MarvellEmbeddedProcessors/musdk-marvell.git
LIBMUSDK_PATH was set before compiling.
Hit errors as below:
	== Build drivers/net/mvneta
	  CC mvneta_ethdev.o
	In file included from /home/arm/dpdk/drivers/net/mvneta/mvneta_rxtx.h:10:0,
					 from /home/arm/dpdk/drivers/net/mvneta/mvneta_ethdev.c:25:
	/home/arm/dpdk/drivers/net/mvneta/mvneta_ethdev.h:24:29: fatal error: drivers/mv_neta.h: No such file or directory
	compilation terminated.
	/home/arm/dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target 'mvneta_ethdev.o' failed

I tried to copy  the files from musdk to LIBMUSDK_PATH, but still cannot finish compiling.
	  CC test_ipsec.o
	  LD test
	/home/arm/dpdk/arm64-armada-linuxapp-gcc/lib/librte_pmd_mvneta.a(mvneta_ethdev.o): In function `mvneta_stats_get':
	mvneta_ethdev.c:(.text+0x1c4): undefined reference to `neta_ppio_get_statistics'
	/home/arm/dpdk/arm64-armada-linuxapp-gcc/lib/librte_pmd_mvneta.a(mvneta_ethdev.o): In function `mvneta_mtu_set':
	mvneta_ethdev.c:(.text+0x368): undefined reference to `neta_ppio_set_mru'
	mvneta_ethdev.c:(.text+0x37c): undefined reference to `neta_ppio_set_mtu'
	/home/arm/dpdk/arm64-armada-linuxapp-gcc/lib/librte_pmd_mvneta.a(mvneta_ethdev.o): In function `mvneta_promiscuous_disable':
	mvneta_ethdev.c:(.text+0x4e4): undefined reference to `neta_ppio_get_promisc'
	mvneta_ethdev.c:(.text+0x4f8): undefined reference to `neta_ppio_set_promisc'
	......

My musdk repo is updated. Is anything else needed?

Regards,
/Ruifeng

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on armv8-a
  2019-05-23 10:11   ` Ruifeng Wang (Arm Technology China)
@ 2019-05-23 10:51     ` Liron Himi
  2019-05-24  1:10       ` Ruifeng Wang (Arm Technology China)
  0 siblings, 1 reply; 11+ messages in thread
From: Liron Himi @ 2019-05-23 10:51 UTC (permalink / raw)
  To: Ruifeng Wang (Arm Technology China), thomas; +Cc: dev, nd, Liron Himi

Hi,

This patch can only work with MUSDK newer than 18.09.
Do you have access to a newer version?

Regards,
Liron

-----Original Message-----
From: Ruifeng Wang (Arm Technology China) <Ruifeng.Wang@arm.com> 
Sent: Thursday, May 23, 2019 13:11
To: Liron Himi <lironh@marvell.com>; thomas@monjalon.net
Cc: dev@dpdk.org; nd <nd@arm.com>
Subject: [EXT] RE: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on armv8-a

External Email

----------------------------------------------------------------------
Hi Liron,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of lironh@marvell.com
> Sent: Saturday, May 18, 2019 05:27
> To: thomas@monjalon.net
> Cc: dev@dpdk.org; Liron Himi <lironh@marvell.com>
> Subject: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture 
> based on armv8-a
> 
> From: Liron Himi <lironh@marvell.com>
> 
> This patch introduces armada target to address difference in number of 
> cores, no numa support
> 
> Change-Id: Ieaabe77b165000fe1280f98105329a0e63833b92
> Signed-off-by: Liron Himi <lironh@marvell.com>
> Reviewed-by: Alan Winkowski
> Tested-by: Liron Himi
> ---

My local compilation on MacchiatoBin failed with the target.
I have musdk-armada-18.09 checked out from https://github.com/MarvellEmbeddedProcessors/musdk-marvell.git
LIBMUSDK_PATH was set before compiling.
Hit errors as below:
	== Build drivers/net/mvneta
	  CC mvneta_ethdev.o
	In file included from /home/arm/dpdk/drivers/net/mvneta/mvneta_rxtx.h:10:0,
					 from /home/arm/dpdk/drivers/net/mvneta/mvneta_ethdev.c:25:
	/home/arm/dpdk/drivers/net/mvneta/mvneta_ethdev.h:24:29: fatal error: drivers/mv_neta.h: No such file or directory
	compilation terminated.
	/home/arm/dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target 'mvneta_ethdev.o' failed

I tried to copy  the files from musdk to LIBMUSDK_PATH, but still cannot finish compiling.
	  CC test_ipsec.o
	  LD test
	/home/arm/dpdk/arm64-armada-linuxapp-gcc/lib/librte_pmd_mvneta.a(mvneta_ethdev.o): In function `mvneta_stats_get':
	mvneta_ethdev.c:(.text+0x1c4): undefined reference to `neta_ppio_get_statistics'
	/home/arm/dpdk/arm64-armada-linuxapp-gcc/lib/librte_pmd_mvneta.a(mvneta_ethdev.o): In function `mvneta_mtu_set':
	mvneta_ethdev.c:(.text+0x368): undefined reference to `neta_ppio_set_mru'
	mvneta_ethdev.c:(.text+0x37c): undefined reference to `neta_ppio_set_mtu'
	/home/arm/dpdk/arm64-armada-linuxapp-gcc/lib/librte_pmd_mvneta.a(mvneta_ethdev.o): In function `mvneta_promiscuous_disable':
	mvneta_ethdev.c:(.text+0x4e4): undefined reference to `neta_ppio_get_promisc'
	mvneta_ethdev.c:(.text+0x4f8): undefined reference to `neta_ppio_set_promisc'
	......

My musdk repo is updated. Is anything else needed?

Regards,
/Ruifeng

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on armv8-a
  2019-05-23 10:51     ` Liron Himi
@ 2019-05-24  1:10       ` Ruifeng Wang (Arm Technology China)
  2019-05-24 13:06         ` Ferruh Yigit
  0 siblings, 1 reply; 11+ messages in thread
From: Ruifeng Wang (Arm Technology China) @ 2019-05-24  1:10 UTC (permalink / raw)
  To: Liron Himi, thomas; +Cc: dev, nd, Gavin Hu (Arm Technology China), nd

Hi,

> -----Original Message-----
> From: Liron Himi <lironh@marvell.com>
> Sent: Thursday, May 23, 2019 18:51
> To: Ruifeng Wang (Arm Technology China) <Ruifeng.Wang@arm.com>;
> thomas@monjalon.net
> Cc: dev@dpdk.org; nd <nd@arm.com>; Liron Himi <lironh@marvell.com>
> Subject: RE: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture
> based on armv8-a
> 
> Hi,
> 
> This patch can only work with MUSDK newer than 18.09.
> Do you have access to a newer version?

Will newer MUSDK version available on github?
I have no access to Marvell Extranet.

> 
> Regards,
> Liron
> 
> -----Original Message-----
> From: Ruifeng Wang (Arm Technology China) <Ruifeng.Wang@arm.com>
> Sent: Thursday, May 23, 2019 13:11
> To: Liron Himi <lironh@marvell.com>; thomas@monjalon.net
> Cc: dev@dpdk.org; nd <nd@arm.com>
> Subject: [EXT] RE: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA
> architecture based on armv8-a
> 
> External Email
> 
> ----------------------------------------------------------------------
> Hi Liron,
> 
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of lironh@marvell.com
> > Sent: Saturday, May 18, 2019 05:27
> > To: thomas@monjalon.net
> > Cc: dev@dpdk.org; Liron Himi <lironh@marvell.com>
> > Subject: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture
> > based on armv8-a
> >
> > From: Liron Himi <lironh@marvell.com>
> >
> > This patch introduces armada target to address difference in number of
> > cores, no numa support
> >
> > Change-Id: Ieaabe77b165000fe1280f98105329a0e63833b92
> > Signed-off-by: Liron Himi <lironh@marvell.com>
> > Reviewed-by: Alan Winkowski
> > Tested-by: Liron Himi
> > ---
> 
> My local compilation on MacchiatoBin failed with the target.
> I have musdk-armada-18.09 checked out from
> https://github.com/MarvellEmbeddedProcessors/musdk-marvell.git
> LIBMUSDK_PATH was set before compiling.
> Hit errors as below:
> 	== Build drivers/net/mvneta
> 	  CC mvneta_ethdev.o
> 	In file included from
> /home/arm/dpdk/drivers/net/mvneta/mvneta_rxtx.h:10:0,
> 					 from
> /home/arm/dpdk/drivers/net/mvneta/mvneta_ethdev.c:25:
> 	/home/arm/dpdk/drivers/net/mvneta/mvneta_ethdev.h:24:29:
> fatal error: drivers/mv_neta.h: No such file or directory
> 	compilation terminated.
> 	/home/arm/dpdk/mk/internal/rte.compile-pre.mk:114: recipe for
> target 'mvneta_ethdev.o' failed
> 
> I tried to copy  the files from musdk to LIBMUSDK_PATH, but still cannot
> finish compiling.
> 	  CC test_ipsec.o
> 	  LD test
> 	/home/arm/dpdk/arm64-armada-linuxapp-
> gcc/lib/librte_pmd_mvneta.a(mvneta_ethdev.o): In function
> `mvneta_stats_get':
> 	mvneta_ethdev.c:(.text+0x1c4): undefined reference to
> `neta_ppio_get_statistics'
> 	/home/arm/dpdk/arm64-armada-linuxapp-
> gcc/lib/librte_pmd_mvneta.a(mvneta_ethdev.o): In function
> `mvneta_mtu_set':
> 	mvneta_ethdev.c:(.text+0x368): undefined reference to
> `neta_ppio_set_mru'
> 	mvneta_ethdev.c:(.text+0x37c): undefined reference to
> `neta_ppio_set_mtu'
> 	/home/arm/dpdk/arm64-armada-linuxapp-
> gcc/lib/librte_pmd_mvneta.a(mvneta_ethdev.o): In function
> `mvneta_promiscuous_disable':
> 	mvneta_ethdev.c:(.text+0x4e4): undefined reference to
> `neta_ppio_get_promisc'
> 	mvneta_ethdev.c:(.text+0x4f8): undefined reference to
> `neta_ppio_set_promisc'
> 	......
> 
> My musdk repo is updated. Is anything else needed?
> 
> Regards,
> /Ruifeng

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on armv8-a
  2019-05-24  1:10       ` Ruifeng Wang (Arm Technology China)
@ 2019-05-24 13:06         ` Ferruh Yigit
  2019-05-27  1:42           ` Ruifeng Wang (Arm Technology China)
  0 siblings, 1 reply; 11+ messages in thread
From: Ferruh Yigit @ 2019-05-24 13:06 UTC (permalink / raw)
  To: Ruifeng Wang (Arm Technology China), Liron Himi, thomas
  Cc: dev, nd, Gavin Hu (Arm Technology China)

On 5/24/2019 2:10 AM, Ruifeng Wang (Arm Technology China) wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Liron Himi <lironh@marvell.com>
>> Sent: Thursday, May 23, 2019 18:51
>> To: Ruifeng Wang (Arm Technology China) <Ruifeng.Wang@arm.com>;
>> thomas@monjalon.net
>> Cc: dev@dpdk.org; nd <nd@arm.com>; Liron Himi <lironh@marvell.com>
>> Subject: RE: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture
>> based on armv8-a
>>
>> Hi,
>>
>> This patch can only work with MUSDK newer than 18.09.
>> Do you have access to a newer version?
> 
> Will newer MUSDK version available on github?
> I have no access to Marvell Extranet.

+1, in github [1] latest branch I can see is 18.09

[1]: https://github.com/MarvellEmbeddedProcessors/musdk-marvell.git

> 
>>
>> Regards,
>> Liron
>>
>> -----Original Message-----
>> From: Ruifeng Wang (Arm Technology China) <Ruifeng.Wang@arm.com>
>> Sent: Thursday, May 23, 2019 13:11
>> To: Liron Himi <lironh@marvell.com>; thomas@monjalon.net
>> Cc: dev@dpdk.org; nd <nd@arm.com>
>> Subject: [EXT] RE: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA
>> architecture based on armv8-a
>>
>> External Email
>>
>> ----------------------------------------------------------------------
>> Hi Liron,
>>
>>> -----Original Message-----
>>> From: dev <dev-bounces@dpdk.org> On Behalf Of lironh@marvell.com
>>> Sent: Saturday, May 18, 2019 05:27
>>> To: thomas@monjalon.net
>>> Cc: dev@dpdk.org; Liron Himi <lironh@marvell.com>
>>> Subject: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture
>>> based on armv8-a
>>>
>>> From: Liron Himi <lironh@marvell.com>
>>>
>>> This patch introduces armada target to address difference in number of
>>> cores, no numa support
>>>
>>> Change-Id: Ieaabe77b165000fe1280f98105329a0e63833b92
>>> Signed-off-by: Liron Himi <lironh@marvell.com>
>>> Reviewed-by: Alan Winkowski
>>> Tested-by: Liron Himi
>>> ---
>>
>> My local compilation on MacchiatoBin failed with the target.
>> I have musdk-armada-18.09 checked out from
>> https://github.com/MarvellEmbeddedProcessors/musdk-marvell.git
>> LIBMUSDK_PATH was set before compiling.
>> Hit errors as below:
>> 	== Build drivers/net/mvneta
>> 	  CC mvneta_ethdev.o
>> 	In file included from
>> /home/arm/dpdk/drivers/net/mvneta/mvneta_rxtx.h:10:0,
>> 					 from
>> /home/arm/dpdk/drivers/net/mvneta/mvneta_ethdev.c:25:
>> 	/home/arm/dpdk/drivers/net/mvneta/mvneta_ethdev.h:24:29:
>> fatal error: drivers/mv_neta.h: No such file or directory
>> 	compilation terminated.
>> 	/home/arm/dpdk/mk/internal/rte.compile-pre.mk:114: recipe for
>> target 'mvneta_ethdev.o' failed
>>
>> I tried to copy  the files from musdk to LIBMUSDK_PATH, but still cannot
>> finish compiling.
>> 	  CC test_ipsec.o
>> 	  LD test
>> 	/home/arm/dpdk/arm64-armada-linuxapp-
>> gcc/lib/librte_pmd_mvneta.a(mvneta_ethdev.o): In function
>> `mvneta_stats_get':
>> 	mvneta_ethdev.c:(.text+0x1c4): undefined reference to
>> `neta_ppio_get_statistics'
>> 	/home/arm/dpdk/arm64-armada-linuxapp-
>> gcc/lib/librte_pmd_mvneta.a(mvneta_ethdev.o): In function
>> `mvneta_mtu_set':
>> 	mvneta_ethdev.c:(.text+0x368): undefined reference to
>> `neta_ppio_set_mru'
>> 	mvneta_ethdev.c:(.text+0x37c): undefined reference to
>> `neta_ppio_set_mtu'
>> 	/home/arm/dpdk/arm64-armada-linuxapp-
>> gcc/lib/librte_pmd_mvneta.a(mvneta_ethdev.o): In function
>> `mvneta_promiscuous_disable':
>> 	mvneta_ethdev.c:(.text+0x4e4): undefined reference to
>> `neta_ppio_get_promisc'
>> 	mvneta_ethdev.c:(.text+0x4f8): undefined reference to
>> `neta_ppio_set_promisc'
>> 	......
>>
>> My musdk repo is updated. Is anything else needed?
>>
>> Regards,
>> /Ruifeng


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on armv8-a
  2019-05-24 13:06         ` Ferruh Yigit
@ 2019-05-27  1:42           ` Ruifeng Wang (Arm Technology China)
  0 siblings, 0 replies; 11+ messages in thread
From: Ruifeng Wang (Arm Technology China) @ 2019-05-27  1:42 UTC (permalink / raw)
  To: Ferruh Yigit, Liron Himi, thomas
  Cc: dev, nd, Gavin Hu (Arm Technology China), nd


> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Friday, May 24, 2019 21:07
> To: Ruifeng Wang (Arm Technology China) <Ruifeng.Wang@arm.com>; Liron
> Himi <lironh@marvell.com>; thomas@monjalon.net
> Cc: dev@dpdk.org; nd <nd@arm.com>; Gavin Hu (Arm Technology China)
> <Gavin.Hu@arm.com>
> Subject: Re: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture
> based on armv8-a
> 
> On 5/24/2019 2:10 AM, Ruifeng Wang (Arm Technology China) wrote:
> > Hi,
> >
> >> -----Original Message-----
> >> From: Liron Himi <lironh@marvell.com>
> >> Sent: Thursday, May 23, 2019 18:51
> >> To: Ruifeng Wang (Arm Technology China) <Ruifeng.Wang@arm.com>;
> >> thomas@monjalon.net
> >> Cc: dev@dpdk.org; nd <nd@arm.com>; Liron Himi <lironh@marvell.com>
> >> Subject: RE: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA
> >> architecture based on armv8-a
> >>
> >> Hi,
> >>
> >> This patch can only work with MUSDK newer than 18.09.
> >> Do you have access to a newer version?
> >
> > Will newer MUSDK version available on github?
> > I have no access to Marvell Extranet.
> 
> +1, in github [1] latest branch I can see is 18.09
> 
> [1]: https://github.com/MarvellEmbeddedProcessors/musdk-marvell.git
> 

With guide from Liron, I can build ARMADA target with MUSDK version 18.09 (after properly configured).

Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [dpdk-dev] [PATCH 0/2] Introduces armada target
@ 2019-05-17 21:34 lironh
  0 siblings, 0 replies; 11+ messages in thread
From: lironh @ 2019-05-17 21:34 UTC (permalink / raw)
  To: thomas; +Cc: dev, Liron Himi

From: Liron Himi <lironh@marvell.com>

Introduces armada target to address difference
in number of cores, no numa support

Liron Himi (2):
  mk: add Marvell ARMADA architecture based on armv8-a
  meson: add Marvell ARMADA architecture based on armv8-a

 config/arm/arm64_armada_linux_gcc          | 16 ++++++++++++++++
 config/arm/meson.build                     |  8 +++++++-
 config/defconfig_arm64-armada-linux-gcc    | 24 ++++++++++++++++++++++++
 config/defconfig_arm64-armada-linuxapp-gcc | 24 ++++++++++++++++++++++++
 4 files changed, 71 insertions(+), 1 deletion(-)
 create mode 100644 config/arm/arm64_armada_linux_gcc
 create mode 100644 config/defconfig_arm64-armada-linux-gcc
 create mode 100644 config/defconfig_arm64-armada-linuxapp-gcc

-- 
2.7.4


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2019-05-27  1:42 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-17 21:27 [dpdk-dev] [PATCH 0/2] Introduces armada target lironh
2019-05-17 21:27 ` [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on armv8-a lironh
2019-05-22  9:11   ` Ruifeng Wang (Arm Technology China)
2019-05-22  9:12     ` Liron Himi
2019-05-23 10:11   ` Ruifeng Wang (Arm Technology China)
2019-05-23 10:51     ` Liron Himi
2019-05-24  1:10       ` Ruifeng Wang (Arm Technology China)
2019-05-24 13:06         ` Ferruh Yigit
2019-05-27  1:42           ` Ruifeng Wang (Arm Technology China)
2019-05-17 21:27 ` [dpdk-dev] [PATCH 2/2] meson: " lironh
2019-05-17 21:34 [dpdk-dev] [PATCH 0/2] Introduces armada target lironh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).