DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Michael Qiu <michael.qiu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] librte_pmd_ixgbe: Add queue start failure check
Date: Tue, 27 Jan 2015 15:12:18 +0100	[thread overview]
Message-ID: <1558492.KSTKnLp9iV@xps13> (raw)
In-Reply-To: <1422360978-16954-1-git-send-email-michael.qiu@intel.com>

2015-01-27 20:16, Michael Qiu:
> For ixgbe, when queue start failure, for example, mbuf allocate
> failure, the device will still start success, which could be
> an issue.
> 
> Add return status check of queue start to avoid this issue.
> 
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> ---
> v2 --> v1
> 	. remove duplicated error message in ixgbe_dev_rxtx_start()
> 	. remove '\n' in PMD_INIT_LOG()

So the braces are not needed anymore (reported by checkpatch):
> +			if (ret < 0) {
> +				return ret;
> +			}

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Applied with removed braces

Thanks
-- 
Thomas

      reply	other threads:[~2015-01-27 14:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-15 14:45 [dpdk-dev] [PATCH] " Michael Qiu
2015-01-19 15:50 ` Qiu, Michael
2015-01-27 10:00 ` Thomas Monjalon
2015-01-27 12:00   ` Qiu, Michael
2015-01-27 14:14     ` Thomas Monjalon
2015-01-27 12:16 ` [dpdk-dev] [PATCH v2] " Michael Qiu
2015-01-27 14:12   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1558492.KSTKnLp9iV@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=michael.qiu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).