From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) by dpdk.org (Postfix) with ESMTP id 4E9CF5B01 for ; Tue, 27 Jan 2015 15:12:46 +0100 (CET) Received: by mail-we0-f181.google.com with SMTP id k48so15148877wev.12 for ; Tue, 27 Jan 2015 06:12:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=xktcQghOlOhKSDzJ9vILk3c3X95FKWYINYpHVWIh5HY=; b=FU+VloVAqf59UDHc+QQdl7t3dBFd7JSmdnXZxiXWPhicCbuR/ZfbxJ4ofPsIdKa7e+ ebplkRq06OzQ+sKfNMNVWNlKaRGWeUnQVLBBnjv4uz5gRCBXWNXuyviCq6aZhLCgxRKx /MHHkgTq5UO5FCIaCpSsZb2TxsB4Lm+KhVXYncBcsWeu9/dZOnkJK3AyUd6+2W1H/67G 2hNYyL5Zw+3jzwPbj9VOFuKu2rhJO6huIe1fWGIZix4B1fCZ2GgHInfGdJDuClPWjVNo 0eyOKj4wN6eHeuqnmpO3SNLnNh7o2hn+TDfK/RDnr0mlDEvC9nTbYuIz5zq+RQGG2Wi4 Q+Mw== X-Gm-Message-State: ALoCoQlDATggsuBV03GGKQJuBnRAMs573oJDiy9HiW6MBtY/S2dHmri5lBTpZmMIql9unikCIjSo X-Received: by 10.180.103.40 with SMTP id ft8mr42748126wib.68.1422367966123; Tue, 27 Jan 2015 06:12:46 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id fi10sm18289264wib.13.2015.01.27.06.12.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Jan 2015 06:12:45 -0800 (PST) From: Thomas Monjalon To: Michael Qiu Date: Tue, 27 Jan 2015 15:12:18 +0100 Message-ID: <1558492.KSTKnLp9iV@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.18.2-2-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1422360978-16954-1-git-send-email-michael.qiu@intel.com> References: <1421333111-22136-1-git-send-email-michael.qiu@intel.com> <1422360978-16954-1-git-send-email-michael.qiu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] librte_pmd_ixgbe: Add queue start failure check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2015 14:12:46 -0000 2015-01-27 20:16, Michael Qiu: > For ixgbe, when queue start failure, for example, mbuf allocate > failure, the device will still start success, which could be > an issue. > > Add return status check of queue start to avoid this issue. > > Signed-off-by: Michael Qiu > --- > v2 --> v1 > . remove duplicated error message in ixgbe_dev_rxtx_start() > . remove '\n' in PMD_INIT_LOG() So the braces are not needed anymore (reported by checkpatch): > + if (ret < 0) { > + return ret; > + } Acked-by: Thomas Monjalon Applied with removed braces Thanks -- Thomas