DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] kni: fix build on RHEL8
@ 2019-05-27  4:02 michael.luo
  2019-05-29 21:48 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
  0 siblings, 1 reply; 4+ messages in thread
From: michael.luo @ 2019-05-27  4:02 UTC (permalink / raw)
  To: dev; +Cc: stable

From: Luo Gaoliang <michael.luo@intel.com>

Build error was seen on RHEL8 when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled.

Build error log:
/root/kni/dpdk-19.05/kernel/linux/kni/ethtool/igb/kcompat.h:3928:25:
error: 'const struct net_device_ops' has no member named 'extended'
 #define ndo_set_vf_vlan extended.ndo_set_vf_vlan
                         ^~~~~~~~

RHEL8 defined ndo_set_vf_vlan in net_device_ops as well as the mainline kernel.

Signed-off-by: Luo Gaoliang <michael.luo@intel.com>
---
 kernel/linux/kni/ethtool/igb/kcompat.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/linux/kni/ethtool/igb/kcompat.h b/kernel/linux/kni/ethtool/igb/kcompat.h
index 649a69c..f041a3e 100644
--- a/kernel/linux/kni/ethtool/igb/kcompat.h
+++ b/kernel/linux/kni/ethtool/igb/kcompat.h
@@ -3922,7 +3922,8 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
      (SLE_VERSION_CODE && SLE_VERSION_CODE >= SLE_VERSION(12, 3, 0)) || \
      (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 4)))
 #define HAVE_VF_VLAN_PROTO
-#if (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 4))
+#if ((RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 4)) && \
+	(RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)))
 /* In RHEL/Centos 7.4, the "new" version of ndo_set_vf_vlan
  * is in the struct net_device_ops_extended */
 #define ndo_set_vf_vlan extended.ndo_set_vf_vlan
-- 
2.7.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] kni: fix build on RHEL8
  2019-05-27  4:02 [dpdk-dev] [PATCH] kni: fix build on RHEL8 michael.luo
@ 2019-05-29 21:48 ` Thomas Monjalon
  2019-06-04 15:00   ` Ferruh Yigit
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2019-05-29 21:48 UTC (permalink / raw)
  To: ferruh.yigit, Yongseok Koh, ktraynor; +Cc: stable, michael.luo, dev

27/05/2019 06:02, michael.luo@intel.com:
> From: Luo Gaoliang <michael.luo@intel.com>
> 
> Build error was seen on RHEL8 when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled.
> 
> Build error log:
> /root/kni/dpdk-19.05/kernel/linux/kni/ethtool/igb/kcompat.h:3928:25:
> error: 'const struct net_device_ops' has no member named 'extended'
>  #define ndo_set_vf_vlan extended.ndo_set_vf_vlan
>                          ^~~~~~~~

This module has been removed from DPDK:
	http://git.dpdk.org/dpdk/commit/?id=ea6b39b5b84

Do we want to apply this patch directly in older releases (LTS)?




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] kni: fix build on RHEL8
  2019-05-29 21:48 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
@ 2019-06-04 15:00   ` Ferruh Yigit
  2019-06-04 15:23     ` Kevin Traynor
  0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2019-06-04 15:00 UTC (permalink / raw)
  To: Thomas Monjalon, Yongseok Koh, ktraynor; +Cc: stable, michael.luo, dev

On 5/29/2019 10:48 PM, Thomas Monjalon wrote:
> 27/05/2019 06:02, michael.luo@intel.com:
>> From: Luo Gaoliang <michael.luo@intel.com>
>>
>> Build error was seen on RHEL8 when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled.
>>
>> Build error log:
>> /root/kni/dpdk-19.05/kernel/linux/kni/ethtool/igb/kcompat.h:3928:25:
>> error: 'const struct net_device_ops' has no member named 'extended'
>>  #define ndo_set_vf_vlan extended.ndo_set_vf_vlan
>>                          ^~~~~~~~
> 
> This module has been removed from DPDK:
> 	http://git.dpdk.org/dpdk/commit/?id=ea6b39b5b84
> 
> Do we want to apply this patch directly in older releases (LTS)?

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

stable mail list already in the cc, but

Kevin, Yongsek,
This patch won't be in the master repo, is there anything needs to be done to
include the patch in LTS, or is this mail sufficient?

Thanks,
ferruh

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] kni: fix build on RHEL8
  2019-06-04 15:00   ` Ferruh Yigit
@ 2019-06-04 15:23     ` Kevin Traynor
  0 siblings, 0 replies; 4+ messages in thread
From: Kevin Traynor @ 2019-06-04 15:23 UTC (permalink / raw)
  To: Ferruh Yigit, Thomas Monjalon, Yongseok Koh; +Cc: stable, michael.luo, dev

On 04/06/2019 16:00, Ferruh Yigit wrote:
> On 5/29/2019 10:48 PM, Thomas Monjalon wrote:
>> 27/05/2019 06:02, michael.luo@intel.com:
>>> From: Luo Gaoliang <michael.luo@intel.com>
>>>
>>> Build error was seen on RHEL8 when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled.
>>>
>>> Build error log:
>>> /root/kni/dpdk-19.05/kernel/linux/kni/ethtool/igb/kcompat.h:3928:25:
>>> error: 'const struct net_device_ops' has no member named 'extended'
>>>  #define ndo_set_vf_vlan extended.ndo_set_vf_vlan
>>>                          ^~~~~~~~
>>
>> This module has been removed from DPDK:
>> 	http://git.dpdk.org/dpdk/commit/?id=ea6b39b5b84
>>
>> Do we want to apply this patch directly in older releases (LTS)?
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> stable mail list already in the cc, but
> 
> Kevin, Yongsek,
> This patch won't be in the master repo, is there anything needs to be done to
> include the patch in LTS, or is this mail sufficient?
> 

Hi Ferruh, this mail is enough, will note it.

thanks,
Kevin.

> Thanks,
> ferruh
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-06-04 15:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-27  4:02 [dpdk-dev] [PATCH] kni: fix build on RHEL8 michael.luo
2019-05-29 21:48 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-06-04 15:00   ` Ferruh Yigit
2019-06-04 15:23     ` Kevin Traynor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).