DPDK patches and discussions
 help / color / mirror / Atom feed
From: longtb5@viettel.com.vn
To: bruce.richardson@intel.com
Cc: dev@dpdk.org, Bao-Long Tran <longtb5@viettel.com.vn>, stable@dpdk.org
Subject: [dpdk-dev] [PATCH 1/2] examples/l3fwd-vf: remove old Rx/Tx configuration defines
Date: Mon,  3 Jun 2019 17:06:18 +0700 (ICT)	[thread overview]
Message-ID: <1559557107-115815-2-git-send-email-longtb5@viettel.com.vn> (raw)
In-Reply-To: <1559557107-115815-1-git-send-email-longtb5@viettel.com.vn>

The RX and TX Prefetch, Host, and Write-back threshold values are
defined but not used anywhere. They are leftovers from a previous
patch.

Fixes: 81f7ecd9 ("examples: use factorized default Rx/Tx configuration")
Cc: stable@dpdk.org

Signed-off-by: Bao-Long Tran <longtb5@viettel.com.vn>
---
 examples/l3fwd-vf/main.c | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/examples/l3fwd-vf/main.c b/examples/l3fwd-vf/main.c
index 0ef469c..5533031 100644
--- a/examples/l3fwd-vf/main.c
+++ b/examples/l3fwd-vf/main.c
@@ -74,25 +74,6 @@
 				nb_lcores*MEMPOOL_CACHE_SIZE),		\
 				(unsigned)8192)
 
-/*
- * RX and TX Prefetch, Host, and Write-back threshold values should be
- * carefully set for optimal performance. Consult the network
- * controller's datasheet and supporting DPDK documentation for guidance
- * on how these parameters should be set.
- */
-#define RX_PTHRESH 8 /**< Default values of RX prefetch threshold reg. */
-#define RX_HTHRESH 8 /**< Default values of RX host threshold reg. */
-#define RX_WTHRESH 4 /**< Default values of RX write-back threshold reg. */
-
-/*
- * These default values are optimized for use with the Intel(R) 82599 10 GbE
- * Controller and the DPDK ixgbe PMD. Consider using other values for other
- * network controllers and/or network drivers.
- */
-#define TX_PTHRESH 36 /**< Default values of TX prefetch threshold reg. */
-#define TX_HTHRESH 0  /**< Default values of TX host threshold reg. */
-#define TX_WTHRESH 0  /**< Default values of TX write-back threshold reg. */
-
 #define MAX_PKT_BURST 32
 #define BURST_TX_DRAIN_US 100 /* TX drain every ~100us */
 
-- 
2.7.4


  reply	other threads:[~2019-06-03 10:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-03 10:06 [dpdk-dev] [PATCH 0/2] clean up old Rx/Tx configuration leftovers longtb5
2019-06-03 10:06 ` longtb5 [this message]
2019-06-03 10:06 ` [dpdk-dev] [PATCH 2/2] doc: remove old Rx/Tx configuration info in l2fwd longtb5
2019-07-01 19:50 ` [dpdk-dev] [PATCH 0/2] clean up old Rx/Tx configuration leftovers Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1559557107-115815-2-git-send-email-longtb5@viettel.com.vn \
    --to=longtb5@viettel.com.vn \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).