From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 114F9A04FD; Mon, 23 May 2022 20:10:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 02D6141132; Mon, 23 May 2022 20:10:08 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2076.outbound.protection.outlook.com [40.107.102.76]) by mails.dpdk.org (Postfix) with ESMTP id E933F4067B for <dev@dpdk.org>; Mon, 23 May 2022 20:10:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TFFaDcVKlwVp/uAby5PreygyKko0uMNrAKVokQ3+PrPCL4TW8XA9t5J2LWGbqZ/w6KbPOIuYhgPSIQFDRNi7wz7PWAl5ZrGJz0RBUPNQoqNUUyIJL52NLrumyeDa6PLIwrgKodFIjwAbpdmdVpka9LsyHsV4r4AQ8E82X0m6qk3YiBRjMuxAinoiSutDxf7xNlzIQPX4VcTFzfTgIUdSAQXDgGyicWVWyg5U4CofleEuD/3xyAEeVeedULaNZJhbjgt9yDD8bY23cPMwCaNNVFNLlq62zKpGUaNOTZdI+sO8q5qEsua6EHYLZ932YtQKTH0W/lNnJZ5LLeYpXInFnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pbib3yS/KvgId+hoAA74fXLAgroe/3mVvIdh3wviQHk=; b=gu3/1UuA3jv7UTMT16FF9JrirkXET5yaf0EUMr4gQ7wWUKjv6dPKiKD8twBkvNOyzo4/P9HPQre7qXeWtpcNNCtvbroBUDVANdrTQMtqCjH10cbjRYPTf1QrWOVjwswgatrnNZJKAB+n1f3WCGz6gSkibuKMbQV8wTdcpJeH6TNpZjeAwd9TSNfpxEW0fVqfx4DTYWVjxSpAlVlfNVYxGUDgc3JNUS0b2a6+DkFcikez3l9NwABHUePsGO7Ctwj86SKeRYHHjaB0akMoOcd8ZD/OitaCfy28CxtnpstoqHP4UB1E+GeUYaq6oConuWuELM9f/qV3b+vUg4BOD50brg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 149.199.80.198) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=fail (p=quarantine sp=quarantine pct=100) action=quarantine header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pbib3yS/KvgId+hoAA74fXLAgroe/3mVvIdh3wviQHk=; b=NQstvWcIYJhJdID9tloFHLzOMoOA5RFgkycUsFxW4xINKD775X1v+3qyQ1AhDM5OZEn33AQd+01IlCOdWXTmu6zHw1TA+k3yOtECfEwAMvsjFC+b8810+Yb072XdaPxYAWc200+AqmgvvLlZ0rDsoh3kt6vu6M21Sr24VzQWjL4= Received: from BN9PR03CA0874.namprd03.prod.outlook.com (2603:10b6:408:13c::9) by BN7PR02MB4212.namprd02.prod.outlook.com (2603:10b6:406:f5::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Mon, 23 May 2022 18:10:04 +0000 Received: from BN1NAM02FT058.eop-nam02.prod.protection.outlook.com (2603:10b6:408:13c:cafe::2b) by BN9PR03CA0874.outlook.office365.com (2603:10b6:408:13c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15 via Frontend Transport; Mon, 23 May 2022 18:10:04 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 149.199.80.198) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=fail action=quarantine header.from=amd.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning amd.com discourages use of 149.199.80.198 as permitted sender) Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT058.mail.protection.outlook.com (10.13.2.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 18:10:04 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Mon, 23 May 2022 19:10:03 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Mon, 23 May 2022 19:10:03 +0100 Envelope-to: david.marchand@redhat.com, dev@dpdk.org, qi.z.zhang@intel.com, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru, xiaoyun.li@intel.com, aman.deep.singh@intel.com, yuying.zhang@intel.com Received: from [10.71.119.126] (port=50155) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from <ferruh.yigit@amd.com>) id 1ntCVH-000707-HQ; Mon, 23 May 2022 19:10:03 +0100 Message-ID: <1559598c-65ab-a697-5a69-4ce36e3af699@amd.com> Date: Mon, 23 May 2022 19:10:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 5/6] app/testpmd: drop ixgbe bypass commands Content-Language: en-US To: David Marchand <david.marchand@redhat.com>, <dev@dpdk.org>, Qi Z Zhang <qi.z.zhang@intel.com> CC: <thomas@monjalon.net>, <andrew.rybchenko@oktetlabs.ru>, Xiaoyun Li <xiaoyun.li@intel.com>, Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com> References: <20220513075718.18674-1-david.marchand@redhat.com> <20220523071031.1868862-1-david.marchand@redhat.com> <20220523071031.1868862-6-david.marchand@redhat.com> From: Ferruh Yigit <ferruh.yigit@amd.com> In-Reply-To: <20220523071031.1868862-6-david.marchand@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6203d5c4-ab93-404e-0318-08da3ce77669 X-MS-TrafficTypeDiagnostic: BN7PR02MB4212:EE_ X-Microsoft-Antispam-PRVS: <BN7PR02MB421207CE5DCE4AC0EA728D0987D49@BN7PR02MB4212.namprd02.prod.outlook.com> X-MS-Exchange-SenderADCheck: 2 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vqo01wY9vYCgCz1zHAWxIgQbSKK3zXPSOEOP+cfjuVqoKtWxw+DpIAUeJ8DkIQFNQm+GtB+OgEIkWk+C328QMBU4z9E4lsxGMLI+O0G1O7hNV0rqpiH/CU8bx5lbqC/mi6m/q96dYt8jouU9Ww24CZ0didAlOnSCxBCQ6VKifN3QCj9/MfSoHo1gbhWDmFMjixeeoyUHIfFwNdj6ptREL87mNnl/ChJO4FvVslDEYXx8Gg1ch85qOyRn6LwVZKktT+KUr6uQhBfeO6XM20JtaaX/MUJIGKod2B9RuNDAZKZ+S7/SfmAe15IVJ4Pu9fiy35Atu47+y9IMtPL5toTj6We5noB3vyOyR6NbCAjiSn9oiEvEInXbZLHdJIJ6Lny99twyNU8ws4vrUh/eErQq5kwYi9kgBnJ0FdG4bGsTAdh/QBxVsAw30BbYJfNLOylDhvsBzLioYQtjkyVIeCYnITKmlXvP3URjW21NisgLGl3xzskuEmFiR3GIHGC1SA7sJ4bnwD1NtT2eUfVpgxwwJDCvoDUE5lqMKxts6e0NFdjc+PAG2VyorO0bpfzkMbpyGLdNEUhfTtTxLPGo6fci2h6i/nKNGwSifW1R/103l8LNddVy+MLzZJn58ydAl4bXYtBRCJELoyprC6CkRSUf1Kr3VOwVa1f8ruYYHNQS1a5s3rU+HZ329Dswrvqp9xSYiuJPXBsnn6sEsafmBmNAQMkGtcqbhNWDt7SzrRwQPZqa8y+SJ2Si5pKiob/DL66Y X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(47076005)(4326008)(31696002)(86362001)(70206006)(70586007)(8676002)(4744005)(44832011)(5660300002)(26005)(508600001)(40460700003)(336012)(8936002)(9786002)(2616005)(2906002)(35950700001)(54906003)(36756003)(31686004)(7636003)(356005)(53546011)(110136005)(82310400005)(316002)(50156003)(43740500002)(2101003); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 18:10:04.6177 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6203d5c4-ab93-404e-0318-08da3ce77669 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT058.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR02MB4212 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 5/23/2022 8:10 AM, David Marchand wrote: > This code is dead from the moment we switched to meson, because > RTE_LIBRTE_IXGBE_BYPASS is never defined at build time. > There was no complaint about the loss of those commands, drop all > associated code and documentation. > > Signed-off-by: David Marchand<david.marchand@redhat.com> 'RTE_LIBRTE_IXGBE_BYPASS' is hardcoded in the 'drivers/net/ixgbe/meson.build'. And for testpmd, macro can be enabled by argument to meson, '-Dc_args=-RTE_LIBRTE_IXGBE_BYPASS'. If ixgbe bypass mode agreed to remove, we can remove it, but I think above build time flag justification is not sufficient to remove it.