From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: [dpdk-dev] [PATCH 03/11] net/e1000: fix Tx prepare to set positive rte_errno
Date: Wed, 5 Jun 2019 09:15:56 +0100 [thread overview]
Message-ID: <1559722565-25992-4-git-send-email-arybchenko@solarflare.com> (raw)
In-Reply-To: <1559722565-25992-1-git-send-email-arybchenko@solarflare.com>
Fixes: 2b76648872c9 ("net/e1000: add Tx preparation")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/e1000/em_rxtx.c | 6 +++---
drivers/net/e1000/igb_rxtx.c | 8 ++++----
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c
index 482d884..708f832 100644
--- a/drivers/net/e1000/em_rxtx.c
+++ b/drivers/net/e1000/em_rxtx.c
@@ -616,20 +616,20 @@ struct em_tx_queue {
m = tx_pkts[i];
if (m->ol_flags & E1000_TX_OFFLOAD_NOTSUP_MASK) {
- rte_errno = -ENOTSUP;
+ rte_errno = ENOTSUP;
return i;
}
#ifdef RTE_LIBRTE_ETHDEV_DEBUG
ret = rte_validate_tx_offload(m);
if (ret != 0) {
- rte_errno = ret;
+ rte_errno = -ret;
return i;
}
#endif
ret = rte_net_intel_cksum_prepare(m);
if (ret != 0) {
- rte_errno = ret;
+ rte_errno = -ret;
return i;
}
}
diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c
index 871b5f3..c5606de 100644
--- a/drivers/net/e1000/igb_rxtx.c
+++ b/drivers/net/e1000/igb_rxtx.c
@@ -632,25 +632,25 @@ struct igb_tx_queue {
if ((m->tso_segsz > IGB_TSO_MAX_MSS) ||
(m->l2_len + m->l3_len + m->l4_len >
IGB_TSO_MAX_HDRLEN)) {
- rte_errno = -EINVAL;
+ rte_errno = EINVAL;
return i;
}
if (m->ol_flags & IGB_TX_OFFLOAD_NOTSUP_MASK) {
- rte_errno = -ENOTSUP;
+ rte_errno = ENOTSUP;
return i;
}
#ifdef RTE_LIBRTE_ETHDEV_DEBUG
ret = rte_validate_tx_offload(m);
if (ret != 0) {
- rte_errno = ret;
+ rte_errno = -ret;
return i;
}
#endif
ret = rte_net_intel_cksum_prepare(m);
if (ret != 0) {
- rte_errno = ret;
+ rte_errno = -ret;
return i;
}
}
--
1.8.3.1
next prev parent reply other threads:[~2019-06-05 8:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 8:15 [dpdk-dev] [PATCH 00/11] ethdev: " Andrew Rybchenko
2019-06-05 8:15 ` [dpdk-dev] [PATCH 01/11] ethdev: fix Tx prepare documentation to use positive errno Andrew Rybchenko
2019-06-05 8:15 ` [dpdk-dev] [PATCH 02/11] net/atlantic: fix Tx prepare to set positive rte_errno Andrew Rybchenko
2019-06-05 8:15 ` Andrew Rybchenko [this message]
2019-06-05 8:15 ` [dpdk-dev] [PATCH 04/11] net/enic: " Andrew Rybchenko
2019-06-05 8:15 ` [dpdk-dev] [PATCH 05/11] net/fm10k: " Andrew Rybchenko
2019-06-10 2:05 ` Wang, Xiao W
2019-06-05 8:15 ` [dpdk-dev] [PATCH 06/11] net/i40e: " Andrew Rybchenko
2019-06-05 8:16 ` [dpdk-dev] [PATCH 07/11] net/iavf: " Andrew Rybchenko
2019-06-05 8:16 ` [dpdk-dev] [PATCH 08/11] net/ice: " Andrew Rybchenko
2019-06-05 8:16 ` [dpdk-dev] [PATCH 09/11] net/ixgbe: " Andrew Rybchenko
2019-06-05 8:16 ` [dpdk-dev] [PATCH 10/11] net/qede: " Andrew Rybchenko
2019-06-05 8:16 ` [dpdk-dev] [PATCH 11/11] net/vmxnet3: " Andrew Rybchenko
2019-06-05 22:45 ` Yong Wang
2019-06-11 14:44 ` [dpdk-dev] [PATCH 00/11] ethdev: " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559722565-25992-4-git-send-email-arybchenko@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).