From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Beilei Xing <beilei.xing@intel.com>, Qi Zhang <qi.z.zhang@intel.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: [dpdk-dev] [PATCH 06/11] net/i40e: fix Tx prepare to set positive rte_errno
Date: Wed, 5 Jun 2019 09:15:59 +0100 [thread overview]
Message-ID: <1559722565-25992-7-git-send-email-arybchenko@solarflare.com> (raw)
In-Reply-To: <1559722565-25992-1-git-send-email-arybchenko@solarflare.com>
Fixes: 3f33e643e5c6 ("net/i40e: add Tx preparation")
Fixes: bfeed0262b0c ("net/i40e: check illegal packets")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/i40e/i40e_rxtx.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 7618153..3787fa7 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -1446,7 +1446,7 @@
if (!(ol_flags & PKT_TX_TCP_SEG)) {
if (m->nb_segs > I40E_TX_MAX_MTU_SEG ||
m->pkt_len > I40E_FRAME_SIZE_MAX) {
- rte_errno = -EINVAL;
+ rte_errno = EINVAL;
return i;
}
} else if (m->nb_segs > I40E_TX_MAX_SEG ||
@@ -1456,31 +1456,31 @@
/* MSS outside the range (256B - 9674B) are considered
* malicious
*/
- rte_errno = -EINVAL;
+ rte_errno = EINVAL;
return i;
}
if (ol_flags & I40E_TX_OFFLOAD_NOTSUP_MASK) {
- rte_errno = -ENOTSUP;
+ rte_errno = ENOTSUP;
return i;
}
/* check the size of packet */
if (m->pkt_len < I40E_TX_MIN_PKT_LEN) {
- rte_errno = -EINVAL;
+ rte_errno = EINVAL;
return i;
}
#ifdef RTE_LIBRTE_ETHDEV_DEBUG
ret = rte_validate_tx_offload(m);
if (ret != 0) {
- rte_errno = ret;
+ rte_errno = -ret;
return i;
}
#endif
ret = rte_net_intel_cksum_prepare(m);
if (ret != 0) {
- rte_errno = ret;
+ rte_errno = -ret;
return i;
}
}
--
1.8.3.1
next prev parent reply other threads:[~2019-06-05 8:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 8:15 [dpdk-dev] [PATCH 00/11] ethdev: " Andrew Rybchenko
2019-06-05 8:15 ` [dpdk-dev] [PATCH 01/11] ethdev: fix Tx prepare documentation to use positive errno Andrew Rybchenko
2019-06-05 8:15 ` [dpdk-dev] [PATCH 02/11] net/atlantic: fix Tx prepare to set positive rte_errno Andrew Rybchenko
2019-06-05 8:15 ` [dpdk-dev] [PATCH 03/11] net/e1000: " Andrew Rybchenko
2019-06-05 8:15 ` [dpdk-dev] [PATCH 04/11] net/enic: " Andrew Rybchenko
2019-06-05 8:15 ` [dpdk-dev] [PATCH 05/11] net/fm10k: " Andrew Rybchenko
2019-06-10 2:05 ` Wang, Xiao W
2019-06-05 8:15 ` Andrew Rybchenko [this message]
2019-06-05 8:16 ` [dpdk-dev] [PATCH 07/11] net/iavf: " Andrew Rybchenko
2019-06-05 8:16 ` [dpdk-dev] [PATCH 08/11] net/ice: " Andrew Rybchenko
2019-06-05 8:16 ` [dpdk-dev] [PATCH 09/11] net/ixgbe: " Andrew Rybchenko
2019-06-05 8:16 ` [dpdk-dev] [PATCH 10/11] net/qede: " Andrew Rybchenko
2019-06-05 8:16 ` [dpdk-dev] [PATCH 11/11] net/vmxnet3: " Andrew Rybchenko
2019-06-05 22:45 ` Yong Wang
2019-06-11 14:44 ` [dpdk-dev] [PATCH 00/11] ethdev: " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559722565-25992-7-git-send-email-arybchenko@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).