From: Wei Zhao <wei.zhao1@intel.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, ferruh.yigit@intel.com,
bernard.iremonger@intel.com, Wei Zhao <wei.zhao1@intel.com>
Subject: [dpdk-dev] [PATCH v3] app/testpmd: remove port stop check for macsec
Date: Mon, 10 Jun 2019 14:07:03 +0800 [thread overview]
Message-ID: <1560146823-57155-1-git-send-email-wei.zhao1@intel.com> (raw)
In-Reply-To: <1557477677-54876-1-git-send-email-wei.zhao1@intel.com>
There is no need to do such a check when set macsec for ixgbe, and
reconfig_device_queueand is also useless. If we do not delete this
unnessary code, users have to stop port before enable or disable
macsec, then restart this port after make configuration. All these
process are useless. As this cmdline is a private API which is only
used by ixgbe NIC, so remove it.
Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
Cc: stable@dpdk.org
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Tested-by: Peng Yuan <yuan.peng@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
v2:
-update log info and delete code in disable function
v3:
-update typo in log
---
app/test-pmd/cmdline.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index d1e0d44..e7c4bee 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -14044,10 +14044,6 @@ cmd_set_macsec_offload_on_parsed(
if (port_id_is_invalid(port_id, ENABLED_WARN))
return;
- if (!port_is_stopped(port_id)) {
- printf("Please stop port %d first\n", port_id);
- return;
- }
rte_eth_dev_info_get(port_id, &dev_info);
if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) {
@@ -14062,7 +14058,6 @@ cmd_set_macsec_offload_on_parsed(
case 0:
ports[port_id].dev_conf.txmode.offloads |=
DEV_TX_OFFLOAD_MACSEC_INSERT;
- cmd_reconfig_device_queue(port_id, 1, 1);
break;
case -ENODEV:
printf("invalid port_id %d\n", port_id);
@@ -14138,10 +14133,6 @@ cmd_set_macsec_offload_off_parsed(
if (port_id_is_invalid(port_id, ENABLED_WARN))
return;
- if (!port_is_stopped(port_id)) {
- printf("Please stop port %d first\n", port_id);
- return;
- }
rte_eth_dev_info_get(port_id, &dev_info);
if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) {
@@ -14153,7 +14144,6 @@ cmd_set_macsec_offload_off_parsed(
case 0:
ports[port_id].dev_conf.txmode.offloads &=
~DEV_TX_OFFLOAD_MACSEC_INSERT;
- cmd_reconfig_device_queue(port_id, 1, 1);
break;
case -ENODEV:
printf("invalid port_id %d\n", port_id);
--
2.7.5
next prev parent reply other threads:[~2019-06-10 6:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 7:20 [dpdk-dev] [PATCH] " Wei Zhao
2019-05-09 7:20 ` Wei Zhao
2019-05-10 8:41 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2019-05-10 8:41 ` Wei Zhao
2019-05-13 3:30 ` Zhao1, Wei
2019-05-13 3:30 ` Zhao1, Wei
2019-06-07 13:59 ` Iremonger, Bernard
2019-06-10 6:40 ` Zhao1, Wei
2019-06-10 6:07 ` Wei Zhao [this message]
2019-06-27 17:23 ` [dpdk-dev] [dpdk-stable] [PATCH v3] " Ferruh Yigit
2019-06-30 21:50 ` Thomas Monjalon
2019-07-01 16:39 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1560146823-57155-1-git-send-email-wei.zhao1@intel.com \
--to=wei.zhao1@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).