From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1311AA05DC for ; Mon, 10 Jun 2019 08:36:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6DC1A1BE4D; Mon, 10 Jun 2019 08:36:44 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 2A5511BE42; Mon, 10 Jun 2019 08:36:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jun 2019 23:36:42 -0700 X-ExtLoop1: 1 Received: from dpdk6.bj.intel.com ([172.16.182.192]) by orsmga001.jf.intel.com with ESMTP; 09 Jun 2019 23:36:40 -0700 From: Wei Zhao To: dev@dpdk.org Cc: stable@dpdk.org, ferruh.yigit@intel.com, bernard.iremonger@intel.com, Wei Zhao Date: Mon, 10 Jun 2019 14:07:03 +0800 Message-Id: <1560146823-57155-1-git-send-email-wei.zhao1@intel.com> X-Mailer: git-send-email 2.7.5 In-Reply-To: <1557477677-54876-1-git-send-email-wei.zhao1@intel.com> References: <1557477677-54876-1-git-send-email-wei.zhao1@intel.com> Subject: [dpdk-dev] [PATCH v3] app/testpmd: remove port stop check for macsec X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There is no need to do such a check when set macsec for ixgbe, and reconfig_device_queueand is also useless. If we do not delete this unnessary code, users have to stop port before enable or disable macsec, then restart this port after make configuration. All these process are useless. As this cmdline is a private API which is only used by ixgbe NIC, so remove it. Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API") Cc: stable@dpdk.org Signed-off-by: Wei Zhao Tested-by: Peng Yuan Acked-by: Bernard Iremonger --- v2: -update log info and delete code in disable function v3: -update typo in log --- app/test-pmd/cmdline.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index d1e0d44..e7c4bee 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -14044,10 +14044,6 @@ cmd_set_macsec_offload_on_parsed( if (port_id_is_invalid(port_id, ENABLED_WARN)) return; - if (!port_is_stopped(port_id)) { - printf("Please stop port %d first\n", port_id); - return; - } rte_eth_dev_info_get(port_id, &dev_info); if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) { @@ -14062,7 +14058,6 @@ cmd_set_macsec_offload_on_parsed( case 0: ports[port_id].dev_conf.txmode.offloads |= DEV_TX_OFFLOAD_MACSEC_INSERT; - cmd_reconfig_device_queue(port_id, 1, 1); break; case -ENODEV: printf("invalid port_id %d\n", port_id); @@ -14138,10 +14133,6 @@ cmd_set_macsec_offload_off_parsed( if (port_id_is_invalid(port_id, ENABLED_WARN)) return; - if (!port_is_stopped(port_id)) { - printf("Please stop port %d first\n", port_id); - return; - } rte_eth_dev_info_get(port_id, &dev_info); if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) { @@ -14153,7 +14144,6 @@ cmd_set_macsec_offload_off_parsed( case 0: ports[port_id].dev_conf.txmode.offloads &= ~DEV_TX_OFFLOAD_MACSEC_INSERT; - cmd_reconfig_device_queue(port_id, 1, 1); break; case -ENODEV: printf("invalid port_id %d\n", port_id); -- 2.7.5