From: Lavanya Govindarajan <lavanyax.govindarajan@intel.com>
To: dev@dpdk.org
Cc: reshma.pattan@intel.com, jingjing.wu@intel.com,
wenzhuo.lu@intel.com, jananeex.m.parthasarathy@intel.com,
Lavanya Govindarajan <lavanyax.govindarajan@intel.com>
Subject: [dpdk-dev] [PATCH] net/iavf: move debug dump desc flag to config file
Date: Mon, 10 Jun 2019 14:07:38 +0100 [thread overview]
Message-ID: <1560172058-10742-1-git-send-email-lavanyax.govindarajan@intel.com> (raw)
DEBUG_DUMP_DESC flag is commented out in IAVF Makefile and to enable
it user needs to edit the Makefile. It is felt that this method is not
good. Hence removing this flag from IAVF makefile and adding a flag
CONFIG_RTE_LIBRTE_IAVF_DEBUG_DUMP_DESC to config/common_base.
Signed-off-by: Lavanya Govindarajan <lavanyax.govindarajan@intel.com>
---
config/common_base | 1 +
drivers/net/iavf/Makefile | 3 ---
drivers/net/iavf/iavf_rxtx.h | 2 +-
3 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/config/common_base b/config/common_base
index 6b96e0e80..86cd27bb2 100644
--- a/config/common_base
+++ b/config/common_base
@@ -327,6 +327,7 @@ CONFIG_RTE_LIBRTE_IAVF_INC_VECTOR=y
CONFIG_RTE_LIBRTE_IAVF_DEBUG_TX=n
CONFIG_RTE_LIBRTE_IAVF_DEBUG_TX_FREE=n
CONFIG_RTE_LIBRTE_IAVF_DEBUG_RX=n
+CONFIG_RTE_LIBRTE_IAVF_DEBUG_DUMP_DESC=n
CONFIG_RTE_LIBRTE_IAVF_16BYTE_RX_DESC=n
#
# Compile burst-oriented IPN3KE PMD driver
diff --git a/drivers/net/iavf/Makefile b/drivers/net/iavf/Makefile
index 3a0eb79ca..cd74e14ab 100644
--- a/drivers/net/iavf/Makefile
+++ b/drivers/net/iavf/Makefile
@@ -13,9 +13,6 @@ LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_hash
LDLIBS += -lrte_bus_pci
-# used to dump HW descriptor for debugging
-# CFLAGS += -DDEBUG_DUMP_DESC
-
EXPORT_MAP := rte_pmd_iavf_version.map
LIBABIVER := 1
diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h
index e821dcae6..c86720bda 100644
--- a/drivers/net/iavf/iavf_rxtx.h
+++ b/drivers/net/iavf/iavf_rxtx.h
@@ -255,7 +255,7 @@ void iavf_dump_tx_descriptor(const struct iavf_tx_queue *txq,
tx_desc->cmd_type_offset_bsz);
}
-#ifdef DEBUG_DUMP_DESC
+#ifdef RTE_LIBRTE_IAVF_DEBUG_DUMP_DESC
#define IAVF_DUMP_RX_DESC(rxq, desc, rx_id) \
iavf_dump_rx_descriptor(rxq, desc, rx_id)
#define IAVF_DUMP_TX_DESC(txq, desc, tx_id) \
--
2.17.2
next reply other threads:[~2019-06-10 13:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 13:07 Lavanya Govindarajan [this message]
2019-06-18 14:22 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1560172058-10742-1-git-send-email-lavanyax.govindarajan@intel.com \
--to=lavanyax.govindarajan@intel.com \
--cc=dev@dpdk.org \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=jingjing.wu@intel.com \
--cc=reshma.pattan@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).