From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 6EA5E11D4
 for <dev@dpdk.org>; Tue, 22 May 2018 22:33:28 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id F21FA21ADF;
 Tue, 22 May 2018 16:33:27 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Tue, 22 May 2018 16:33:27 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=gTbK1oUxd9H0TiyBWtMG3hIzTU
 DCGCEDuo4SDaF13mA=; b=ie4TLRZJLXGJYgUsdS+f9uNB6bk7g7JyrPYNpI2LSB
 wzXTywACtnGdIHFt3ayVzTHBSpxMXhlPBtQ58wKa4V/F5IIA5h8JC9g0MA75JIbo
 ubwwBgSLN4MAuiwubJvvlawx3jcJoCVByp4O3XReLtBEqFE0N6OxUIUWn9+nOIyS
 s=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=gTbK1o
 Uxd9H0TiyBWtMG3hIzTUDCGCEDuo4SDaF13mA=; b=ZgrVcaOy7BFmp8lxiiUXQ3
 c4ZI8wuxc+OeLzL7MZsrajXBg09yuXopW08shAWumIIB/jXboG9M7CrMtPs2fMRS
 1tCgK4ReRxT4ITfw8g/3/8g/OH82hnzwl48l3NS7giCDsVVMa9Lo5IKc5Gq9u4fz
 Dtcvs4MTcIOu1pxwifZL+IGPDNv96rUDgAO8ZOH+I9vy1NfDO3x8CA07LeLCF1Gf
 TjuePgo7WsMEBT+RKFdVCbB9NYmkFTwlQPVRg2epfvIsqmDTGx88FFzFpJtfjLt9
 4lqIFxDrAvFtuketBgN68CqjWbitiLMwhL20zLnd9EW11DFZrrGt5hejT0lnrN2A
 ==
X-ME-Proxy: <xmx:l34EWyoSWISngvJVtORU7GI1rhZ193TRQmNfcPFuJpDQF26ENvt4Lg>
X-ME-Proxy: <xmx:l34EW4FbrdcQndx5Uy9jAAXLrMnLMJa6Y0PJMO2SPSK3od9-VaU4jQ>
X-ME-Proxy: <xmx:l34EWwLouB_4Ua4-mg1_Qx1DAFHhvrcHtSCXk26Ah3rixTB33yG7RQ>
X-ME-Proxy: <xmx:l34EW80P-KyI869uT6rECNBJmos7wrZV38OrKWI1vUeI10yjeYxCxQ>
X-ME-Proxy: <xmx:l34EWxJbJ9rnxRLV5p2Z6hS51QHaE5V9hFR8COZ37nrYagWRm4mNqg>
X-ME-Proxy: <xmx:l34EW7KV9Q9xH5JOqhJMksFEbp7hu4JBVwU6T3jHg_2qQOGW1grj_Q>
X-ME-Sender: <xms:l34EW26F8ybcW3JRsjlq20x4gIUTIgKUgqHTC5k5B3x7nCl7grQdbA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 61718E464B;
 Tue, 22 May 2018 16:33:27 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Changpeng Liu <changpeng.liu@intel.com>
Cc: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>
Date: Tue, 22 May 2018 22:33:26 +0200
Message-ID: <1560362.DyZTV1XtT0@xps>
In-Reply-To: <12946126.f8e536ouzB@xps>
References: <1526599932-13083-1-git-send-email-changpeng.liu@intel.com>
 <30363841-11bc-3d43-08c2-7ccd07296a6c@redhat.com> <12946126.f8e536ouzB@xps>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 1/2] examples/vhost_scsi: add virtio-1.0
	feature bit support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 22 May 2018 20:33:28 -0000

22/05/2018 19:51, Thomas Monjalon:
> 18/05/2018 14:35, Maxime Coquelin:
> > 
> > On 05/18/2018 01:32 AM, Changpeng Liu wrote:
> > > Signed-off-by: Changpeng Liu <changpeng.liu@intel.com>
> > > ---
> > >   examples/vhost_scsi/vhost_scsi.c | 7 ++++---
> > >   1 file changed, 4 insertions(+), 3 deletions(-)
> > 
> > Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> Patch 1 applied alone, thanks

After compilation tests, the patch is not accepted in 18.05,
because VIRTIO_F_VERSION_1 seems not defined on some distributions,
despite the fallback implemented.