From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, ferruh.yigit@intel.com,
Rastislav Cernay <cernay@netcope.com>,
Jan Remes <remes@netcope.com>
Subject: [dpdk-dev] [PATCH 1/3] net/nfb: avoid memory leak on unplug
Date: Mon, 17 Jun 2019 17:05:22 +0200 [thread overview]
Message-ID: <1560783924-5355-2-git-send-email-david.marchand@redhat.com> (raw)
In-Reply-To: <1560783924-5355-1-git-send-email-david.marchand@redhat.com>
Clearing mac_addrs on remove will prevent ethdev from freeing it.
Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/nfb/nfb_ethdev.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net/nfb/nfb_ethdev.c
index fdd0e70..6f77864 100644
--- a/drivers/net/nfb/nfb_ethdev.c
+++ b/drivers/net/nfb/nfb_ethdev.c
@@ -510,8 +510,6 @@
struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
struct rte_pci_addr *pci_addr = &pci_dev->addr;
- dev->data->mac_addrs = NULL;
-
nfb_nc_rxmac_deinit(internals->rxmac, internals->max_rxmac);
nfb_nc_txmac_deinit(internals->txmac, internals->max_txmac);
--
1.8.3.1
next prev parent reply other threads:[~2019-06-17 15:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 15:05 [dpdk-dev] [PATCH 0/3] ethdev mac_addrs cleanups David Marchand
2019-06-17 15:05 ` David Marchand [this message]
2019-06-26 17:21 ` [dpdk-dev] [PATCH 1/3] net/nfb: avoid memory leak on unplug Ferruh Yigit
2019-06-17 15:05 ` [dpdk-dev] [PATCH 2/3] net/bnx2x: fix invalid free " David Marchand
2019-06-26 17:21 ` Ferruh Yigit
2019-06-17 15:05 ` [dpdk-dev] [PATCH 3/3] drivers/net: fix double free on init failure cleanup David Marchand
2019-06-26 17:21 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1560783924-5355-2-git-send-email-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=cernay@netcope.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=remes@netcope.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).