From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id D33A61150 for ; Wed, 16 Jan 2019 09:41:23 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6564E25BEC; Wed, 16 Jan 2019 03:41:23 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 16 Jan 2019 03:41:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=DfNEY22Lps6Oek0Ll86O67Qu9YHnR7hbvFlSIqkAHzg=; b=gjn3Oc6DNNgd LFyWEJSrGqYF9Bs5kzfcmR9cMoOtXymvDa53rhArf5cRMZNbmPpk5MB9z+3NcQ6M 1vpnd5Wxg0b96fH/CIydXzYu3hnNrS1iKlazcDlJCYxiKqMYUAHalzJLvAljZE9s 0xe5BP0f/jYq61DtOi4R3zJUqUrXl+I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=DfNEY22Lps6Oek0Ll86O67Qu9YHnR7hbvFlSIqkAH zg=; b=Cqt+SAOCr2TAgZHPf11P2BbK+uW20ddWXAt8q6mQE78a3yG6zrutgDGMK ZDOtJ91CYyLn24ePEg7zWXvGcLvHRt7ToXBeHV9EIb1nyjfctJKal3f7e42MhMAZ tEBmsmE9Qyxi5XLvX7KAaHA3c+oT7FtyUQLAjhJ4jTMfPfnkHjTkC6U5FPEWx4LT RtprUZLVZYnbA4/dusXOQ+t61TlTX+yVCd+CJQP7adLlTyXoasMrJcuz1ef9En4q TUb2XrhJj0hRSQGS93hEUvU5qLUZDcNuuJ5Xw2RWBEWTNCN4spXaxQGGLY21Ms5X copP9bz/0HdCwhpLMSRiDutslHtuQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgeeggdehjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfe drudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 19AF1E4043; Wed, 16 Jan 2019 03:41:21 -0500 (EST) From: Thomas Monjalon To: dev@dpdk.org Cc: Stephen Hemminger , Reshma Pattan , jerin.jacob@caviumnetworks.com, nikhil.rao@intel.com, olivier.matz@6wind.com, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, konstantin.ananyev@intel.com Date: Wed, 16 Jan 2019 09:41:20 +0100 Message-ID: <1561068.4x49Scgd5h@xps> In-Reply-To: <20190115151151.5105b80e@shemminger-XPS-13-9360> References: <20181219154237.836-1-reshma.pattan@intel.com> <20181220121609.16314-2-reshma.pattan@intel.com> <20190115151151.5105b80e@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 2/2] mbuf: implement generic format for sched field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2019 08:41:24 -0000 16/01/2019 00:11, Stephen Hemminger: > On Thu, 20 Dec 2018 12:16:09 +0000 > Reshma Pattan wrote: > > > void > > -rte_sched_port_pkt_write(struct rte_mbuf *pkt, > > - uint32_t subport, uint32_t pipe, uint32_t traffic_class, > > +rte_sched_port_pkt_write(struct rte_sched_port *port, > > + struct rte_mbuf *pkt, > > + uint32_t subport, uint32_t pipe, > > + uint32_t traffic_class, > > uint32_t queue, enum rte_meter_color color) > > Sorry I didn't notice this earlier, but changing the function signature like > this is a complete ABI breakage. Old code will be passing different arguments than > new code; therefore this change breaks both source and binary compatibility. > > Is 19.02 supposed to be an ABI/API breaking release? Or only an incremental update. It is an API breaking release.