From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id AE933A0471 for ; Fri, 21 Jun 2019 11:41:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EEDD11D5C4; Fri, 21 Jun 2019 11:41:08 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 7AD801D5A3; Fri, 21 Jun 2019 11:41:02 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 5BDEB40051; Fri, 21 Jun 2019 09:41:01 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 21 Jun 2019 02:40:58 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Fri, 21 Jun 2019 02:40:58 -0700 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id x5L9euEb017265; Fri, 21 Jun 2019 10:40:56 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id AF040161621; Fri, 21 Jun 2019 10:40:56 +0100 (BST) From: Andrew Rybchenko To: CC: , Thomas Monjalon , Ferruh Yigit Date: Fri, 21 Jun 2019 10:40:39 +0100 Message-ID: <1561110041-1795-1-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24700.003 X-TM-AS-Result: No-1.659300-4.000000-10 X-TMASE-MatchedRID: rQrECMFmvg+KhA2hG2DTq/3HILfxLV/9wuIWIvQEbW5UjspoiX02F5v8 OBKGKGJrJwlz28CLxpfYVN9VJmcBIBerdMN/koGdPwKTD1v8YV5UENBIMyKD0WW+OakXo9jto8W MkQWv6iXBcIE78YqRWo6HM5rqDwqtsUtw9oIR2wITgLJ4M/0A5FsXtN/5qda5ZPibUDinVTXGFl yvPtUzrN4ioMX0GxCybpflMJR8H5TrEcT2yUfe3aJFXTWCD/BPhdeYev6ImzWyrFieOBrhBjzcW rt/fwYrRcB2ZpPnVjJuI9MGG9suFpRMZUCEHkRt X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--1.659300-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24700.003 X-MDID: 1561110062-Ahet6YbNwabS Subject: [dpdk-dev] [PATCH 1/3] ethdev: avoid error on PCI unplug of already closed ethdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If PCI Ethernet device driver removes it on close (RTE_ETH_DEV_CLOSE_REMOVE) and later PCI device itself is unplugged, it should not fail because of Ethernet device is already removed. Fixes: 23ea57a2a0ce ("ethdev: complete closing of port") Cc: stable@dpdk.org Signed-off-by: Andrew Rybchenko Reviewed-by: Ivan Malov --- Cc: Thomas Monjalon Cc: Ferruh Yigit lib/librte_ethdev/rte_ethdev_pci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethdev_pci.h b/lib/librte_ethdev/rte_ethdev_pci.h index 23257e986..ccdbb46ec 100644 --- a/lib/librte_ethdev/rte_ethdev_pci.h +++ b/lib/librte_ethdev/rte_ethdev_pci.h @@ -184,7 +184,7 @@ rte_eth_dev_pci_generic_remove(struct rte_pci_device *pci_dev, eth_dev = rte_eth_dev_allocated(pci_dev->device.name); if (!eth_dev) - return -ENODEV; + return 0; if (dev_uninit) { ret = dev_uninit(eth_dev); -- 2.17.1