Re: [dpdk-dev] [PATCH v2 03/11] devices-args: use rte_devargs and remove old whitelist code

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2014-03-01 13:14, Olivier Matz:
> Remove old whitelist code:
> - remove references to rte_pmd_ring, rte_pmd_pcap and pmd_xenvirt in
>   is_valid_wl_entry() as we want to be able to register external virtual
>   drivers as a shared library. Moreover this code was duplicated with
>   dev_types[] from eal_common_pci.c
> - eal_common_whitelist.c was badly named: it was able to process PCI
>   devices white list and the registration of virtual devices
> - the parsing code was complex: all arguments were prepended in
>   one string dev_list_str[4096], then split again
> 
> Use the newly introduced rte_devargs to get:
> - the PCI white list
> - the PCI black list
> - the list of virtual devices
> 
> Rework the tests:
> - a part of the whitelist test can be removed as it is now tested
>   in app/test/test_devargs.c
> - the other parts are just reworked to adapt them to the new API
> 
> This commit induce a small API modification: it is not possible to specify
> several devices per "--use-device" option. This notation was anyway a bit
> cryptic. Ex:
>   --use-device="eth_ring0,eth_pcap0;iface=ixgbe0"
>   now becomes:
>   --use-device="eth_ring0" --use-device="eth_pcap0;iface=ixgbe0"
> 
> On the other hand, it is now possible to work in PCI blacklist mode and
> instanciate virtual drivers, which was not possible before this patch.
> 
> Test result:
> 
> ./app/test -c 0x15 -n 3 -m 64
> RTE>>devargs_autotest
> EAL: invalid PCI identifier <08:1>
> EAL: invalid PCI identifier <00.1>
> EAL: invalid PCI identifier <foo>
> EAL: invalid PCI identifier <>
> EAL: invalid PCI identifier <000f:0:0>
> Test OK
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied for version 1.6.0r2 with title
	"devargs: use devargs for vdev and PCI whitelist/blacklist"

-- 
Thomas