From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f171.google.com (mail-we0-f171.google.com [74.125.82.171]) by dpdk.org (Postfix) with ESMTP id 99AFE68CF for ; Thu, 10 Apr 2014 15:59:42 +0200 (CEST) Received: by mail-we0-f171.google.com with SMTP id t61so4000573wes.16 for ; Thu, 10 Apr 2014 07:01:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=DiuBUAIg5JRg28xomiM19JSlUKLyW2t4t82uRIwUGAU=; b=FETw1QOy6dh4v21T9kvChN/ENqvmRIdYwL/pSWZrB3q0OAbBR/lHWHjvyXF+MJujO3 09h8XWwVbY6zFS2k0q3CoXOw+sQRHqZLWMLvv2cLwJgzMBv901VHJfzHJV8Cr3p3itLR 3j8HZm0l+zGRS6VbIZqrtmuTJ36Gprfz9VdRFlhHKqn1DARGNbpND7zpX5JynbStuoEk /K4bHz3yAR8UqaaKVowVKJIqGdz+94RAY63bgEU1J6DbW4jrTYKmUcHqxBFTad3PJ2j3 9R5/tAsbof9H03qO2llqMP6toupIj01BmobbS9TW1pQa3BdY0VBLXt8SCMMmQuOQQzOh ewzA== X-Gm-Message-State: ALoCoQmMSA7BJw1YsH+RwsurmYKvkpTFusMqWWHHF222TWcIoxQLxF5OTptBSUE7/Wf2TKgfp4h6 X-Received: by 10.194.77.50 with SMTP id p18mr2040923wjw.68.1397138479705; Thu, 10 Apr 2014 07:01:19 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id v6sm11254995wif.0.2014.04.10.07.01.18 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Apr 2014 07:01:19 -0700 (PDT) From: Thomas Monjalon To: Olivier Matz Date: Thu, 10 Apr 2014 16:01:18 +0200 Message-ID: <1561762.9pOC2yjSyh@xps13> Organization: 6WIND User-Agent: KMail/4.12.3 (Linux/3.13.7-1-ARCH; KDE/4.12.3; x86_64; ; ) In-Reply-To: <1393676074-17703-1-git-send-email-olivier.matz@6wind.com> References: <1393608350-4431-4-git-send-email-olivier.matz@6wind.com> <1393676074-17703-1-git-send-email-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 03/11] devices-args: use rte_devargs and remove old whitelist code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Apr 2014 13:59:42 -0000 2014-03-01 13:14, Olivier Matz: > Remove old whitelist code: > - remove references to rte_pmd_ring, rte_pmd_pcap and pmd_xenvirt in > is_valid_wl_entry() as we want to be able to register external virtual > drivers as a shared library. Moreover this code was duplicated with > dev_types[] from eal_common_pci.c > - eal_common_whitelist.c was badly named: it was able to process PCI > devices white list and the registration of virtual devices > - the parsing code was complex: all arguments were prepended in > one string dev_list_str[4096], then split again > > Use the newly introduced rte_devargs to get: > - the PCI white list > - the PCI black list > - the list of virtual devices > > Rework the tests: > - a part of the whitelist test can be removed as it is now tested > in app/test/test_devargs.c > - the other parts are just reworked to adapt them to the new API > > This commit induce a small API modification: it is not possible to specify > several devices per "--use-device" option. This notation was anyway a bit > cryptic. Ex: > --use-device="eth_ring0,eth_pcap0;iface=ixgbe0" > now becomes: > --use-device="eth_ring0" --use-device="eth_pcap0;iface=ixgbe0" > > On the other hand, it is now possible to work in PCI blacklist mode and > instanciate virtual drivers, which was not possible before this patch. > > Test result: > > ./app/test -c 0x15 -n 3 -m 64 > RTE>>devargs_autotest > EAL: invalid PCI identifier <08:1> > EAL: invalid PCI identifier <00.1> > EAL: invalid PCI identifier > EAL: invalid PCI identifier <> > EAL: invalid PCI identifier <000f:0:0> > Test OK > > Signed-off-by: Olivier Matz Acked-by: Thomas Monjalon Applied for version 1.6.0r2 with title "devargs: use devargs for vdev and PCI whitelist/blacklist" -- Thomas