From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ouyang Changchun <changchun.ouyang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf rss
Date: Tue, 27 Jan 2015 13:12:39 +0100 [thread overview]
Message-ID: <1561845.4QtzaTeLCI@xps13> (raw)
In-Reply-To: <1421811523-18737-1-git-send-email-changchun.ouyang@intel.com>
> To follow up the comments from Wodkowski, PawelX, remove this unnecessary check,
> as check_mq_mode has already check the queue number in device configure stage,
> if the queue number of vf is not correct, it will return error code and exit,
> so it doesn't need check again here in device start stage(note: pf_host_configure
> is called in device start stage).
>
> This fixes commit 42d2f78abcb77ecb769be4149df550308169ef0f
>
> Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
Suggested-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
Fixes: 42d2f78abcb77 ("configure VF RSS")
Applied
Changchun, as you are working on ixgbe, maybe you would like to review
some ixgbe patches from others?
Thanks
--
Thomas
next prev parent reply other threads:[~2015-01-27 12:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 3:38 Ouyang Changchun
2015-01-27 12:12 ` Thomas Monjalon [this message]
2015-01-28 1:35 ` Ouyang, Changchun
2015-01-29 16:13 ` Wodkowski, PawelX
2015-01-30 1:20 ` Ouyang, Changchun
2015-01-30 10:16 ` Wodkowski, PawelX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1561845.4QtzaTeLCI@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=changchun.ouyang@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).