From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) by dpdk.org (Postfix) with ESMTP id BB1645F76 for ; Tue, 27 Jan 2015 13:13:06 +0100 (CET) Received: by mail-we0-f181.google.com with SMTP id k48so14541321wev.12 for ; Tue, 27 Jan 2015 04:13:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=F9oKnlOo++Y5ylcyOYFa3ZmQWCdarK/pL0EzTmJ+a5o=; b=kOHdd+8nX6bh238yZ6cDp9UtgXECeMjqdrSZzWB/w2iW9dBnYuVokJHkg+jyOrWvfm IDqIFarag4/oprw81yOWZ2BivQRy3Ggiwe3naQJ2SW2AQxrWZZS0UFaHQmeEeiX2Xi/1 rpHvqttCPxpSwKMJUe5IRBa/FdoMhtgbgOeCH7AmJT6Y26l7EV4QpgJf14F5iypt9zuG jU4DcvtiOjnUrzIW/9qiU+z71+0FyjcwNEfGB/MCsrouykMuSyc4GoH/dumehk8b2i++ vDvd/Kk1FRmkIHmpRZ3uOb7pTymFKchQ0Dlmlgxpz0IR6gont40lWYkcKphAcodIw/Wq Rbig== X-Gm-Message-State: ALoCoQmR7lEnptjumls5ccWrHpK9uElKMXpgJxBoJF9goORga5GLivwUv2knI2kEhKd7dhCupr/1 X-Received: by 10.194.189.77 with SMTP id gg13mr1937184wjc.81.1422360786385; Tue, 27 Jan 2015 04:13:06 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id da2sm1581471wjb.21.2015.01.27.04.13.04 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Jan 2015 04:13:05 -0800 (PST) From: Thomas Monjalon To: Ouyang Changchun Date: Tue, 27 Jan 2015 13:12:39 +0100 Message-ID: <1561845.4QtzaTeLCI@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.18.2-2-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1421811523-18737-1-git-send-email-changchun.ouyang@intel.com> References: <1421811523-18737-1-git-send-email-changchun.ouyang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf rss X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2015 12:13:07 -0000 > To follow up the comments from Wodkowski, PawelX, remove this unnecessary check, > as check_mq_mode has already check the queue number in device configure stage, > if the queue number of vf is not correct, it will return error code and exit, > so it doesn't need check again here in device start stage(note: pf_host_configure > is called in device start stage). > > This fixes commit 42d2f78abcb77ecb769be4149df550308169ef0f > > Signed-off-by: Changchun Ouyang Suggested-by: Pawel Wodkowski Fixes: 42d2f78abcb77 ("configure VF RSS") Applied Changchun, as you are working on ixgbe, maybe you would like to review some ixgbe patches from others? Thanks -- Thomas