From: "Raz Amir" <razamir22@gmail.com>
To: "'Thomas Monjalon'" <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] Crash related to virtio NICs in DPDK 2.0.0 on Freebsd 10.1 VM
Date: Mon, 13 Apr 2015 14:54:08 +0300 [thread overview]
Message-ID: <156201d075e0$8d5e8390$a81b8ab0$@gmail.com> (raw)
In-Reply-To: <19871442.I62j3xGbVC@xps13>
Thanks. I will submit a patch
-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
Sent: 13 April 2015 13:46
To: Raz Amir
Cc: dev@dpdk.org; david.marchand@6wind.com
Subject: Re: Crash related to virtio NICs in DPDK 2.0.0 on Freebsd 10.1 VM
2015-04-08 18:53, Raz Amir:
> The issues happens also in dpdk 1.8.0, and related to patch
> http://dpdk.org/dev/patchwork/patch/239/
>
> Adding Thomas and David to the thread and I will appreciate your input.
>
> The patch comes to solve a file descriptor leak in the bsdapp version
> of rte_eal_iopl_init after opening the /dev/io device.
>
> Seems like this isn't a file descriptor leak, and it should remain
> open - as I wrote below, I am using virtio.
Thanks for the bug report.
It seems there was no validation for FreeBSD with virtio.
> After removing it and testing the crash was resolved.
>
> Any objection for removing the close(fd) that was added at dpdk 1.8.0?
No, there was a doubt because the man page was not clear.
http://www.freebsd.org/cgi/man.cgi?query=io&sektion=4
In case you submit a patch, please add this line:
Fixes: 8a312224bcde ("eal/bsd: fix fd leak")
> Are there scenarios that might be impacted by removing it?
I don't think so.
Thanks
next prev parent reply other threads:[~2015-04-13 11:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 15:41 Raz Amir
2015-04-08 15:53 ` Raz Amir
2015-04-13 7:56 ` Raz Amir
2015-04-13 10:46 ` Thomas Monjalon
2015-04-13 11:54 ` Raz Amir [this message]
2015-04-14 2:25 ` Ouyang, Changchun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='156201d075e0$8d5e8390$a81b8ab0$@gmail.com' \
--to=razamir22@gmail.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).