From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 28612C3B0 for ; Mon, 13 Apr 2015 13:54:14 +0200 (CEST) Received: by widdi4 with SMTP id di4so48467925wid.0 for ; Mon, 13 Apr 2015 04:54:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-type:content-transfer-encoding:thread-index :content-language; bh=wpzwidXbtYDIi3vuRdu915mH3QXJTItfvqHa+6JAevM=; b=sWWXkPobDDp8E93I4vEpJVZo9IGrKl9KmGqu5ulVhAYW93WqLnQmJn15UOHzc8fV0p Q2PKyczJil1wBw3EWeLjCcTTmJYwkTQCumcbEwFNhzBAJoxJKv0eZyanJWNEBV2Y0H5t ZDUcmh5UwVrHoq80Qf9OWdDyz20Inyc2N4U0RwDtu+BVV9uNFCGQ1NU8zLFi6XPby+Fl U2/RH0CQ0aPnUZhToqNd0Y4sGYMChRYxcPt0nLTI0RWG1oYJaSejHW8t+RMHwOETjZn7 XDfztlgxkV1LwZDootok6IwVlBarPR/2XkZ7Oza/exiFJb6lOymb9ke/07KWiEV7P1Ka qpkg== X-Received: by 10.194.159.105 with SMTP id xb9mr27425328wjb.156.1428926053978; Mon, 13 Apr 2015 04:54:13 -0700 (PDT) Received: from laptop1 (84.95.210.61.forward.012.net.il. [84.95.210.61]) by mx.google.com with ESMTPSA id c3sm11192379wiz.2.2015.04.13.04.54.12 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 13 Apr 2015 04:54:13 -0700 (PDT) From: "Raz Amir" To: "'Thomas Monjalon'" References: <13b901d07149$4e20d430$ea627c90$@gmail.com> <145601d07214$20aa04b0$61fe0e10$@gmail.com> <19871442.I62j3xGbVC@xps13> In-Reply-To: <19871442.I62j3xGbVC@xps13> Date: Mon, 13 Apr 2015 14:54:08 +0300 Message-ID: <156201d075e0$8d5e8390$a81b8ab0$@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQFeDtWPKMkm/xbDhwlnPNSnZltoBgH/cUZUAXeCSB6eE+vBUA== Content-Language: en-gb Cc: dev@dpdk.org Subject: Re: [dpdk-dev] Crash related to virtio NICs in DPDK 2.0.0 on Freebsd 10.1 VM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Apr 2015 11:54:14 -0000 Thanks. I will submit a patch -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] Sent: 13 April 2015 13:46 To: Raz Amir Cc: dev@dpdk.org; david.marchand@6wind.com Subject: Re: Crash related to virtio NICs in DPDK 2.0.0 on Freebsd 10.1 VM 2015-04-08 18:53, Raz Amir: > The issues happens also in dpdk 1.8.0, and related to patch > http://dpdk.org/dev/patchwork/patch/239/ > > Adding Thomas and David to the thread and I will appreciate your input. > > The patch comes to solve a file descriptor leak in the bsdapp version > of rte_eal_iopl_init after opening the /dev/io device. > > Seems like this isn't a file descriptor leak, and it should remain > open - as I wrote below, I am using virtio. Thanks for the bug report. It seems there was no validation for FreeBSD with virtio. > After removing it and testing the crash was resolved. > > Any objection for removing the close(fd) that was added at dpdk 1.8.0? No, there was a doubt because the man page was not clear. http://www.freebsd.org/cgi/man.cgi?query=io&sektion=4 In case you submit a patch, please add this line: Fixes: 8a312224bcde ("eal/bsd: fix fd leak") > Are there scenarios that might be impacted by removing it? I don't think so. Thanks