DPDK patches and discussions
 help / color / mirror / Atom feed
From: Lavanya Govindarajan <lavanyax.govindarajan@intel.com>
To: dev@dpdk.org
Cc: reshma.pattan@intel.com, anatoly.burakov@intel.com,
	david.marchand@redhat.com, jananeex.m.parthasarathy@intel.com,
	Lavanya Govindarajan <lavanyax.govindarajan@intel.com>
Subject: [dpdk-dev] [PATCH v3] test/eal: add ut for eal options proc-type and uio
Date: Wed,  3 Jul 2019 14:06:14 +0100	[thread overview]
Message-ID: <1562159174-12183-1-git-send-email-lavanyax.govindarajan@intel.com> (raw)
In-Reply-To: <1561637559-27164-1-git-send-email-lavanyax.govindarajan@intel.com>

Added unit test cases for EAL flags --proc-type=auto and
--create-uio-dev in order to cover the below functions
eal_proc_type_detect()
rte_eal_create_uio_dev()

Signed-off-by: Lavanya Govindarajan <lavanyax.govindarajan@intel.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
v3: Corrected error log message to be consistent
v2: Removed core and channels eal options as they are not significant
---

 app/test/test_eal_flags.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 9985ee979..3766c4cfc 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -903,6 +903,18 @@ test_misc_flags(void)
 	const char *argv15[] = {prgname, "--file-prefix=intr",
 			"--vfio-intr=invalid"};
 
+	/* With process type as auto-detect */
+	const char * const argv16[] = {prgname, "--file-prefix=auto",
+			"--proc-type=auto"};
+
+	/* With process type as auto-detect with no-shconf */
+	const char * const argv17[] = {prgname, "--proc-type=auto",
+			no_shconf, nosh_prefix, no_huge};
+
+	/* With process type as --create-uio-dev flag */
+	const char * const argv18[] = {prgname, "--file-prefix=uiodev",
+			"--create-uio-dev"};
+
 	/* run all tests also applicable to FreeBSD first */
 
 	if (launch_proc(argv0) == 0) {
@@ -979,6 +991,22 @@ test_misc_flags(void)
 				"--vfio-intr invalid parameter\n");
 		return -1;
 	}
+	if (launch_proc(argv16) != 0) {
+		printf("Error - process did not run ok with "
+				"--proc-type as auto parameter\n");
+		return -1;
+	}
+	if (launch_proc(argv17) != 0) {
+		printf("Error - process did not run ok with "
+				"--proc-type and --no-shconf parameter\n");
+		return -1;
+	}
+	if (launch_proc(argv18) != 0) {
+		printf("Error - process did not run ok with "
+				"--create-uio-dev parameter\n");
+		return -1;
+	}
+
 	return 0;
 }
 
-- 
2.14.1


  parent reply	other threads:[~2019-07-03 13:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-21 13:50 [dpdk-dev] [PATCH] " Lavanya Govindarajan
2019-06-26  9:32 ` Burakov, Anatoly
2019-06-26  9:36 ` David Marchand
2019-06-27 12:12 ` [dpdk-dev] [PATCH v2] " Lavanya Govindarajan
2019-07-02  7:33   ` David Marchand
2019-07-03 13:06   ` Lavanya Govindarajan [this message]
2019-07-04 21:52     ` [dpdk-dev] [PATCH v3] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1562159174-12183-1-git-send-email-lavanyax.govindarajan@intel.com \
    --to=lavanyax.govindarajan@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jananeex.m.parthasarathy@intel.com \
    --cc=reshma.pattan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).