From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 7E17A1BF2C; Wed, 27 Jun 2018 15:15:14 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id F2ADC21E5A; Wed, 27 Jun 2018 09:15:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 27 Jun 2018 09:15:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=MQCE2Qq+w2bV4Gbqbifz7QkSCN nkUXun7NKDk99iJ7I=; b=h8np3vTq4NKAvzr8NN5f9/ipkAJNerNl5RIL5PfyWQ qj93kzR2j/Y2CuYFlCHLFU58ZM5X0lvweoqor11KK3DTK52ncBeO8i2PyJsTC6OW RHnEJ8nmQOWmS1tvIxXs1NEqsQ3sPuzy5jKy/5N2SZKhH3RnWA/V9M2/mDLtqomj Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=MQCE2Q q+w2bV4Gbqbifz7QkSCNnkUXun7NKDk99iJ7I=; b=Q0rnH9JQaCSWbQkHgIWb8F iSQqAcGaWWiG5uZlqKQB/05OnEAn2ErGb9sGFlvl6DbYeRFc+kiggNiXNCkQH716 TDnqCx/xKoKhXdKZF2iPuv4nye70CzvhwtHmt1njpZJiZxY3jKJwTj7BnJt+k97f ooRv2j4SBE5OcdFLdxJhaVLjenDqwaSZHH9jijdvIuYTXX8oBUEklhXzcjjDlTVT tg6+1hg1kgoaE/h3te8O7QHF9WCkPTS5MmnIfUA7LNsyFBWFcNey5Pe9v6h2Btux 2xOPNB+Lx/eEJWp+QB5nwNimnmPQXqZFJMw1RYwrARoyEw9vNjH2YBDCOz/2ewCw == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 99BE5E4818; Wed, 27 Jun 2018 09:15:12 -0400 (EDT) From: Thomas Monjalon To: "Yigit, Ferruh" Cc: stable@dpdk.org, "De Lara Guarch, Pablo" , "dev@dpdk.org" , "stephen@networkplumber.org" Date: Wed, 27 Jun 2018 15:15:11 +0200 Message-ID: <1562187.JQU0VIWQ63@xps> In-Reply-To: References: <07e4d536-edd6-292d-5adb-c05793731623@intel.com> <20180626113807.67100-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] kni: fix build with gcc 8.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 13:15:14 -0000 26/06/2018 15:43, De Lara Guarch, Pablo: >=20 > > Error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option is > > enabled. > >=20 > > build error: > > In function =E2=80=98strncpy=E2=80=99, > > inlined from =E2=80=98igb_get_drvinfo=E2=80=99 at > > .../dpdk/build/build/kernel/linux/kni/igb_ethtool.c:814:2: > > .../include/linux/string.h:246:9: error: =E2=80=98__builtin_strncpy= =E2=80=99 output > > may be truncated copying 31 bytes from a string of length 42 > > [-Werror=3Dstringop-truncation] > > return __builtin_strncpy(p, q, size); > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >=20 > > Fixed by using strlcpy instead of strncpy. > >=20 > > adapter->fw_version size kept same because of > > c3698192940c ("kni: fix build with gcc 7.1") > >=20 > > Also next line strncpy usage replaced with strlcpy while arround. > >=20 > > Fixes: c3698192940c ("kni: fix build with gcc 7.1") > > Cc: stable@dpdk.org > >=20 > > Signed-off-by: Ferruh Yigit >=20 > Acked-by: Pablo de Lara Applied, thanks