From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 9930E1B86C for ; Wed, 4 Apr 2018 00:04:12 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 454B920B56; Tue, 3 Apr 2018 18:04:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 03 Apr 2018 18:04:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=b0aZbiLz9TWhc5oCxa3Q4gwkwo HHXE6e4tXe/s4BsSI=; b=qUIvXy6MupXcx3arSoVtdCbvASFWoP5ein7QnWwFq3 fh07xuFjob4M3IySxejvtCbNNExgOquvwwdOl0IOi3At1tEAit9TQysnHG9Ezslx Tv4ThWTX4ov0Bbye6xG+9oGFHrwFxnmkZrtKb4NHAAMvz+QOgdqjBN46pGYbwY1w A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=b0aZbi Lz9TWhc5oCxa3Q4gwkwoHHXE6e4tXe/s4BsSI=; b=j42UdbAL96jLvxlIz2/upf oKip/94UN5u8aKjNT7uBTgKpXk+PgWYma95Tb2Vw77CxhKA4ORCKRYujzVRr2wyC HnF1T1lFWGCRNwhBPSa/ihZTVXxET35vQejABJdE82b6PA0WpEAFS+sBWZyusQU5 BcMhbKrV2F3eHCcqLc0lDyue8QR6ifj+2dZ0tIoDAFBxEN9oROc24rrFPskF/KVq dUmqOhBehVv+rZRtxdIG87FRBIBgK2s1an6tjeEf6r9CdBzeX96S/5xmlOklQpP/ veQOLbL3lrsk3dVhPRBdB9PlyOaiMMWOdY9SG77U6lbdKYC35scLTmb5DDNEA1eA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AF4D8E5090; Tue, 3 Apr 2018 18:04:11 -0400 (EDT) From: Thomas Monjalon To: Shreyansh Jain Cc: dev@dpdk.org, hemant.agrawal@nxp.com Date: Wed, 04 Apr 2018 00:04:10 +0200 Message-ID: <1563071.oSqjFj96SH@xps> In-Reply-To: <482ae28a-ef73-9bde-ae06-f9983aa2caec@nxp.com> References: <20180402220649.662-1-thomas@monjalon.net> <3161325.7B0DNJKXUk@xps> <482ae28a-ef73-9bde-ae06-f9983aa2caec@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] config: remove useless lines for DPAA2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 22:04:12 -0000 03/04/2018 11:43, Shreyansh Jain: > On Tuesday 03 April 2018 12:33 PM, Thomas Monjalon wrote: > > 03/04/2018 08:55, Shreyansh Jain: > >> On Tuesday 03 April 2018 03:36 AM, Thomas Monjalon wrote: > >>> Some comments are not relevant in a config which only overrides > >>> the default config. > >>> > >>> The option CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER is already disabled > >>> by default so it can be removed from this file. > >>> > >>> Signed-off-by: Thomas Monjalon > >>> --- > >>> config/defconfig_arm64-dpaa2-linuxapp-gcc | 7 ------- > >>> 1 file changed, 7 deletions(-) > >> > >> I think DEBUG_DRIVER should exist in local config so that a developer > >> can easily toggle it without modifying the common_base, which should > >> serves as repository rather than toggle. > > > > No, the file to be modified is .config in the build directory, > > not the default config. > > In my environment I prefer changing the platform config rather than > local .config as that way I can track changes through git. > > > > >> I do see the problem that having an option in common_base and then > >> having it again in local config without overriding (=n) - is non-intuitive. > >> > >> But, I still feel it is easier to control changes in local config - > >> (make T=) is easily visible. > > > > It is not a local config file. > > The local config is .config. > > Sorry, allow me to rephrase my previous wordings: > > s/local config/platform config/ > > Anyways, this is just my personal preference - not a big inconvenience. > Thanks for the patch. > > Acked-By: Shreyansh Jain Applied