From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA2C7A0471 for ; Mon, 15 Jul 2019 10:18:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5027A322C; Mon, 15 Jul 2019 10:18:27 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 00AC12C60 for ; Mon, 15 Jul 2019 10:18:25 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6F8F4NL007427; Mon, 15 Jul 2019 01:18:25 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=pfpt0818; bh=PXDlDEyu5RbbuPdxaF3Wr4w9nd3Ze4KaxxG5zs345G0=; b=OsRPAd3LxZa0gu6fyjDahK+mftG74F9ZSwei+fX4NVWD+LAJ+2QtzzZUXV6vWjChPPtd Rtp69BFLvUFErg6kI5Krdq+KaGkyxyyCCCfp4XvOgNgCWv93fdeiWR/A7H94RVg0/k8I yBF2tnI7Va3UwB3uCkrMVM1Z301JHRy6G0XFQ0vpI7KskzSxwIm5JpP2TsUVRdfg2STe wluWhehIjGpycTLayq88PbPX8V4j7CIrEXSPTUy5wLzHUaIeN5UcJu2FEhrdNoXpPyuZ oxA2ZmRzSmy7cR7NA7Y+NgSNl1RuJVkyb8/MA/FpblcOymj2gLqPGuvy373vF8BA/oWK 1Q== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2tqetmnrj0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 15 Jul 2019 01:18:25 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 15 Jul 2019 01:18:23 -0700 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Mon, 15 Jul 2019 01:18:23 -0700 Received: from dc7-eodlnx05.marvell.com (dc7-eodlnx05.marvell.com [10.28.113.55]) by maili.marvell.com (Postfix) with ESMTP id 2CC8C3F7040; Mon, 15 Jul 2019 01:18:21 -0700 (PDT) From: Sunil Kumar Kori To: Konstantin Ananyev CC: , Sunil Kumar Kori Date: Mon, 15 Jul 2019 13:47:57 +0530 Message-ID: <1563178677-16356-1-git-send-email-skori@marvell.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-15_02:2019-07-12,2019-07-15 signatures=0 Subject: [dpdk-dev] [PATCH] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags during fragmentation and reassemble operation implicitly. Because of this, application is forced to use checksum offload whether it is supported by platform or not. Also documentation does not provide any expected value of ol_flags in returned mbuf (reassembled or fragmented) so application will never come to know that which offloads are enabled. So transmission may be failed for the platforms which does not support checksum offload. So removing mentioned flag from the library. Signed-off-by: Sunil Kumar Kori --- Current patch is part of following patchset http://patches.dpdk.org/patch/53475/ which is missed to be merged into upstream because of accepted version of this patch does not contain this change. Accepted patchset is given below: http://patches.dpdk.org/patch/56202/ Patchset is already reviewed and acked on maillist. Also corrersponding release notes are updated. lib/librte_ip_frag/rte_ipv4_fragmentation.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_ip_frag/rte_ipv4_fragmentation.c b/lib/librte_ip_frag/rte_ipv4_fragmentation.c index 221d74e..9e9f986 100644 --- a/lib/librte_ip_frag/rte_ipv4_fragmentation.c +++ b/lib/librte_ip_frag/rte_ipv4_fragmentation.c @@ -173,7 +173,6 @@ static inline void __free_fragments(struct rte_mbuf *mb[], uint32_t num) fragment_offset = (uint16_t)(fragment_offset + out_pkt->pkt_len - sizeof(struct rte_ipv4_hdr)); - out_pkt->ol_flags |= PKT_TX_IP_CKSUM; out_pkt->l3_len = sizeof(struct rte_ipv4_hdr); /* Write the fragment to the output list */ -- 1.8.3.1