From: Sunil Kumar Kori <skori@marvell.com>
To: Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: <dev@dpdk.org>, Sunil Kumar Kori <skori@marvell.com>
Subject: [dpdk-dev] [PATCH] examples/ip_fragmentation: fix DEV_TX_OFFLOAD_MBUF_FAST_FREE flag
Date: Thu, 25 Jul 2019 11:20:10 +0530 [thread overview]
Message-ID: <1564033810-15715-1-git-send-email-skori@marvell.com> (raw)
Application uses different pool to allocate direct and indirect
mbufs which are further spliced together to consturct a fragmented
packet and same is transmitted over the port which is configured
with DEV_TX_OFFLOAD_MBUF_FAST_FREE enabled i.e. all segments
must belong to the same pool. But constructed packet violates
the conditions.
So fixing DEV_TX_OFFLOAD_MBUF_FAST_FREE flag during device
configuration.
Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
examples/ip_fragmentation/main.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c
index 03be0c1..324d607 100644
--- a/examples/ip_fragmentation/main.c
+++ b/examples/ip_fragmentation/main.c
@@ -939,9 +939,6 @@ struct rte_lpm6_config lpm6_config = {
n_tx_queue = nb_lcores;
if (n_tx_queue > MAX_TX_QUEUE_PER_PORT)
n_tx_queue = MAX_TX_QUEUE_PER_PORT;
- if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
- local_port_conf.txmode.offloads |=
- DEV_TX_OFFLOAD_MBUF_FAST_FREE;
ret = rte_eth_dev_configure(portid, 1, (uint16_t)n_tx_queue,
&local_port_conf);
if (ret < 0) {
--
1.8.3.1
next reply other threads:[~2019-07-25 5:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 5:50 Sunil Kumar Kori [this message]
2019-07-25 5:58 ` [dpdk-dev] [PATCH v2 1/1] examples/ip_frag: " Sunil Kumar Kori
2019-07-25 7:54 ` Ananyev, Konstantin
2019-07-25 8:24 ` [dpdk-dev] [PATCH v3 1/1] examples/ip_frag: fix Tx fast free offload flag Sunil Kumar Kori
2019-07-25 8:28 ` Jerin Jacob Kollanukkaran
2019-07-25 10:49 ` Ananyev, Konstantin
2019-07-29 21:46 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1564033810-15715-1-git-send-email-skori@marvell.com \
--to=skori@marvell.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).