From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2B322A046B
	for <public@inbox.dpdk.org>; Thu, 25 Jul 2019 07:50:19 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 7DEAC1C27B;
	Thu, 25 Jul 2019 07:50:18 +0200 (CEST)
Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com
 [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 6F6151C277
 for <dev@dpdk.org>; Thu, 25 Jul 2019 07:50:16 +0200 (CEST)
Received: from pps.filterd (m0045849.ppops.net [127.0.0.1])
 by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id
 x6P5nd6m006990; Wed, 24 Jul 2019 22:50:15 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;
 h=from : to : cc :
 subject : date : message-id : mime-version : content-type; s=pfpt0818;
 bh=Fz07eCk0ER+cSlmCak5f/U0tJws0/BMMbl5fegVxUC4=;
 b=sVRDkAxlBTjKtRNd27InE2KKYzIAJTjeOb3hMkYT72MfDKH5HnX0PZplQLuPggc6o0sQ
 zeeLnf6tQyIr8SThCu0qUPz7qy44arragOLyuzenJvitue7jjLo4aQb5OZ8KMdj9oPGZ
 ADfeOgw8tFNcHZ/fcN1mXZ4jlVpI0iNWw05qA8CGwAbjm6tf4Hpr5x5BvDQZ4mwJXXZc
 V8yChe+MgFj7FspXnzv/Tf8JFKn0BiL+xSQn5BreLWrkTt2ohNv0WQV6Q6NISBNLwotX
 GN1MbbTzZKw0mkA5paTWrfQCWs13i9V2nZgI6I/8ZNhMqMR4C2dqvsIXAaDFTfg0ldk6 Jg== 
Received: from sc-exch04.marvell.com ([199.233.58.184])
 by mx0a-0016f401.pphosted.com with ESMTP id 2tx61rg2yw-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);
 Wed, 24 Jul 2019 22:50:15 -0700
Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com
 (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 24 Jul
 2019 22:50:14 -0700
Received: from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com
 (10.93.176.81) with Microsoft SMTP Server id 15.0.1367.3 via Frontend
 Transport; Wed, 24 Jul 2019 22:50:14 -0700
Received: from dc7-eodlnx05.marvell.com (dc7-eodlnx05.marvell.com
 [10.28.113.55])
 by maili.marvell.com (Postfix) with ESMTP id 303323F703F;
 Wed, 24 Jul 2019 22:50:12 -0700 (PDT)
From: Sunil Kumar Kori <skori@marvell.com>
To: Konstantin Ananyev <konstantin.ananyev@intel.com>
CC: <dev@dpdk.org>, Sunil Kumar Kori <skori@marvell.com>
Date: Thu, 25 Jul 2019 11:20:10 +0530
Message-ID: <1564033810-15715-1-git-send-email-skori@marvell.com>
X-Mailer: git-send-email 1.8.3.1
MIME-Version: 1.0
Content-Type: text/plain
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8
 definitions=2019-07-25_03:2019-07-25,2019-07-25 signatures=0
Subject: [dpdk-dev] [PATCH] examples/ip_fragmentation: fix
	DEV_TX_OFFLOAD_MBUF_FAST_FREE flag
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Application uses different pool to allocate direct and indirect
mbufs which are further spliced together to consturct a fragmented
packet and same is transmitted over the port which is configured
with DEV_TX_OFFLOAD_MBUF_FAST_FREE enabled i.e. all segments
must belong to the same pool. But constructed packet violates
the conditions.

So fixing DEV_TX_OFFLOAD_MBUF_FAST_FREE flag during device
configuration.

Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
 examples/ip_fragmentation/main.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c
index 03be0c1..324d607 100644
--- a/examples/ip_fragmentation/main.c
+++ b/examples/ip_fragmentation/main.c
@@ -939,9 +939,6 @@ struct rte_lpm6_config lpm6_config = {
 		n_tx_queue = nb_lcores;
 		if (n_tx_queue > MAX_TX_QUEUE_PER_PORT)
 			n_tx_queue = MAX_TX_QUEUE_PER_PORT;
-		if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
-			local_port_conf.txmode.offloads |=
-				DEV_TX_OFFLOAD_MBUF_FAST_FREE;
 		ret = rte_eth_dev_configure(portid, 1, (uint16_t)n_tx_queue,
 					    &local_port_conf);
 		if (ret < 0) {
-- 
1.8.3.1