DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] examples/ip_pipeline: fix load balancing function in pass-through pipeline
@ 2016-11-21 13:37 Jasvinder Singh
  2016-12-28 18:49 ` Dumitrescu, Cristian
  0 siblings, 1 reply; 3+ messages in thread
From: Jasvinder Singh @ 2016-11-21 13:37 UTC (permalink / raw)
  To: dev; +Cc: cristian.dumitrescu

This patch fixes the configuration file parsing error when load balancing
function is enabled in pass-through pipeline.

error log:
pipeline> [APP] Initializing PIPELINE1 ...
[PIPELINE1] Pass-through
Parse error in section "PIPELINE1": entry "lb" has invalid value ("hash")

Fixes: cbe82f6cfb0a ("examples/ip_pipeline: add swap action in pass-through")

Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
 examples/ip_pipeline/pipeline/pipeline_passthrough_be.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/ip_pipeline/pipeline/pipeline_passthrough_be.c b/examples/ip_pipeline/pipeline/pipeline_passthrough_be.c
index 8b71a7d..7ab0afe 100644
--- a/examples/ip_pipeline/pipeline/pipeline_passthrough_be.c
+++ b/examples/ip_pipeline/pipeline/pipeline_passthrough_be.c
@@ -589,7 +589,7 @@ pipeline_passthrough_parse_args(struct pipeline_passthrough_params *p,
 				params->name, arg_name);
 			dma_hash_lb_present = 1;
 
-			if (strcmp(arg_value, "hash") ||
+			if (strcmp(arg_value, "hash") &&
 				strcmp(arg_value, "HASH"))
 
 				PIPELINE_PARSE_ERR_INV_VAL(0,
-- 
2.5.5

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix load balancing function in pass-through pipeline
  2016-11-21 13:37 [dpdk-dev] [PATCH] examples/ip_pipeline: fix load balancing function in pass-through pipeline Jasvinder Singh
@ 2016-12-28 18:49 ` Dumitrescu, Cristian
  2017-01-17 17:31   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Dumitrescu, Cristian @ 2016-12-28 18:49 UTC (permalink / raw)
  To: Singh, Jasvinder, dev



> -----Original Message-----
> From: Singh, Jasvinder
> Sent: Monday, November 21, 2016 1:38 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Subject: [PATCH] examples/ip_pipeline: fix load balancing function in pass-
> through pipeline
> 
> This patch fixes the configuration file parsing error when load balancing
> function is enabled in pass-through pipeline.
> 
> error log:
> pipeline> [APP] Initializing PIPELINE1 ...
> [PIPELINE1] Pass-through
> Parse error in section "PIPELINE1": entry "lb" has invalid value ("hash")
> 
> Fixes: cbe82f6cfb0a ("examples/ip_pipeline: add swap action in pass-
> through")
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
>  examples/ip_pipeline/pipeline/pipeline_passthrough_be.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix load balancing function in pass-through pipeline
  2016-12-28 18:49 ` Dumitrescu, Cristian
@ 2017-01-17 17:31   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-01-17 17:31 UTC (permalink / raw)
  To: Singh, Jasvinder; +Cc: dev, Dumitrescu, Cristian

> > This patch fixes the configuration file parsing error when load balancing
> > function is enabled in pass-through pipeline.
> > 
> > error log:
> > pipeline> [APP] Initializing PIPELINE1 ...
> > [PIPELINE1] Pass-through
> > Parse error in section "PIPELINE1": entry "lb" has invalid value ("hash")
> > 
> > Fixes: cbe82f6cfb0a ("examples/ip_pipeline: add swap action in pass-
> > through")
> > 
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-01-17 17:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-21 13:37 [dpdk-dev] [PATCH] examples/ip_pipeline: fix load balancing function in pass-through pipeline Jasvinder Singh
2016-12-28 18:49 ` Dumitrescu, Cristian
2017-01-17 17:31   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).