From: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
To: dev@dpdk.org
Cc: yskoh@mellanox.com, shahafs@mellanox.com
Subject: [dpdk-dev] [PATCH] net/mlx5: fix default minimal data inline
Date: Thu, 1 Aug 2019 07:43:27 +0000 [thread overview]
Message-ID: <1564645407-13206-1-git-send-email-viacheslavo@mellanox.com> (raw)
In-Reply-To: <1564404065-4823-3-git-send-email-viacheslavo@mellanox.com>
The patch [Fixes] sets the default value of required minimal
inline data to 0 bytes. On some configurations (depends
on switchdev/legacy settings and FW version/settings)
the ConnectX-4LX NIC requires minimal 18 bytes of
Tx descriptor inline data to operate correctly.
Wrongly set to 0 default value may prevent NIC from operating
with out-of-the-box settings, this patch reverts default
value for ConnectX-4LX back to 18 bytes (inline L2).
Fixes: 9f350504bb32 ("net/mlx5: fix ConnectX-4LX minimal inline data limit")
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
---
drivers/net/mlx5/mlx5.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index f5bc31f..5a1ea80 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -1325,12 +1325,9 @@ struct mlx5_dev_spawn_data {
switch (spawn->pci_dev->id.device_id) {
case PCI_DEVICE_ID_MELLANOX_CONNECTX4:
case PCI_DEVICE_ID_MELLANOX_CONNECTX4VF:
- config->txq_inline_min = MLX5_INLINE_HSIZE_L2;
- config->hw_vlan_insert = 0;
- break;
case PCI_DEVICE_ID_MELLANOX_CONNECTX4LX:
case PCI_DEVICE_ID_MELLANOX_CONNECTX4LXVF:
- config->txq_inline_min = MLX5_INLINE_HSIZE_NONE;
+ config->txq_inline_min = MLX5_INLINE_HSIZE_L2;
config->hw_vlan_insert = 0;
break;
case PCI_DEVICE_ID_MELLANOX_CONNECTX5:
--
1.8.3.1
next prev parent reply other threads:[~2019-08-01 7:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 12:41 [dpdk-dev] [PATCH 0/3] net/mlx5: transmit datapath cumulative fix pack Viacheslav Ovsiienko
2019-07-29 12:41 ` [dpdk-dev] [PATCH 1/3] net/mlx5: fix Tx completion descriptors fetching loop Viacheslav Ovsiienko
2019-07-29 12:41 ` [dpdk-dev] [PATCH 2/3] net/mlx5: fix ConnectX-4LX minimal inline data limit Viacheslav Ovsiienko
2019-08-01 7:43 ` Viacheslav Ovsiienko [this message]
2019-07-29 12:41 ` [dpdk-dev] [PATCH 3/3] net/mlx5: fix the Tx completion request generation Viacheslav Ovsiienko
2019-07-29 15:13 ` [dpdk-dev] [PATCH 0/3] net/mlx5: transmit datapath cumulative fix pack Matan Azrad
2019-07-29 15:23 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1564645407-13206-1-git-send-email-viacheslavo@mellanox.com \
--to=viacheslavo@mellanox.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).