* [dpdk-dev] [PATCH] net/mlx5: fix inline data len assert condition
@ 2019-08-01 7:43 Viacheslav Ovsiienko
2019-08-01 21:18 ` Matan Azrad
0 siblings, 1 reply; 2+ messages in thread
From: Viacheslav Ovsiienko @ 2019-08-01 7:43 UTC (permalink / raw)
To: dev; +Cc: yskoh, shahafs
The debug assert wrongly triggers on the inline data 18B,
this should be passed successfully.
Fixes: 18a1c20044c0 ("net/mlx5: implement Tx burst template")
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
---
drivers/net/mlx5/mlx5_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index 7a2e153..7110946 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/mlx5_rxtx.c
@@ -2626,7 +2626,7 @@ enum mlx5_txcmp_code {
sizeof(struct rte_vlan_hdr) +
2 * RTE_ETHER_ADDR_LEN),
"invalid Ethernet Segment data size");
- assert(inlen > MLX5_ESEG_MIN_INLINE_SIZE);
+ assert(inlen >= MLX5_ESEG_MIN_INLINE_SIZE);
es->inline_hdr_sz = rte_cpu_to_be_16(inlen);
pdst = (uint8_t *)&es->inline_data;
if (MLX5_TXOFF_CONFIG(VLAN) && vlan) {
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix inline data len assert condition
2019-08-01 7:43 [dpdk-dev] [PATCH] net/mlx5: fix inline data len assert condition Viacheslav Ovsiienko
@ 2019-08-01 21:18 ` Matan Azrad
0 siblings, 0 replies; 2+ messages in thread
From: Matan Azrad @ 2019-08-01 21:18 UTC (permalink / raw)
To: Slava Ovsiienko, dev; +Cc: Yongseok Koh, Shahaf Shuler
From: Viacheslav Ovsiienko
> The debug assert wrongly triggers on the inline data 18B, this should be
> passed successfully.
>
> Fixes: 18a1c20044c0 ("net/mlx5: implement Tx burst template")
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index 7a2e153..7110946 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -2626,7 +2626,7 @@ enum mlx5_txcmp_code {
> sizeof(struct rte_vlan_hdr) +
> 2 * RTE_ETHER_ADDR_LEN),
> "invalid Ethernet Segment data size");
> - assert(inlen > MLX5_ESEG_MIN_INLINE_SIZE);
> + assert(inlen >= MLX5_ESEG_MIN_INLINE_SIZE);
> es->inline_hdr_sz = rte_cpu_to_be_16(inlen);
> pdst = (uint8_t *)&es->inline_data;
> if (MLX5_TXOFF_CONFIG(VLAN) && vlan) {
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-01 21:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-01 7:43 [dpdk-dev] [PATCH] net/mlx5: fix inline data len assert condition Viacheslav Ovsiienko
2019-08-01 21:18 ` Matan Azrad
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).