Fixes: c41a04958b ("net/memif: support multi-process") Signed-off-by: Phil Yang <phil.yang@arm.com> Reviewed-by: Gavin Hu <gavin.hu@arm.com> --- drivers/net/memif/rte_eth_memif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c index bcda426..a59f809 100644 --- a/drivers/net/memif/rte_eth_memif.c +++ b/drivers/net/memif/rte_eth_memif.c @@ -1265,7 +1265,7 @@ rte_pmd_memif_probe(struct rte_vdev_device *vdev) eth_dev->dev_ops = &ops; eth_dev->device = &vdev->device; eth_dev->rx_pkt_burst = eth_memif_rx; - eth_dev->tx_pkt_burst = eth_memif_rx; + eth_dev->tx_pkt_burst = eth_memif_tx; if (!rte_eal_primary_proc_alive(NULL)) { MIF_LOG(ERR, "Primary process is missing"); -- 2.7.4
01/08/2019 12:35, Phil Yang:
> Fixes: c41a04958b ("net/memif: support multi-process")
>
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> ---
> --- a/drivers/net/memif/rte_eth_memif.c
> +++ b/drivers/net/memif/rte_eth_memif.c
> @@ -1265,7 +1265,7 @@ rte_pmd_memif_probe(struct rte_vdev_device *vdev)
> eth_dev->dev_ops = &ops;
> eth_dev->device = &vdev->device;
> eth_dev->rx_pkt_burst = eth_memif_rx;
> - eth_dev->tx_pkt_burst = eth_memif_rx;
> + eth_dev->tx_pkt_burst = eth_memif_tx;
It is not a probe error, but malfunctioning device, right?
What is the current behaviour? You could better explain
the symptom in the commit log, and the root cause (typo).
02/08/2019 23:01, Thomas Monjalon:
> 01/08/2019 12:35, Phil Yang:
> > Fixes: c41a04958b ("net/memif: support multi-process")
> >
> > Signed-off-by: Phil Yang <phil.yang@arm.com>
> > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> > ---
> > --- a/drivers/net/memif/rte_eth_memif.c
> > +++ b/drivers/net/memif/rte_eth_memif.c
> > @@ -1265,7 +1265,7 @@ rte_pmd_memif_probe(struct rte_vdev_device *vdev)
> > eth_dev->dev_ops = &ops;
> > eth_dev->device = &vdev->device;
> > eth_dev->rx_pkt_burst = eth_memif_rx;
> > - eth_dev->tx_pkt_burst = eth_memif_rx;
> > + eth_dev->tx_pkt_burst = eth_memif_tx;
>
> It is not a probe error, but malfunctioning device, right?
> What is the current behaviour? You could better explain
> the symptom in the commit log, and the root cause (typo).
Nobody is replying or sending a v2?
Jakub?
> -----Original Message----- > From: Thomas Monjalon <thomas@monjalon.net> > Sent: Tuesday, August 6, 2019 4:08 PM > To: Phil Yang (Arm Technology China) <Phil.Yang@arm.com>; > jgrajcia@cisco.com > Cc: dev@dpdk.org; anatoly.burakov@intel.com; ferruh.yigit@intel.com; > Gavin Hu (Arm Technology China) <Gavin.Hu@arm.com>; Honnappa > Nagarahalli <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com> > Subject: Re: [dpdk-dev] [PATCH] net/memif: fix multi-process device probe > error > > 02/08/2019 23:01, Thomas Monjalon: > > 01/08/2019 12:35, Phil Yang: > > > Fixes: c41a04958b ("net/memif: support multi-process") > > > > > > Signed-off-by: Phil Yang <phil.yang@arm.com> > > > Reviewed-by: Gavin Hu <gavin.hu@arm.com> > > > --- > > > --- a/drivers/net/memif/rte_eth_memif.c > > > +++ b/drivers/net/memif/rte_eth_memif.c > > > @@ -1265,7 +1265,7 @@ rte_pmd_memif_probe(struct > rte_vdev_device *vdev) > > > eth_dev->dev_ops = &ops; > > > eth_dev->device = &vdev->device; > > > eth_dev->rx_pkt_burst = eth_memif_rx; > > > - eth_dev->tx_pkt_burst = eth_memif_rx; > > > + eth_dev->tx_pkt_burst = eth_memif_tx; > > Hi Thomas, Sorry for the later response. > > It is not a probe error, but malfunctioning device, right? Yes, agree. > > What is the current behaviour? You could better explain > > the symptom in the commit log, and the root cause (typo). Since testpmd has issues working as a secondary process, so I cannot get the typo for this issue. But in logically, the memif PMD should use eth_memif_tx in the egress path. I will update the commit log in v2. > > Nobody is replying or sending a v2? > Jakub? > Thanks, Phil
When working as a secondary process, it uses eth_memif_rx in PMD egress. It should be eth_memif_tx. Fixes: c41a04958b ("net/memif: support multi-process") Signed-off-by: Phil Yang <phil.yang@arm.com> Reviewed-by: Gavin Hu <gavin.hu@arm.com> --- v2: Add descriptions in commit log. v1: Initial version. drivers/net/memif/rte_eth_memif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c index bcda426..a59f809 100644 --- a/drivers/net/memif/rte_eth_memif.c +++ b/drivers/net/memif/rte_eth_memif.c @@ -1265,7 +1265,7 @@ rte_pmd_memif_probe(struct rte_vdev_device *vdev) eth_dev->dev_ops = &ops; eth_dev->device = &vdev->device; eth_dev->rx_pkt_burst = eth_memif_rx; - eth_dev->tx_pkt_burst = eth_memif_rx; + eth_dev->tx_pkt_burst = eth_memif_tx; if (!rte_eal_primary_proc_alive(NULL)) { MIF_LOG(ERR, "Primary process is missing"); -- 2.7.4
06/08/2019 10:45, Phil Yang:
> When working as a secondary process, it uses eth_memif_rx in PMD egress.
> It should be eth_memif_tx.
>
> Fixes: c41a04958b ("net/memif: support multi-process")
>
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
Applied, thanks
Instead of the vague "malfunctioning device",
I replaced with "Tx" in the title.