Re: [dpdk-dev] [PATCH v7] net/mlx5: support upstream rdma-core

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 9/18/2017 3:49 PM, Shachar Beiser wrote:
> This removes the dependency on specific Mellanox OFED libraries by
> using the upstream rdma-core and linux upstream community code.
> Both rdma-core upstream and Mellanox OFED are Linux user-space packages:
>   1. Rdma-core is Linux upstream user-space package.(Generic)
>   2. Mellanox OFED is Mellanox's Linux user-space package.(Proprietary)
> The difference between the two are the APIs towards the kernel.
> 
> ---
> a. Compile with rdma-core commit f11292efd541 ("Merge pull request #202")
> b. Tested with linux kernel 4.13-rc4
> c. For performance testing recommended to wait till kernel 4.14
> 
> Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>

Can you please move sign off above comment (---)

> ---
> 
> Rebase on top of series:
> http://dpdk.org/dev/patchwork/patch/28804/
> http://dpdk.org/dev/patchwork/patch/28805/
> This patch should be applied on top of :
> http://dpdk.org/dev/patchwork/patch/28805/
> 
> This patch enhances the commit log of the previous patch:
> http://dpdk.org/dev/patchwork/patch/28803/
> An update to the release notes will be sent saperately by Shahaf 
> Shuler.
> ---

Hi Shachar,

I can finally able to compile this via rdma-core v15 (Thanks to Nelio),
since I don't have Mellanox OFED 4.2

1- Shared library build fails. mlx5 driver now depends on libmlx5.so,
this dependency should be added [1], otherwise giving build error [2].

2- 32bit build broken, this is because rdma-core 32bit missing.
a) Is rdma-core supports 32bit?
b) Is mlx5 supports 32bit?

3- I am getting ICC warning from rdma-core header [3], same warning many
times. Would you mind disabling that warning for mlx5 [4] ?


[1]
  +++ b/drivers/net/mlx5/Makefile
  @@ -63,7 +63,7 @@ CFLAGS += -D_DEFAULT_SOURCE
   CFLAGS += -D_XOPEN_SOURCE=600
   CFLAGS += $(WERROR_FLAGS)
   CFLAGS += -Wno-strict-prototypes
  -LDLIBS += -libverbs
  +LDLIBS += -libverbs -lmlx5


[2]
../drivers/net/mlx5/mlx5.c:542: undefined reference to `mlx5dv_query_device'
mlx5_rxq.o: In function `rxq_setup':
../drivers/net/mlx5/mlx5_rxq.c:803: undefined reference to `mlx5dv_init_obj'
mlx5_txq.o: In function `txq_setup':
../drivers/net/mlx5/mlx5_txq.c:175: undefined reference to `mlx5dv_init_obj'


[3]
In file included from ../drivers/net/mlx5/mlx5.c(48):

/root/development/rdma-core/build/include/infiniband/verbs.h(84):
warning #61: integer operation result is out of range
  static void *__VERBS_ABI_IS_EXTENDED = ((uint8_t *) NULL) - 1;

                                                            ^

[4]
  +++ b/drivers/net/mlx5/Makefile
  @@ -77,6 +77,11 @@ ifeq ($(DEBUG),1
  +ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
  +# For rdma-core v15 headers
  +CFLAGS += -wd61
  +endif


<...>