DPDK patches and discussions
 help / color / mirror / Atom feed
From: Phil Yang <phil.yang@arm.com>
To: dev@dpdk.org, thomas@monjalon.net
Cc: jgrajcia@cisco.com, anatoly.burakov@intel.com,
	ferruh.yigit@intel.com, gavin.hu@arm.com,
	honnappa.nagarahalli@arm.com, nd@arm.com
Subject: [dpdk-dev] [PATCH v2] net/memif: fix multi-process malfunctioning device
Date: Tue,  6 Aug 2019 16:45:26 +0800	[thread overview]
Message-ID: <1565081126-14432-1-git-send-email-phil.yang@arm.com> (raw)
In-Reply-To: <1564655727-4142-1-git-send-email-phil.yang@arm.com>

When working as a secondary process, it uses eth_memif_rx in PMD egress.
It should be eth_memif_tx.

Fixes: c41a04958b ("net/memif: support multi-process")

Signed-off-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
---
v2:
Add descriptions in commit log.

v1:
Initial version.

 drivers/net/memif/rte_eth_memif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c
index bcda426..a59f809 100644
--- a/drivers/net/memif/rte_eth_memif.c
+++ b/drivers/net/memif/rte_eth_memif.c
@@ -1265,7 +1265,7 @@ rte_pmd_memif_probe(struct rte_vdev_device *vdev)
 		eth_dev->dev_ops = &ops;
 		eth_dev->device = &vdev->device;
 		eth_dev->rx_pkt_burst = eth_memif_rx;
-		eth_dev->tx_pkt_burst = eth_memif_rx;
+		eth_dev->tx_pkt_burst = eth_memif_tx;
 
 		if (!rte_eal_primary_proc_alive(NULL)) {
 			MIF_LOG(ERR, "Primary process is missing");
-- 
2.7.4


  parent reply	other threads:[~2019-08-06  8:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-01 10:35 [dpdk-dev] [PATCH] net/memif: fix multi-process device probe error Phil Yang
2019-08-02 21:01 ` Thomas Monjalon
2019-08-06  8:08   ` Thomas Monjalon
2019-08-06  8:18     ` Phil Yang (Arm Technology China)
2019-08-06  8:45 ` Phil Yang [this message]
2019-08-06  9:28   ` [dpdk-dev] [PATCH v2] net/memif: fix multi-process malfunctioning device Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1565081126-14432-1-git-send-email-phil.yang@arm.com \
    --to=phil.yang@arm.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=gavin.hu@arm.com \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=jgrajcia@cisco.com \
    --cc=nd@arm.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).