[dpdk-dev] [PATCH v2] net/ixgbe: fix rss_conf sizeof argument

[dpdk-dev] [PATCH v2] net/ixgbe: fix rss_conf sizeof argument

[Congwen Zhang]

The type of rss_conf is struct ixgbe_rte_flow_rss_conf *,
 not struct rte_eth_rss_conf *.

Fixes: 518cc3927b13 ("net/ixgbe: move RSS to flow API")

Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
---
 drivers/net/ixgbe/ixgbe_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
index 92377b8..b2a2bfc 100644
--- a/drivers/net/ixgbe/ixgbe_flow.c
+++ b/drivers/net/ixgbe/ixgbe_flow.c
@@ -2874,7 +2874,7 @@ static inline uint8_t signature_match(const struct rte_flow_item pattern[])
 	/* check if the next not void item is END */
 	act = next_no_void_action(actions, act);
 	if (act->type != RTE_FLOW_ACTION_TYPE_END) {
-		memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf));
+		memset(rss_conf, 0, sizeof(struct ixgbe_rte_flow_rss_conf));
 		rte_flow_error_set(error, EINVAL,
 			RTE_FLOW_ERROR_TYPE_ACTION,
 			act, "Not supported action.");
-- 
1.8.3.1

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/ixgbe: fix rss_conf sizeof argument

[David Marchand]

On Wed, Aug 7, 2019 at 11:42 AM Congwen Zhang <zhang.congwen@zte.com.cn> wrote:
>
> The type of rss_conf is struct ixgbe_rte_flow_rss_conf *,
>  not struct rte_eth_rss_conf *.
>
> Fixes: 518cc3927b13 ("net/ixgbe: move RSS to flow API")

Cc: stable@dpdk.org must be part of the commitlog.

This commitlog does not describe the issue that this incorrect memset triggered.


-- 
David Marchand