From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: aconole@redhat.com, msantana@redhat.com
Subject: [dpdk-dev] [PATCH] ci: exit setup on any error
Date: Thu, 8 Aug 2019 14:22:17 +0200 [thread overview]
Message-ID: <1565266937-8159-1-git-send-email-david.marchand@redhat.com> (raw)
-e is preferrable so that we can catch errors in the middle of this
script.
An example is this Travis job [1] that should have errored at the meson
install step rather than go to the build step.
Adding debug mode as it can help post-mortem.
1: https://travis-ci.com/DPDK/dpdk/jobs/223511683
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
.ci/linux-setup.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.ci/linux-setup.sh b/.ci/linux-setup.sh
index a40e62e..dfb9d4a 100755
--- a/.ci/linux-setup.sh
+++ b/.ci/linux-setup.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/sh -xe
# need to install as 'root' since some of the unit tests won't run without it
sudo python3 -m pip install --upgrade meson
--
1.8.3.1
next reply other threads:[~2019-08-08 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 12:22 David Marchand [this message]
2019-08-08 13:07 ` Michael Santana Francisco
2019-08-08 14:30 ` Aaron Conole
2019-09-13 11:19 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1565266937-8159-1-git-send-email-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=msantana@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).