From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 501AFB130 for ; Fri, 13 Jun 2014 17:15:15 +0200 (CEST) Received: by mail-wg0-f45.google.com with SMTP id l18so2944392wgh.16 for ; Fri, 13 Jun 2014 08:15:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=XNdZg2MfPEPpc+r0UcpuKyfcUjUMkrvOs61otkFt7ek=; b=QZOheJ6ffcd6Qt1TV7OhDb1MGJgooyUBKearYdcAKkEXBHio9ylJxjRUweybKEw/Cu KtSrnvzcycRXUXlZPPqk19qhL1v1AW/u6d7OzLg+eZp87Kd81ppca/t67Xxwi3Apl3fb A9QG6YUb2l8vop9Cf9sCz0ep5nOjHyIxTfwg+1w3pkriB9rCSdnQAzqYyC/oftiH+cBF a/JpTvoQ/E+0+rdM4tVHu5WUAl1iyMPsWMJmeyKNQSoq8/0OnFgFbmHNco5UtRe8Kn9d NRdngaqXSllE2degzntAipR3ZCd4uv3VDbEKEUnEE1vNxWqk8K2vLA0VxaQa5jwdAz/i NnLg== X-Gm-Message-State: ALoCoQnoDpLjUvoZbQ4lV7/juZqoXCzoVX37DJkRmsjujPkod4Mb+OMIYO/jUYrTC6A2cjEWYJ4M X-Received: by 10.180.186.97 with SMTP id fj1mr5796151wic.18.1402672530613; Fri, 13 Jun 2014 08:15:30 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id m1sm3005524wib.20.2014.06.13.08.15.29 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Jun 2014 08:15:29 -0700 (PDT) From: Thomas Monjalon To: "Doherty, Declan" Date: Fri, 13 Jun 2014 17:15:28 +0200 Message-ID: <1565896.yfGPTW1YQK@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <345C63BAECC1AD42A2EC8C63AFFC3ADC13D38CDE@IRSMSX101.ger.corp.intel.com> References: <8171413.fZ253oGTLE@xps13> <345C63BAECC1AD42A2EC8C63AFFC3ADC13D38CDE@IRSMSX101.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Neil Horman Subject: Re: [dpdk-dev] [PATCH v2 0/4] Link Bonding Library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jun 2014 15:15:15 -0000 2014-06-13 14:08, Doherty, Declan: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Do you think you can send another version of your serie soon? > > Some comments need to be addressed. > > > > 2 formatting comments: > > - I saw some strange alignments of comments > > - you should send your patches as children of the cover letter > > Hi Thomas, > I've just submitted v3 of the patch, which should address the majority of the comments and any formatting issues. Thanks. We are now waiting for Neil's acknowledgement. On the formatting side, please check these errors: ERROR: "foo* bar" should be "foo *bar" ERROR: space prohibited before that close parenthesis ')' About git-send-email, I'd prefer you conform to this scheme for man page: " So for example when --thread and --no-chain-reply-to are specified, the second and subsequent patches will be replies to the first one like in the illustration below where [PATCH v2 0/3] is in reply to [PATCH 0/2]: [PATCH 0/2] Here is what I did... [PATCH 1/2] Clean up and tests [PATCH 2/2] Implementation [PATCH v2 0/3] Here is a reroll [PATCH v2 1/3] Clean up [PATCH v2 2/3] New tests [PATCH v2 3/3] Implementation " Thanks -- Thomas