From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 8CEF48D4D; Wed, 1 Aug 2018 16:37:12 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0726021B88; Wed, 1 Aug 2018 10:37:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 01 Aug 2018 10:37:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=K3ExHZYxKkpUIpJ8XOy1bTq9Jm m7Dy47/qQQVIJuDG0=; b=N3/+AXaNiAgkFor3xYGpHaU3U7SGieT4291aSmQvgK TnYyuidIajKgPFLomhj2s2bvU6IqwBJuZIsbZv4pCE5z5eL45t980bt81mKGfY22 n8FoT18T/6lyauuKFRFiz4ekd0GM0a5TVrDpEESjg76bJ0/c2pqI1OhUbV1VN+mS g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=K3ExHZ YxKkpUIpJ8XOy1bTq9Jmm7Dy47/qQQVIJuDG0=; b=kdufSKxOngQRf8Qzy6ksMu 5y0yGB9Ac9FsSV75CiwLKOTvB1hUie1tWtV1vUTb6M3F86uCMSxW077pymH1XbdJ KGliYT6sqF1namn1mAQ3QejKpcKxUE7A+S88f6qFrpakAaY3ZZLYymiWCIK66lKf upn4PO5HMUOmGYEKW0iTYJDZ0YEUKq1CZdfh4h7MU0iKlsPV1SZm//BAifHms8IK xjDB3/b1i0wfQSrWMIbxzAZj2xH2zlGnYyHHUAiHBlh9KDGAIDSvJlCMWnPB3qmA q38tHsGUrP2wBEFlGi2yqZDOzpOOHlhxFiL3e91VPSZhqrSiUlqTrsIO0WwUAuDQ == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DD4E81025D; Wed, 1 Aug 2018 10:37:10 -0400 (EDT) From: Thomas Monjalon To: Gavin Hu Cc: dev@dpdk.org, "Mcnamara, John" , "honnappa.nagarahalli@arm.com" , "stable@dpdk.org" Date: Wed, 01 Aug 2018 16:37:06 +0200 Message-ID: <15666811.Czcatj4Lj7@xps> In-Reply-To: References: <20180801052257.14869-1-gavin.hu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] devtools: trap SIGINT is not recognizable to dash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 14:37:12 -0000 > > When running checkpatch.sh, it generates the following error on some linux > > distributions(like Debian) with Dash as the default shell interpreter. > > trap: SIGINT: bad trap > > > > The fix is to replace SIGINT with INT signal, it works for both bash and > > dash. > > > > Fixes: 4bec48184e ("devtools: add checks for ABI symbol addition") > > Cc: stable@dpdk.org > > > > Signed-off-by: Gavin Hu > > Reviewed-by: Honnappa Nagarahalli > > Acked-by: John McNamara Applied, thanks