From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 897C2A0613
for <public@inbox.dpdk.org>; Tue, 27 Aug 2019 16:26:53 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id E10741C192;
Tue, 27 Aug 2019 16:26:30 +0200 (CEST)
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 6BD841C123
for <dev@dpdk.org>; Tue, 27 Aug 2019 16:26:18 +0200 (CEST)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
(No client certificate requested)
by mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 63B8F4005C;
Tue, 27 Aug 2019 14:26:17 +0000 (UTC)
Received: from ocex03.SolarFlarecom.com (10.20.40.36) by
ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id
15.0.1395.4; Tue, 27 Aug 2019 07:26:14 -0700
Received: from opal.uk.solarflarecom.com (10.17.10.1) by
ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id
15.0.1395.4 via Frontend Transport; Tue, 27 Aug 2019 07:26:14 -0700
Received: from ukv-loginhost.uk.solarflarecom.com
(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])
by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id x7REQCg6004167;
Tue, 27 Aug 2019 15:26:13 +0100
Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])
by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id AC6A01613D2;
Tue, 27 Aug 2019 15:26:13 +0100 (BST)
From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Maryam Tahhan <maryam.tahhan@intel.com>, Reshma Pattan
<reshma.pattan@intel.com>
CC: <dev@dpdk.org>, Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
Date: Tue, 27 Aug 2019 15:25:19 +0100
Message-ID: <1566915962-5472-9-git-send-email-arybchenko@solarflare.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1566915962-5472-1-git-send-email-arybchenko@solarflare.com>
References: <1566915962-5472-1-git-send-email-arybchenko@solarflare.com>
MIME-Version: 1.0
Content-Type: text/plain
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24872.005
X-TM-AS-Result: No-4.545200-4.000000-10
X-TMASE-MatchedRID: dydEoroocbPDOgXZFRFV8+b3p4cnIXGNAPiR4btCEeY7FE26mju9OzgK
6rBjXxyiNOr0WzHbLlePQi9XuOWoOHI/MxNRI7Uk+L2GsArAgtpfAXPuWnqbj7lmMfLNiuka+9R
qUr/gzAx08ToOi0smNSJ1igIe5xA1WU/fB/XFmJynRPnrtF/XIQGZ/+APXW9kHWtVZN0asTgy+1
WM4JyCSeLzNWBegCW2wgn7iDBesS0nRE+fI6etknsdyqMmfSVC3q/Iz4cs4FNbksCUTGgwoEBMC
reA7LVg/PabWcsx+SwZb4ModJLrRTuRLcJMYtXxEvwnn3xrrimPblmkoVd+2r1NuKS30BZnQIFI
ZLtsgG0DUH+nVLNyiCsqIP9TxvtJMb6p570ilnc=
X-TM-AS-User-Approved-Sender: No
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10--4.545200-4.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24872.005
X-MDID: 1566915978-HIidbrhPkUUw
Subject: [dpdk-dev] [PATCH 08/51] app/procinfo: check status of getting
ethdev info
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
rte_eth_dev_info_get() return value was changed from void to int, so
this patch modify rte_eth_dev_info_get() usage across app/procinfo
according to its new return type.
Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
app/proc-info/main.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index a89b51b..34eb7a7 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -683,7 +683,12 @@ static void collectd_resolve_cnt_type(char *cnt_type, size_t cnt_type_len,
if (ret == 0)
printf("\t -- mtu (%d)\n", mtu);
- rte_eth_dev_info_get(i, &dev_info);
+ ret = rte_eth_dev_info_get(i, &dev_info);
+ if (ret != 0) {
+ printf("Error during getting device (port %u) info: %s\n",
+ i, strerror(-ret));
+ return;
+ }
printf(" - queue\n");
for (j = 0; j < dev_info.nb_rx_queues; j++) {
@@ -836,7 +841,13 @@ static void collectd_resolve_cnt_type(char *cnt_type, size_t cnt_type_len,
memset(&cap, 0, sizeof(cap));
memset(&error, 0, sizeof(error));
- rte_eth_dev_info_get(i, &dev_info);
+ ret = rte_eth_dev_info_get(i, &dev_info);
+ if (ret != 0) {
+ printf("Error during getting device (port %u) info: %s\n",
+ i, strerror(-ret));
+ return;
+ }
+
printf(" - Generic for port (%u)\n"
"\t -- driver name %s\n"
"\t -- max vf (%u)\n"
--
1.8.3.1