From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 419762B9B for ; Mon, 24 Apr 2017 10:04:43 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C46EB20D07; Mon, 24 Apr 2017 04:04:41 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 24 Apr 2017 04:04:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=whQPU7A345GfBra +xSIiImE6HqTZ3WEiXGikAoqxBTI=; b=o84V9u4YdtWpVkJaywfO3QLRv28hevw seRt6XAd1vrlUixU9KR8dFEzOlDQUtWJtirfuvi4yVWbDrrFpUo1IqclZy2sPnd3 AbONtsouATci82x+/2NiE1fUCxoq2cBTHe5WRcLsH9z7pHOlbPybypAuQUIMfuvb YkJObaIVYQIA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=whQPU7A345GfBra+xSIiImE6HqTZ3WEiXGikAoqxBTI=; b=QHZiTAYO mYKiajXb6NF/+0cbigBxp2U+5PAw4jn2rmno9MGiAFah9EzwG+Wg04O241Yt5cOv yi+LYM3jZq/Quv3Fw1QVuFHNL5vyC7k2Nen6P5Tr6IzrInToGGjlYYfP4crl2XDH qlwH1HUbaJ/7gBYD8vjmJw81lxvNFC9J47YK7xYhkIOHADzJZxGRCFPXmDQ7LVyw n4OEcn9H+Gjk2ZnuKJ+abMc3eWqGrW58tAIMWKu2OPIQSit9rXmYXhEjZHAZVxrP RvbYIcudRPx5c5/S3S6nlvGw2dtto/ThEqqsLwuqhJ2h8NIvYYcsBOO90TStRavP UVvhd4M8CeNc3g== X-ME-Sender: X-Sasl-enc: uiB812Oel5XqbOA6urg4e+EkaFa8TQrlKakzudecdtWI 1493021081 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 408F97E320; Mon, 24 Apr 2017 04:04:41 -0400 (EDT) From: Thomas Monjalon To: "Zhao1, Wei" Cc: dev@dpdk.org, Yuanhan Liu , "Ananyev, Konstantin" , "Mcnamara, John" , "Lu, Wenzhuo" , "Liu, Yu Y" Date: Mon, 24 Apr 2017 10:04:40 +0200 Message-ID: <1567270.9lMUqcoftf@xps> In-Reply-To: References: <1490866456-52241-1-git-send-email-wei.zhao1@intel.com> <20170424020120.GC11512@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for port reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Apr 2017 08:04:43 -0000 24/04/2017 05:39, Zhao1, Wei: > Hi, yuanhan & thomas > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > > On Fri, Apr 21, 2017 at 11:28:37AM +0200, Thomas Monjalon wrote: > > > > Maybe I should add some words in doc\guides\nics\i40e.rst to Record > > > > which configurations are saved and restored by the PMD driver in > > > > reset function. Which not list in that are recognized as not saved > > > > and restored by default. OTHER NIC for this feature can add similar > > > > record in their xxx.rst. > > > > > > No, when defining a generic API in ethdev, we must define the same > > > behaviour for every drivers. > > > > Agreed. That was my point. > > > > --yliu > > > > > Please check how to make the behaviour consistent and documented in > > > ethdev. We may need to document your new function and start/stop also. > > Do you have any suggestion on which document in rte layer to record store > and restore info by me? It should be documented in the doxygen comment of the functions. Either we explain which configuration is restored on start and reset, or we state everything (or nothing) is restored except the configurations commented in the related configuration functions.