From: Andy Pei <andy.pei@intel.com>
To: dev@dpdk.org
Cc: rosen.xu@intel.com, xiaolong.ye@intel.com, tiwei.bie@intel.com,
xiao.w.wang@intel.com
Subject: [dpdk-dev] [PATCH 3/4] vhost: call vDPA callback at the end of vring enable handler
Date: Fri, 6 Sep 2019 11:20:50 +0800 [thread overview]
Message-ID: <1567740051-367172-3-git-send-email-andy.pei@intel.com> (raw)
In-Reply-To: <1567740051-367172-1-git-send-email-andy.pei@intel.com>
vDPA's set_vring_state callback would need to know the virtqueues'
enable status to configure the hardware.
Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
Signed-off-by: Andy Pei <andy.pei@intel.com>
---
lib/librte_vhost/rte_vdpa.h | 4 ++--
lib/librte_vhost/vhost_user.c | 5 +++--
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h
index 9a3deb3..19cf897 100644
--- a/lib/librte_vhost/rte_vdpa.h
+++ b/lib/librte_vhost/rte_vdpa.h
@@ -54,8 +54,8 @@ struct rte_vdpa_dev_ops {
int (*dev_conf)(int vid);
int (*dev_close)(int vid);
- /** Enable/disable this vring */
- int (*set_vring_state)(int vid, int vring, int state);
+ /** Enable/disable vring queue pairs */
+ int (*set_vring_state)(int vid);
/** Set features when changed */
int (*set_features)(int vid);
diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
index 0b72648..21028cc 100644
--- a/lib/librte_vhost/vhost_user.c
+++ b/lib/librte_vhost/vhost_user.c
@@ -1346,8 +1346,6 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev __rte_unused,
did = dev->vdpa_dev_id;
vdpa_dev = rte_vdpa_get_device(did);
- if (vdpa_dev && vdpa_dev->ops->set_vring_state)
- vdpa_dev->ops->set_vring_state(dev->vid, index, enable);
if (dev->notify_ops->vring_state_changed)
dev->notify_ops->vring_state_changed(dev->vid,
@@ -1359,6 +1357,9 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev __rte_unused,
dev->virtqueue[index]->enabled = enable;
+ if (vdpa_dev && vdpa_dev->ops->set_vring_state)
+ vdpa_dev->ops->set_vring_state(dev->vid);
+
return RTE_VHOST_MSG_RESULT_OK;
}
--
1.8.3.1
next prev parent reply other threads:[~2019-09-06 3:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 3:20 [dpdk-dev] [PATCH 1/4] vhost: introduce new API to get the active vring number Andy Pei
2019-09-06 3:20 ` [dpdk-dev] [PATCH 2/4] net/ifcvf: add multiqueue configuration Andy Pei
2019-09-06 3:20 ` Andy Pei [this message]
2019-09-12 7:41 ` [dpdk-dev] [PATCH 3/4] vhost: call vDPA callback at the end of vring enable handler Wang, Xiao W
2019-09-17 7:29 ` Pei, Andy
2019-09-06 3:20 ` [dpdk-dev] [PATCH 4/4] net/ifcvf: enable mutliqueue support Andy Pei
2019-09-12 7:41 ` Wang, Xiao W
2019-09-06 13:25 ` [dpdk-dev] [PATCH 1/4] vhost: introduce new API to get the active vring number Aaron Conole
2019-09-17 9:25 ` Pei, Andy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1567740051-367172-3-git-send-email-andy.pei@intel.com \
--to=andy.pei@intel.com \
--cc=dev@dpdk.org \
--cc=rosen.xu@intel.com \
--cc=tiwei.bie@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).