From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 16CE2A2EDB
for <public@inbox.dpdk.org>; Fri, 6 Sep 2019 09:33:55 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id BA7FA1F1BE;
Fri, 6 Sep 2019 09:32:35 +0200 (CEST)
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id D11B31F168
for <dev@dpdk.org>; Fri, 6 Sep 2019 09:31:56 +0200 (CEST)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
(No client certificate requested)
by mx1-us2.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id D3AF4340058;
Fri, 6 Sep 2019 07:31:55 +0000 (UTC)
Received: from ocex03.SolarFlarecom.com (10.20.40.36) by
ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id
15.0.1395.4; Fri, 6 Sep 2019 00:31:51 -0700
Received: from opal.uk.solarflarecom.com (10.17.10.1) by
ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id
15.0.1395.4 via Frontend Transport; Fri, 6 Sep 2019 00:31:51 -0700
Received: from ukv-loginhost.uk.solarflarecom.com
(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])
by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id x867Vo7h027678;
Fri, 6 Sep 2019 08:31:50 +0100
Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])
by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 152F61613D1;
Fri, 6 Sep 2019 08:31:50 +0100 (BST)
From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
CC: <dev@dpdk.org>, Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
Date: Fri, 6 Sep 2019 08:30:26 +0100
Message-ID: <1567755066-31389-15-git-send-email-arybchenko@solarflare.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1567755066-31389-1-git-send-email-arybchenko@solarflare.com>
References: <1566915962-5472-1-git-send-email-arybchenko@solarflare.com>
<1567755066-31389-1-git-send-email-arybchenko@solarflare.com>
MIME-Version: 1.0
Content-Type: text/plain
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24892.005
X-TM-AS-Result: No-1.429000-4.000000-10
X-TMASE-MatchedRID: Y4ICLEyyxIvDOgXZFRFV8+b3p4cnIXGNAPiR4btCEeYd0WOKRkwsh2hk
SwpykoqVx/C5Mf1iTDxJiw1+UvifpSxppiUy9o4cA9lly13c/gEvV5f7P0HVDOWTwJYZ5m89XWj
vA8TpWFjGfSS26JWl2rlxRECWghM+HxPMjOKY7A8LbigRnpKlKVHxEBQar9Jn5Z0CCsRnLzB3oP
6JNQsSHwh+YNrP1gGN8oboEtKRo/+r0EOI/qkOz/OYKNtNJTUOy+0TInUAS9USS6hOww/sW6MPT
FnhWOxK5APDq2B3cAxn2JWP8qFf9FKehBzm9vnO5B2Qzud0EsI7z/PzND407cC+ksT6a9fy
X-TM-AS-User-Approved-Sender: No
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10-1.429000-4.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24892.005
X-MDID: 1567755116-PcyX2w1sq-HQ
Subject: [dpdk-dev] [PATCH v3 14/54] net/failsafe: check status of getting
ethdev info
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
rte_eth_dev_info_get() return value was changed from void to
int, so this patch modify rte_eth_dev_info_get() usage across
net/failsafe according to its new return type.
Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---
drivers/net/failsafe/failsafe_ops.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c
index 96e05d4dc4..b3df626aaa 100644
--- a/drivers/net/failsafe/failsafe_ops.c
+++ b/drivers/net/failsafe/failsafe_ops.c
@@ -866,6 +866,7 @@ fs_dev_infos_get(struct rte_eth_dev *dev,
{
struct sub_device *sdev;
uint8_t i;
+ int ret;
/* Use maximum upper bounds by default */
infos->max_rx_pktlen = UINT32_MAX;
@@ -933,7 +934,9 @@ fs_dev_infos_get(struct rte_eth_dev *dev,
FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_PROBED) {
struct rte_eth_dev_info sub_info;
- rte_eth_dev_info_get(PORT_ID(sdev), &sub_info);
+ ret = rte_eth_dev_info_get(PORT_ID(sdev), &sub_info);
+ if (ret != 0)
+ return;
fs_dev_merge_info(infos, &sub_info);
}
--
2.17.1