From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id AA2C3A2EEB
for <public@inbox.dpdk.org>; Thu, 12 Sep 2019 18:43:54 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 4B89F1EF41;
Thu, 12 Sep 2019 18:43:37 +0200 (CEST)
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id E37921EDB4
for <dev@dpdk.org>; Thu, 12 Sep 2019 18:43:28 +0200 (CEST)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
(No client certificate requested)
by mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id E35AF4C0058;
Thu, 12 Sep 2019 16:43:27 +0000 (UTC)
Received: from ocex03.SolarFlarecom.com (10.20.40.36) by
ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id
15.0.1395.4; Thu, 12 Sep 2019 09:43:20 -0700
Received: from opal.uk.solarflarecom.com (10.17.10.1) by
ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id
15.0.1395.4 via Frontend Transport; Thu, 12 Sep 2019 09:43:20 -0700
Received: from ukv-loginhost.uk.solarflarecom.com
(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])
by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id x8CGhJMM023676;
Thu, 12 Sep 2019 17:43:19 +0100
Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])
by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 3C0BC1613D1;
Thu, 12 Sep 2019 17:43:19 +0100 (BST)
From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Reshma Pattan <reshma.pattan@intel.com>
CC: <dev@dpdk.org>, Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com>
Date: Thu, 12 Sep 2019 17:42:18 +0100
Message-ID: <1568306586-27831-8-git-send-email-arybchenko@solarflare.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1568306586-27831-1-git-send-email-arybchenko@solarflare.com>
References: <1566915962-5472-1-git-send-email-arybchenko@solarflare.com>
<1568306586-27831-1-git-send-email-arybchenko@solarflare.com>
MIME-Version: 1.0
Content-Type: text/plain
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24906.005
X-TM-AS-Result: No-3.004500-4.000000-10
X-TMASE-MatchedRID: 3VvmmxedNeLDOgXZFRFV8+b3p4cnIXGNAPiR4btCEeZ+SLLtNOiBhlMe
5Blkpry7rdoLblq9S5ryf5NFbXKEM28BU9XGR8QhUyxW4vmvLt2ByxVkfd04JHDufZqx8z9XedR
sVpejKZ4/JyK02Hpo2oAy6p60ZV62fJ5/bZ6npdjGVuWouVipchF1ifNGC37LEZvtSbtc4owGuG
IIbxFopLoShxT6auRNWmHr18hHJlFrKUpSu3mq1sjgbL3bcc7J60NBHxEKsBPQRWJWSEgvhvDsn
HBTQS9kyoRE4tv/7I7j/Qm+fSvAAma0vgPD7M1v1PYfTfPNTUk=
X-TM-AS-User-Approved-Sender: No
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10--3.004500-4.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24906.005
X-MDID: 1568306608-7SWjFgRswwWW
Subject: [dpdk-dev] [PATCH v4 07/54] pdump: check status of getting ethdev
info
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com>
rte_eth_dev_info_get() return value was changed from void to int,
so this patch modify rte_eth_dev_info_get() usage across
pdump component according to its new return type.
Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
lib/librte_pdump/rte_pdump.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c
index cd24dd010..ac94fea93 100644
--- a/lib/librte_pdump/rte_pdump.c
+++ b/lib/librte_pdump/rte_pdump.c
@@ -333,7 +333,14 @@ set_pdump_rxtx_cbs(const struct pdump_request *p)
if (queue == RTE_PDUMP_ALL_QUEUES) {
struct rte_eth_dev_info dev_info;
- rte_eth_dev_info_get(port, &dev_info);
+ ret = rte_eth_dev_info_get(port, &dev_info);
+ if (ret != 0) {
+ RTE_LOG(ERR, PDUMP,
+ "Error during getting device (port %u) info: %s\n",
+ port, strerror(-ret));
+ return ret;
+ }
+
nb_rx_q = dev_info.nb_rx_queues;
nb_tx_q = dev_info.nb_tx_queues;
if (nb_rx_q == 0 && flags & RTE_PDUMP_FLAG_RX) {
--
2.17.1