From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id BB7B91B207; Wed, 27 Mar 2019 01:09:02 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 941D646B4; Tue, 26 Mar 2019 20:09:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 26 Mar 2019 20:09:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=zmTbEE5YGihrk0Y6+R8jXkhHWFA3SJ3Qu0pmBLLm4Lg=; b=fjpSvkmGQNvx IN1o+zf19nnLloHUs+f0wXvYJZMx4vvtm+rEh5/CCst38SmXszmsdjYG6h82BpnX hrr0xR7sDCkANi8r6ZCxaP+yQGdfg2Ft8qP7daCb9FQAHxC8654Yt4QirEoJpyxO NpNTNJ/iccYgcvZ+2xb6a6KbvOn6cE4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=zmTbEE5YGihrk0Y6+R8jXkhHWFA3SJ3Qu0pmBLLm4 Lg=; b=ID7U9AbW07EKO0Fb3D701DueY9LbBmszcCNY3FOcWo8lprlQpM1fwces6 YyoDUP81D99MS/Q3EkCUDWmcyZkQyG59zNmnfugdPeLNHgk9cTDWe8vJGX84vImn PZQbo50f+L98C8qF9b32AAcZ/MuFsK9vNuybjonSGOCtHnqMRYnOBqd6PijAkZpy aZZsmYAiDHMJ/DgnfVxpXwrVNlIi/8NEWp6QVMEEGN1NFppMCPEXjPEmlJs2LHvH Z/jVBSlckn7nmBV4jUCzMQJdOdvW8/fGHYotZkMOTDcOEllOfY0pf0CSp60e8S+v pkZG9jBU1H1Itb2Nz3UOAjrkw+NOQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkedugddujecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E5D30E4805; Tue, 26 Mar 2019 20:08:59 -0400 (EDT) From: Thomas Monjalon To: Reshma Pattan Cc: stable@dpdk.org, Rami Rosen , dev , "Rosen, Rami" , bruce.richardson@intel.com Date: Wed, 27 Mar 2019 01:08:58 +0100 Message-ID: <1568544.Edi8VMo79k@xps> In-Reply-To: References: <20190320113319.26134-1-reshma.pattan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test: fix build when pdump config is disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Mar 2019 00:09:03 -0000 20/03/2019 16:17, Rami Rosen: > pdump unit test has dependency on pthread code > in test.c and process.h to run send_pkts(), > this code should be enabled only when > CONFIG_RTE_LIBRTE_PDUMP is enabled. > > Bugzilla ID: 222 > > Fixes: 086eb64db3 ("test/pdump: add unit test for pdump library") > CC: stable@dpdk.org > > Signed-off-by: Reshma Pattan > > +1 > > Checked when CONFIG_RTE_LIBRTE_PDUMP=n > with latest code from master, build completes succesfully > > Reviewed-by: Rami Rosen Applied, thanks Note that such #ifdef will be removed when the "make build system" will be removed from DPDK (far target). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 34948A05D3 for ; Wed, 27 Mar 2019 01:09:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 60A161B2AF; Wed, 27 Mar 2019 01:09:03 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id BB7B91B207; Wed, 27 Mar 2019 01:09:02 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 941D646B4; Tue, 26 Mar 2019 20:09:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 26 Mar 2019 20:09:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=zmTbEE5YGihrk0Y6+R8jXkhHWFA3SJ3Qu0pmBLLm4Lg=; b=fjpSvkmGQNvx IN1o+zf19nnLloHUs+f0wXvYJZMx4vvtm+rEh5/CCst38SmXszmsdjYG6h82BpnX hrr0xR7sDCkANi8r6ZCxaP+yQGdfg2Ft8qP7daCb9FQAHxC8654Yt4QirEoJpyxO NpNTNJ/iccYgcvZ+2xb6a6KbvOn6cE4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=zmTbEE5YGihrk0Y6+R8jXkhHWFA3SJ3Qu0pmBLLm4 Lg=; b=ID7U9AbW07EKO0Fb3D701DueY9LbBmszcCNY3FOcWo8lprlQpM1fwces6 YyoDUP81D99MS/Q3EkCUDWmcyZkQyG59zNmnfugdPeLNHgk9cTDWe8vJGX84vImn PZQbo50f+L98C8qF9b32AAcZ/MuFsK9vNuybjonSGOCtHnqMRYnOBqd6PijAkZpy aZZsmYAiDHMJ/DgnfVxpXwrVNlIi/8NEWp6QVMEEGN1NFppMCPEXjPEmlJs2LHvH Z/jVBSlckn7nmBV4jUCzMQJdOdvW8/fGHYotZkMOTDcOEllOfY0pf0CSp60e8S+v pkZG9jBU1H1Itb2Nz3UOAjrkw+NOQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkedugddujecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E5D30E4805; Tue, 26 Mar 2019 20:08:59 -0400 (EDT) From: Thomas Monjalon To: Reshma Pattan Cc: stable@dpdk.org, Rami Rosen , dev , "Rosen, Rami" , bruce.richardson@intel.com Date: Wed, 27 Mar 2019 01:08:58 +0100 Message-ID: <1568544.Edi8VMo79k@xps> In-Reply-To: References: <20190320113319.26134-1-reshma.pattan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test: fix build when pdump config is disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190327000858.0t3GENgRcNEs5ePAXL8EU4YDRultsQc07tW6EQDBS8Y@z> 20/03/2019 16:17, Rami Rosen: > pdump unit test has dependency on pthread code > in test.c and process.h to run send_pkts(), > this code should be enabled only when > CONFIG_RTE_LIBRTE_PDUMP is enabled. > > Bugzilla ID: 222 > > Fixes: 086eb64db3 ("test/pdump: add unit test for pdump library") > CC: stable@dpdk.org > > Signed-off-by: Reshma Pattan > > +1 > > Checked when CONFIG_RTE_LIBRTE_PDUMP=n > with latest code from master, build completes succesfully > > Reviewed-by: Rami Rosen Applied, thanks Note that such #ifdef will be removed when the "make build system" will be removed from DPDK (far target).