From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com
 [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id 7B28DAE99
 for <dev@dpdk.org>; Thu, 12 Jun 2014 00:46:21 +0200 (CEST)
Received: by mail-wi0-f178.google.com with SMTP id n15so1972872wiw.5
 for <dev@dpdk.org>; Wed, 11 Jun 2014 15:46:36 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=VKeLdpAGP7xGwp9iN7uqYAcW60KzlJD1n8uoLuwYqG8=;
 b=JYBuqijPIGQA/44M2PbdKYUCdBr1lfJzDnhzBBEin97iJvWWgsaccHwvLLKumJH6yW
 CeWmZpnUeVKYqU5uYkAYhodYXZo4aHZL/UCseuTO3dtLb469YOwg62ws4OQCG41XU2/0
 5Xml/sYNUnQeX3ne53QfWz+vO4rPaJXbQpvAiXKtMn6RYKTI24lDYWTe7WEtUteWmLTQ
 0lacb01fRkoBGQMwtbvRPXzxP7i9qAzMllFPXBHBYzYmGH9TRfaCwrHBo9JA8hi4zFKs
 FTPrvN686G2nApBxBHWULTjZzbwNUfuZ57hQXAIBxNaD2+ee62/PoLBXR974xTybCwFa
 91ig==
X-Gm-Message-State: ALoCoQmCnJwshDixdvnSa9u4nok5gIiPmQaB1cllW0XmJ8sdxteyfRCmBQ8YzvbX8WG0o7tLKJ0+
X-Received: by 10.194.240.33 with SMTP id vx1mr8915165wjc.88.1402526796228;
 Wed, 11 Jun 2014 15:46:36 -0700 (PDT)
Received: from xps13.localnet (ip-96.net-80-236-123.rev.numericable.fr.
 [80.236.123.96])
 by mx.google.com with ESMTPSA id gc5sm419068wic.6.2014.06.11.15.46.34
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 11 Jun 2014 15:46:35 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Lu, Patrick" <patrick.lu@intel.com>
Date: Thu, 12 Jun 2014 00:46:35 +0200
Message-ID: <1568785.Z4e68NZ92R@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; )
In-Reply-To: <EFC7DD9FAC418F4683FA895DBD8B35A30E1B9C53@FMSMSX101.amr.corp.intel.com>
References: <1402519509-26653-1-git-send-email-Patrick.Lu@intel.com>
 <9007853.cgh6aaULN3@xps13>
 <EFC7DD9FAC418F4683FA895DBD8B35A30E1B9C53@FMSMSX101.amr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Add an API to query enabled core index
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Jun 2014 22:46:21 -0000

2014-06-11 21:58, Lu, Patrick:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] 
> > 2014-06-11 13:45, Patrick Lu:
> > > The new API rte_lcore_id2() will return an index from enabled lcores
> > > starting from zero.
> > 
> > I think core_id2 is not a representative name.
> > What do you think of renaming core_id as lcore_hwid and core_id2 as
> > lcore_index? 
> 
> I think this is a good idea. Except core_id is used in 13 other places.
> Should I resubmit the patch with core_id renamed it lcore_hwid?

It should be in a separated patch. A patch-serie would be appreciated.

By the way, I don't see any reason to integrate this change in DPDK 1.7.0
as we are in feature freeze phase.

-- 
Thomas