From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id AA5D65583 for ; Wed, 21 Jun 2017 12:41:43 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 47EEB20763; Wed, 21 Jun 2017 06:41:43 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 21 Jun 2017 06:41:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=0Rnhysh+HOGtk26 4g4OWlu2viRJqRwhiRewHpmOimr4=; b=Bqz/lysSzj9VGJwUeXD3AhTpFsv8vFu MaF1cnEBZjS3xxQS9dnAJ3LddskqsoT111lrRJmXsHUvyJoOaxKIRMlYyserba7u VFEbD2mYCc92SaMPSr9L/SxRA9sB7soQ2Oe5nY4b76i6fhBPGIQLFHr5BJCo8Hz9 MXnySquvVZO8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=0Rnhysh+HOGtk264g4OWlu2viRJqRwhiRewHpmOimr4=; b=HNbve3ZZ OZB5jYtxSGmyC0H+gOL3LrFcFqY3/kvHZz9UeHd2QnV0EzmUQwYVgCMh2/ntsIhz 0s+1QxLP9mk+2A4/gQF4K8lbfA2hOzeLLsMEXfPhkoA20dAl/tKdmSU6awA5ujIZ hr7kreoAPCaKiWczNFBJam6IDbTEAKbHv8r5429nFrS1tGPwRfWk22ovrxcUw+Si vvGtbcP79a+3JAhUpeM30URamMSI45uCdtQFu8SRQ3cDsDXT7USLBTUy4tNhuNDp WAmu0SAcSSBaisFXOuLrRSRfU706ZKqBKhiqiiGn6FL95FLaL3C/gIm1pa1dKmGQ T0whx3ieHFJuHQ== X-ME-Sender: X-Sasl-enc: XHvTyVatkHEN30J8j6gW53QEXvbZVp5HYRkXJb3UCTsQ 1498041702 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E0D5A7E32F; Wed, 21 Jun 2017 06:41:42 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: gaetan.rivet@6wind.com, dev@dpdk.org Date: Wed, 21 Jun 2017 12:41:42 +0200 Message-ID: <1569330.jjeHmIoRYc@xps> In-Reply-To: <20170621102702.GA93468@bricha3-MOBL3.ger.corp.intel.com> References: <20170620212139.9508-1-thomas@monjalon.net> <20170621102702.GA93468@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC PATCH] mk: symlink every headers first X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2017 10:41:43 -0000 21/06/2017 12:27, Bruce Richardson: > On Tue, Jun 20, 2017 at 11:21:39PM +0200, Thomas Monjalon wrote: > > If a library or a build tool uses a definition from a driver, > > there is a build ordering issue, like seen when moving PCI code > > into a bus driver. > > > > One option is to keep PCI helpers and some common definitions in EAL. > > The other option is to symlink every headers at the beginning of > > the build so they can be included by any other component. > > > > This patch shows how to achieve the second option. > > > > Signed-off-by: Thomas Monjalon > > --- > > My 2c. > > This may be worth doing, however, two points to consider. > > 1. If we look to change build system this may not be worth doing unless > a compelling need becomes obvious in the short term. In the meantime, > for cases where it is needed... > 2. libraries can already access the includes from drivers or other > places fairly easily, just by adding the relevant "-I" flag to the > CFLAGS for that lib. You mean adding a -I pointing to source location instead of the build directory? > That said, since the work is already done developing this, and if it > doesn't hurt in terms of build time, I suppose we might as well merge > it in. It hurts a bit the build time. > So tentative ack from me, subject to testing and feedback from others. I would prefer not applying this patch if Gaetan can organize EAL and bus drivers in a way that everything compile fine. Libraries should not look into drivers.