From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-gw3-out.broadcom.com (mail-gw3-out.broadcom.com [216.31.210.64]) by dpdk.org (Postfix) with ESMTP id BDC3B8DB4 for ; Fri, 15 Jan 2016 01:59:39 +0100 (CET) X-IronPort-AV: E=Sophos;i="5.22,297,1449561600"; d="scan'208";a="85389793" Received: from irvexchcas08.broadcom.com (HELO IRVEXCHCAS08.corp.ad.broadcom.com) ([10.9.208.57]) by mail-gw3-out.broadcom.com with ESMTP; 14 Jan 2016 17:38:13 -0800 Received: from IRVEXCHMB14.corp.ad.broadcom.com ([fe80::6184:5cb6:5350:4823]) by IRVEXCHCAS08.corp.ad.broadcom.com ([::1]) with mapi id 14.03.0235.001; Thu, 14 Jan 2016 16:59:38 -0800 From: Stephen Hurd To: Bruce Richardson Thread-Topic: [dpdk-dev] [PATCH v2] app/testpmd Fix max_socket detection Thread-Index: AQHRTlEb3ozNst7rzUSga7vKKW4E9p77jM+AgAA0+UA= Date: Fri, 15 Jan 2016 00:59:37 +0000 Message-ID: <156984479488CD49A184F5CAB4AF9346071A39E8@IRVEXCHMB14.corp.ad.broadcom.com> References: <24888901-A45C-4E23-871E-3485AF2423D2@intel.com> <1452723816-73141-1-git-send-email-shurd@broadcom.com> <20160114134418.GA18000@bricha3-MOBL3> In-Reply-To: <20160114134418.GA18000@bricha3-MOBL3> Accept-Language: en-CA, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.9.208.64] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd Fix max_socket detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jan 2016 00:59:40 -0000 Yes, this is cause a bug which prevents cross-socket testing... per michael= .qiu@intel.com on Fri 12/18/2015 5:33 PM (unable to find email on the list= ) >> Hi, Stephen >>=20 >> I just see this patch and found some issue with it. >>=20 >> When I start testpmd with -c 0x3 but with socket-num 1, that means run >> lcore in socket 0, but want hugepage allocated in socket 1, in previous, >> it works, I don't know why you force it in the socket lcore locates.I >> would like to give a warning instead of failure. just like before: >>=20 >> EAL: Requesting 512 pages of size 2MB from socket 1 >> EAL: TSC frequency is ~2294689 KHz >> EAL: WARNING: Master core has no memory on local socket! >>=20 >> After your patch: >>=20 >> EAL: No probed ethernet devices >> Interactive-mode selected >> EAL: Error - exiting with code: 1 >> Cause: The socket number should be < 1 >> His example command was: ./testpmd -c 0x3 -n 4 -- -i -socket-num=3D1 -- Stephen Hurd -----Original Message----- From: Bruce Richardson [mailto:bruce.richardson@intel.com]=20 Sent: Thursday, January 14, 2016 5:44 AM To: Stephen Hurd Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd Fix max_socket detection On Wed, Jan 13, 2016 at 02:23:36PM -0800, Stephen Hurd wrote: > Previously, max_socket was set to the highest numbered socket with > an enabled lcore. The intent is to set it to the highest socket > regardless of it being enabled. >=20 Can you clarify why this changes is necessary? Is it causing a bug somewher= e? thanks, /Bruce